From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7517CC4320E for ; Tue, 27 Jul 2021 20:17:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5588360F9B for ; Tue, 27 Jul 2021 20:17:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231560AbhG0URD (ORCPT ); Tue, 27 Jul 2021 16:17:03 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:27775 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230425AbhG0URB (ORCPT ); Tue, 27 Jul 2021 16:17:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627417020; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ByUPLbiVuvdvoapeEFXQAcFKJj/8lLrwBdwnV9vgH+s=; b=iIPYqXhCxCQ/tI2aYQFlODE1F3UluJwhMLsCtJIL6dxTpUc6duCZErA/0NMrf/FQ9v6VYQ kVXxAUsNLVyGRANNgGGwZuA/kcpiszOqAO1LQ4eAMpIY3IBJLke102HomkElsJgcSwK3U4 9oeGI14kIdPEi0z3L79v7iom4+LBXQw= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-504-iF47fWH6Oy2iUPfTVhnXug-1; Tue, 27 Jul 2021 16:16:59 -0400 X-MC-Unique: iF47fWH6Oy2iUPfTVhnXug-1 Received: by mail-qt1-f198.google.com with SMTP id f9-20020a05622a1a09b02902615523e725so6931161qtb.21 for ; Tue, 27 Jul 2021 13:16:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=ByUPLbiVuvdvoapeEFXQAcFKJj/8lLrwBdwnV9vgH+s=; b=e2rX834VLIE+/ezGQ5Ywot0D6ipQjAY7slUu3wk3VSTeOu6mbFDtL4vp5xr45IlCKm BcIxiMUxVtSyZTjjJT8EJpQ+ZBv4NtPZHVu0Y3sRU/ygQ7QDIW6LoOKlSwSg80Ca0jpL bSKhyihu1KEfpJ5lqnMfvuieAfy4s1YojLk8r8wEBZmp+axIzps5+Vk9wUwUjSFBr7EL qLATGm/7xzWRdauMpyUGpzsEiIjDH4o68T87MxcyiDFJye4XpMmK9AZsIEvzX+G3Lc46 yudFnoPH2vhoDAppf+onWgrrq0ma3TflhrFHY5TGppqVk8E64bjamV/UX5kV22+aZlvx idDQ== X-Gm-Message-State: AOAM53360L9iV/zc5r14fke3fIXxNThhLOOylbHvdUrh0mxysGOLKYGe b1yNJat/glWl06fa4NRfptBnSP6OR+vIWGwiikNBmfqPya2o7fknaxqjGF6naPIqAmDdHydL8tn hOeCa1rFoZn7q7uTFDYmADGXA X-Received: by 2002:a05:620a:318e:: with SMTP id bi14mr21424389qkb.176.1627417018992; Tue, 27 Jul 2021 13:16:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzkKaLGiPqMLIncbtDqJyUsjY34972lfs0JJ1TJHQSJbPBkHyyv8W+CXGcrtPiJOkaTxPBjIQ== X-Received: by 2002:a05:620a:318e:: with SMTP id bi14mr21424373qkb.176.1627417018811; Tue, 27 Jul 2021 13:16:58 -0700 (PDT) Received: from llong.remote.csb ([2601:191:8500:76c0::cdbc]) by smtp.gmail.com with ESMTPSA id g10sm1910136qtp.67.2021.07.27.13.16.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jul 2021 13:16:58 -0700 (PDT) From: Waiman Long X-Google-Original-From: Waiman Long Subject: Re: [PATCH v3 2/9] cgroup/cpuset: Fix a partition bug with hotplug To: Tejun Heo Cc: Zefan Li , Johannes Weiner , Jonathan Corbet , Shuah Khan , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, Andrew Morton , Roman Gushchin , Phil Auld , Peter Zijlstra , Juri Lelli , Frederic Weisbecker , Marcelo Tosatti , =?UTF-8?Q?Michal_Koutn=c3=bd?= References: <20210720141834.10624-1-longman@redhat.com> <20210720141834.10624-3-longman@redhat.com> Message-ID: <2173a00b-504a-1932-877d-d26775e4775c@redhat.com> Date: Tue, 27 Jul 2021 16:16:56 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/26/21 6:59 PM, Tejun Heo wrote: > On Tue, Jul 20, 2021 at 10:18:27AM -0400, Waiman Long wrote: >> In cpuset_hotplug_workfn(), the detection of whether the cpu list >> has been changed is done by comparing the effective cpus of the top >> cpuset with the cpu_active_mask. However, in the rare case that just >> all the CPUs in the subparts_cpus are offlined, the detection fails >> and the partition states are not updated correctly. Fix it by forcing >> the cpus_updated flag to true in this particular case. >> >> Fixes: 4b842da276a8 ("cpuset: Make CPU hotplug work with partition") >> Signed-off-by: Waiman Long > Applied to cgroup/for-5.15 w/ a minor update to the comment (I dropped > "just" before "all". It read weird to me.) > > Thanks. > Thanks for fixing the wording. Cheers, Longman