From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1030441AbcGKIFY (ORCPT <rfc822;w@1wt.eu>);
	Mon, 11 Jul 2016 04:05:24 -0400
Received: from mout.kundenserver.de ([217.72.192.75]:55987 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753075AbcGKIFQ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 11 Jul 2016 04:05:16 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Jiri Slaby <jslaby@suse.cz>
Cc: Binoy Jayan <binoy.jayan@linaro.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: staging/wilc1000: wrong conversion to completion?
Date: Mon, 11 Jul 2016 10:08:44 +0200
Message-ID: <2175605.xXp7n8TQsH@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <b1b02b78-041e-469b-702c-d1b5ebef8ec7@suse.cz>
References: <b1b02b78-041e-469b-702c-d1b5ebef8ec7@suse.cz>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:26yjOO77UM4ezDB/O3Id1cVoacOPnNcOvJHzfhRME7M3yk77Nt8
 syI0NlSwQVREzDFpelTiV8EF6mTvMzxVVGK02Ngkkp/2MV6jo6B+TuxtY6JrXL3J+XKRcH1
 6nS5qdi6eY+aN0lTaiA8b/pT++6SUs8upFWQOD/Q/nTQ66osQNdofJIZ6jF9Wm4OXzvDGeG
 k0fu8f6REbEkzfQTaOThA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:FkSAZ5Y1sJs=:lNm5Qq/XaRq5mKUZSadPKF
 JwV71czcbdbRhnaWwd3KKbV5jACgcTxdr/WkKXVuD+CdLOe1GH67MaPwTMn/hfdRXUQUU07qR
 UQlE7SpWJwNbytDM2EDGEzYh2yrCglp7GvCjYOChUjS+UfaxyZrK2VXshdX+vwMRGvTKzaEwr
 /+mQGCxcYxajZCgHzS3eo8C5y3IdaYYBtUnYGJF2yTkkSgjMeWWfCBnwK+Rjir1NE2mOra3fO
 DbSTpsq2g2nE7+jgOeBqJcJAJjpbv+jvvjld9f3aKkrf4VALWked9NidNj5BfunpUHgYS1IBr
 2tDXychRRQeBswN7LHYsilH6oeAc7QNYptmTYTiExkRSsny53uXpUGYJ9MpBwhU5igaHIzkc2
 F/6MZ7ix04+BM/Jhr2uIaQhp+xMIA1ZV2O89lfysR55XvdrRAEmZ6Yx382HBryRW0ggx9dS+T
 p6lj1r24Fz0xyUA1KPS+rlSgAPQ58QgBRfWwdSDV9rOQ7yJ1iMND6I/lGx1l4o2r5qD6pkqbx
 5QTGGWKu1KcuSAfbdFUGOHQpC37hFlMP2g7Ka6+4rBxJRX0R0DcRkiOZ/izi/uuPMIrUTQEmF
 VSz9POtzGBTCKIrnV+FkHHOXQ5RXG0E+jtU2Cxs/JUzqTRcLl9xFnRVC4ZPrPrNO7ia5m3Ai6
 fqXzmVDez/bQaBY7sdSWglg1oIzypLmDniimkiHXUUboIyjfse9ng92JErp2vQ0maUTIG6R1D
 F0RkxfxeGuhbaJ54
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Monday, July 11, 2016 9:41:15 AM CEST Jiri Slaby wrote:
> Hi,
> 
> while looking at this commit:
> 
> commit b27a6d5e636ac80b223a18ca2b3c892f1caef9e3
> Author: Binoy Jayan <binoy.jayan@linaro.org>
> Date:   Wed Jun 15 11:00:34 2016 +0530
> 
>     staging: wilc1000: Replace semaphore txq_event with completion
> 
>     The semaphore 'txq_event' is used as completion, so convert it
>     to a struct completion type.
> 
>     Signed-off-by: Binoy Jayan <binoy.jayan@linaro.org>
>     Reviewed-by: Arnd Bergmann <arnd@arndb.de>
>     Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> diff --git a/drivers/staging/wilc1000/linux_wlan.c
> b/drivers/staging/wilc1000/linux_wlan.c
> index 274c390d17cd..baf932681362 100644
> --- a/drivers/staging/wilc1000/linux_wlan.c
> +++ b/drivers/staging/wilc1000/linux_wlan.c
> @@ -316,7 +316,7 @@ static int linux_wlan_txq_task(void *vp)
> 
>         complete(&wl->txq_thread_started);
>         while (1) {
> -               down(&wl->txq_event);
> +               wait_for_completion(&wl->txq_event);
> 
>                 if (wl->close) {
>                         complete(&wl->txq_thread_started);
> @@ -650,7 +650,7 @@ void wilc1000_wlan_deinit(struct net_device *dev)
>                         mutex_unlock(&wl->hif_cs);
>                 }
>                 if (&wl->txq_event)
> -                       up(&wl->txq_event);
> +                       wait_for_completion(&wl->txq_event);
> 
> 
> I wonder: is this correct? Should that be complete() instead?
> 

Yes, I agree, sorry for missing that in my review.

	Arnd