From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753932AbbCJQRo (ORCPT ); Tue, 10 Mar 2015 12:17:44 -0400 Received: from mailrelay3.lanline.com ([216.187.10.24]:55726 "EHLO mailrelay3.lanline.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752934AbbCJQRl (ORCPT ); Tue, 10 Mar 2015 12:17:41 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21759.6343.498011.499541@quad.stoffel.home> Date: Tue, 10 Mar 2015 12:16:07 -0400 From: "John Stoffel" To: Andy Lutomirski Cc: Ingo Molnar , Andi Kleen , "H. Peter Anvin" , Al Viro , x86@kernel.org, linux-kernel@vger.kernel.org, Linus Torvalds Subject: Re: [PATCH v2 2/2] x86_64,signal: Remove 'fs' and 'gs' from sigcontext In-Reply-To: <341cbb62a79e91becc87ac7fab78bc22eb87976e.1425995824.git.luto@amacapital.net> References: <341cbb62a79e91becc87ac7fab78bc22eb87976e.1425995824.git.luto@amacapital.net> X-Mailer: VM 8.2.0b under 23.4.1 (x86_64-pc-linux-gnu) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Andy" == Andy Lutomirski writes: Andy> As far as I can tell, these fields have been set to zero on save and Andy> ignored on restore since Linux was imported into git. Rename them Andy> '__pad1' and '__pad2' to avoid confusion and to allow them to be Andy> recycled some day. Andy> I'm intentionally avoiding calling either of them __pad0: the field Andy> formerly known as __pad0 is now ss. Andy> Signed-off-by: Andy Lutomirski Andy> --- Andy> arch/x86/include/asm/sigcontext.h | 4 ++-- Andy> arch/x86/include/uapi/asm/sigcontext.h | 4 ++-- Andy> arch/x86/kernel/signal.c | 4 ++-- Andy> 3 files changed, 6 insertions(+), 6 deletions(-) Andy> diff --git a/arch/x86/include/asm/sigcontext.h b/arch/x86/include/asm/sigcontext.h Andy> index f910cdcb71fd..5f0ef11719e1 100644 Andy> --- a/arch/x86/include/asm/sigcontext.h Andy> +++ b/arch/x86/include/asm/sigcontext.h Andy> @@ -57,8 +57,8 @@ struct sigcontext { Andy> unsigned long ip; Andy> unsigned long flags; Andy> unsigned short cs; Andy> - unsigned short gs; Andy> - unsigned short fs; Andy> + unsigned short __pad2; /* Was called gs, but was always zero. */ Andy> + unsigned short __pad1; /* Was called gs, but was always zero. */ Shouldn't this comment read: /* Was called fs, but was always zero. */ for the second one?