From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD86835F16C for ; Fri, 31 Jul 2026 05:54:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785477256; cv=none; b=GQrArdLjaZt1fg4tk4ijRH9ijpQyVOoxna+EfYg1tshDEntotCm+S0Gf35+cSOdWzCqS5cvnzRks3zi7UeIm0AHpUwL9fEMPAQnELfIaVrRO1IOT47pvhykSzzBVBrTyLCOTih/GyiBkXNRWxHnDf5EjzXHEo5/VGxivBkNL5QU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785477256; c=relaxed/simple; bh=WF0RaYG56zNBKr9KGq4rqoVRsV8jwJaaIY0uB1wt1ok=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Aeft4sOqvw2Gf8GlAgZEhXkv0BE6mg6WdNQ49RJx+DXAtIEpJ28yhYUQM0mlQZSPYvEysietuGeheA3Srdsbg6rBfjlymtkCrTPxSLn5hxU7YIku+kZbZKA1FmWKx+tFCkDH55gvMNZ5J02T4xC4ueIyZR2cMyyTLgER5gQMr0Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dZvbAmSB; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jx3dAfzE; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dZvbAmSB"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jx3dAfzE" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66V5F2BM028544 for ; Fri, 31 Jul 2026 05:54:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= c+6uiNxiXp+6XrR6HlL4LxM9vmUmpkD7QjjW6V1Zz68=; b=dZvbAmSBOFtsqPl2 qD0cAleWoxnxzFFmGfugIJJDISQY5EZlcL4NWkCHmizQuw46GS0znQMyZF8f3ouy jqCPrlkRMir75FWrZzN8xri/JB8ta7F60n4w68mQtdwNYntoOoPox+vHborS6ZbO ALiRsjBSPOwivc6aT/qw2Hsff391A+cK5FDfje2oN+0hcnukhaeTI93XWaoc+8gX XJ9n510RoO/9SLBH1dGg2Q5bcfO1UvzbMGGO63vLEg+q6XDO5Hn6UEOkYXRl5onc ym0czP4wQgeSKtFITgG5totFhHwcvbBzyufpfe9aaAHmUB5qehEAh7b39nQq/7ts W3tvQg== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4frnd5846b-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 31 Jul 2026 05:54:14 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-38e7ff7b375so700333a91.1 for ; Thu, 30 Jul 2026 22:54:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785477253; x=1786082053; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=c+6uiNxiXp+6XrR6HlL4LxM9vmUmpkD7QjjW6V1Zz68=; b=jx3dAfzE8onMHHHKeeZa/4QTap8EXVtJnHHAsjWrcWRIrk16Z/k1+Ok0XTU/cvzkhJ rOw419YJeg2nBUk9GiXOlgCMYu+uL8reF8BD8eNTbJ6tc/YR0VHHDDC2V9lMKyzkPVFl +3hmOi7fzyXXePj01qEHiWi6oWl4SrTmTw/TOR9ppFIizwYVjlV2VpEQOtfZ1MQ3FIyf 54wAYjzY5iQchIT+aQC1rIkFDFj2bv4TGrvcI/F+tUxeOW83T50t7dOAcgFC+iRqecjU gH9r+s0B6/T5nq0ObGEYwTLZ2QbULFVJh0T1NXEUVUMvzebWLVyAPg+hCJTJ8nXAMzI8 sWaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785477253; x=1786082053; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=c+6uiNxiXp+6XrR6HlL4LxM9vmUmpkD7QjjW6V1Zz68=; b=BBet6ie4xGRg8xQYjp5X3yPo2pmxkc8CzdgEY5RKJBv10b6S5RIdvQfCunv/rWfKES /mzxRLejrKYHfnq1ZziDAmVsnxJ1F3/6saSfovWMdUSVjYsKZONP4MRk3ITlr38gFcMg Amd4m5nw8N/hoSTwKvQYrBARAGkdPj6ZjlMm4UoNXtqOD7tmU6kOfLnnItnDsUB/923s jPms4nubTem8YSjuCrE2V+VoY+UiIyNdb5yHCzqFlPdBeqOYsmI2iMG7C8Fgrx+vjLCz BJ9kgTVZXAeX/dlk4wCi/2bd5WvpVzAi150U6QKTS9iYXCLMSFMjZrSoPVU1GY034WcW s2ng== X-Forwarded-Encrypted: i=1; AHgh+RpX+ZuT5ZIRVQgFC18E+kXiH67cDc379RaOpylppR+zk8PNfesAgEfNeqIyboZpQ9yMF3Lb21NLS+HULbU=@vger.kernel.org X-Gm-Message-State: AOJu0YwHjgiE8LGsrUqBYhwG9XGv2vd3z3PKR6MjJpNRSs9pUZxWGfcp b/B243Cq20Hv5MagaqEc/YjDvtGOj2pZmm+MGuHGQbDVUdEveXq7i+RVjjWdavQnEZDj18koadC YLZSzbyCxqXp6Xx6Wk8ZasRrDtAQ/8pzV/k9qiYL3NmzDpI6rJgqUxU2OZaEru6aEKsc= X-Gm-Gg: AR+sD13sJj2q7saRjYDdES5L7I31xw3bDOZTNpVV5yb1TfPh2yDyFMqjrNAlg1gRWLM SwPXCkZ3NghvJjvPl11W6iwR88mF6JgzjI2UIBRugbVIrpSgTb0k2Th2kv4w1f0ZdazloQwtETZ 5gTNr96pCAT2dZnGm9Gc3/szqSZPBEsgVh/5v11vxXd8sWwgccKtb4hM1vQ20azOfJpvnPkqFSG IS3xGKDVs8KREMHDPl9ts2dicawxbrUzh8UH8EC3iBHmIzKdqtA8j7Uh4SOVjTzhei+vmgWtZk9 sakNPs8g4FJXeJoQcXeEKWbc51bt+YpVkZO5kuKKVVGI+VoInY7jidSto/CrcUC6cKTs1xJfoed wSWC2DjPJtbUco0o+Zv9YKvUgIukQsxiuHdltpz7e X-Received: by 2002:a17:90b:4c0e:b0:385:d033:d9f1 with SMTP id 98e67ed59e1d1-38fb1451e8cmr760198a91.28.1785477253559; Thu, 30 Jul 2026 22:54:13 -0700 (PDT) X-Received: by 2002:a17:90b:4c0e:b0:385:d033:d9f1 with SMTP id 98e67ed59e1d1-38fb1451e8cmr760183a91.28.1785477253154; Thu, 30 Jul 2026 22:54:13 -0700 (PDT) Received: from [10.152.199.23] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153dd4e666sm2466110eec.4.2026.07.30.22.54.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jul 2026 22:54:12 -0700 (PDT) Message-ID: <217852fe-5e01-4d10-8767-c44844db714b@oss.qualcomm.com> Date: Fri, 31 Jul 2026 11:24:08 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH ath-next] wifi: ath10k: snoc: use memcpy_fromio() for MSA ramdump To: Linghui Wu , ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org, jjohnson@kernel.org, linux-kernel@vger.kernel.org References: <20260727072629.2297208-1-linghui.wu@oss.qualcomm.com> From: Rameshkumar Sundaram Content-Language: en-US In-Reply-To: <20260727072629.2297208-1-linghui.wu@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 1LYByuBgcPb-NdGm9Q952FhCBXz5D3L5 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzMxMDAzOCBTYWx0ZWRfX2du/gsUXHRSu Qpyw+XOjR3O4qP3uzh7EZe/4ENtap9I48YVH1IVelwaCaG+ZdVVjPP1RxHmM85xzGZWA5LFE/xj BGOMBhLTowMGDBDUmKZkchRODUlmhZzKV8oxgLO+qLvSJV2xw5WxJE0ZFuomKSGR0sTHfFyUsW2 gVspSAqQfl0qrFgp6zT4y1Mt7lOnIGjKHAEYA/o2Ei1ZCyarpHGCCovnq64i59Y1A43yclmFzpj zRpOj7p8QBwBYLd1YaCAHlsgXFQJZXe5+Cmtfr8SouLUFTrV3bwxEak9EN2ukP/hvx3/W1NDs8L k1wkv3BLt2HxrYQoxb2MvELJ4xhahLipJJTIlPbIfRK/lGCgVCYfI3bf0L/yVZfwxR7ZMFV1V5s Sgr2d8GExe4kj4RhJWQZmFUMzeXZ6SyldTTkBuykEkYvJ9I3EHHOywFhE3g11KMHEErTN/qIHSc La2QOL53tv+6PvY+QrQ== X-Proofpoint-GUID: 1LYByuBgcPb-NdGm9Q952FhCBXz5D3L5 X-Authority-Analysis: v=2.4 cv=MLBQXsZl c=1 sm=1 tr=0 ts=6a6c3886 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=EMxFUL3Ltl7gSd1fbyIA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzMxMDAzOCBTYWx0ZWRfXys47rnaJbwTr EKSihkZgQNjVre+Zq2Cd/OaUw23M7mn3ubHtnQEqSCb+bLy4EOCO2mVedSZdmEHXb1tmZzKo9x3 bqebbFxUD0baumIpYMQBSrb8ZZ7awfM= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-31_02,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 clxscore=1015 impostorscore=0 adultscore=0 spamscore=0 bulkscore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607310038 On 7/27/2026 12:56 PM, Linghui Wu wrote: > On WCN3990/SNOC the MSA region is mapped with devm_memremap(MEMREMAP_WT). > On arm64 such a mapping is not Normal-cacheable, so unaligned accesses to > it are not permitted. ath10k_msa_dump_memory() copies the region with a > plain memcpy(), whose optimized __pi_memcpy_generic implementation issues > wide/unaligned loads. This triggers an alignment fault (FSC=0x21) Oops in > ath10k_snoc_fw_crashed_dump() while collecting the devcoredump: > > Unable to handle kernel paging request ... FSC=0x21: alignment fault > pc : __pi_memcpy_generic > lr : ath10k_snoc_fw_crashed_dump [ath10k_snoc] > > The Oops both leaves the firmware RAM dump buffer zeroed (no dump is > captured) and crashes the kernel, which in turn breaks modem SSR > recovery. > > Use memcpy_fromio(), which only performs accesses that are valid for such > a device-memory mapping. The generic memcpy_fromio() implementation aligns > the source before issuing word-sized reads and stores the destination with > put_unaligned(), so it is also safe for the coherent DMA allocation used on > the non-reserved-memory path. ath11k and ath12k use the same pattern > when copying target memory into crash dumps, so call it unconditionally > here too. > The MEMREMAP_WT pointer is a plain void *, so an explicit __iomem cast is > needed; use __force to keep sparse happy. > > Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.3.7.c5-00107-QCAHLSWMTPL-1 > > Fixes: 3f14b73c3843 ("ath10k: Enable MSA region dump support for WCN3990") > Signed-off-by: Linghui Wu Reviewed-by: Rameshkumar Sundaram