From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752901AbaIAX3Y (ORCPT ); Mon, 1 Sep 2014 19:29:24 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:52628 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752250AbaIAX3X (ORCPT ); Mon, 1 Sep 2014 19:29:23 -0400 From: "Rafael J. Wysocki" To: Jacob Pan Cc: Rafael Wysocki , Linux PM , Srinivas Pandruvada , LKML Subject: Re: [PATCH] powercap/rapl: lower warning level for domain detection Date: Tue, 02 Sep 2014 01:48:40 +0200 Message-ID: <2181254.mWuCKKqmQW@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/3.16.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1409288168-6537-1-git-send-email-jacob.jun.pan@linux.intel.com> References: <1409288168-6537-1-git-send-email-jacob.jun.pan@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, August 28, 2014 09:56:08 PM Jacob Pan wrote: > Many CPUs do not support complete set of RAPL domains, as a > result this detection failed message is very misleading and > annoying. So lower the warning message to info and reword. > > Signed-off-by: Jacob Pan What about printing a (info-level) message if the RAPL domain *is* supported? That surely is more interesting? > --- > drivers/powercap/intel_rapl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/powercap/intel_rapl.c b/drivers/powercap/intel_rapl.c > index b1cda6f..0b282e7 100644 > --- a/drivers/powercap/intel_rapl.c > +++ b/drivers/powercap/intel_rapl.c > @@ -1169,7 +1169,7 @@ static int rapl_detect_domains(struct rapl_package *rp, int cpu) > if (!rapl_check_domain(cpu, i)) > rp->domain_map |= 1 << i; > else > - pr_warn("RAPL domain %s detection failed\n", > + pr_info("RAPL domain %s not supported\n", > rapl_domain_names[i]); > } > rp->nr_domains = bitmap_weight(&rp->domain_map, RAPL_DOMAIN_MAX); > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.