From: Dave Hansen <dave.hansen@intel.com>
To: Chao Gao <chao.gao@intel.com>,
tglx@linutronix.de, x86@kernel.org, seanjc@google.com,
pbonzini@redhat.com, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org
Cc: peterz@infradead.org, rick.p.edgecombe@intel.com,
mlevitsk@redhat.com, weijiang.yang@intel.com, john.allen@amd.com
Subject: Re: [PATCH v2 3/6] x86/fpu/xstate: Introduce XFEATURE_MASK_KERNEL_DYNAMIC xfeature set
Date: Tue, 4 Mar 2025 14:37:00 -0800 [thread overview]
Message-ID: <21824e7a-092e-40f8-a0f0-972c92ae3900@intel.com> (raw)
In-Reply-To: <20241126101710.62492-4-chao.gao@intel.com>
Subjects should ideally be written without large identifiers:
Subject: x86/fpu/xstate: Introduce dynamic kernel features
On 11/26/24 02:17, Chao Gao wrote:
> Remove the kernel dynamic feature from fpu_kernel_cfg.default_features
> so that the bits in xstate_bv and xcomp_bv are cleared and xsaves/xrstors
> can be optimized by HW for normal fpstate.
I'm really confused why this changelog hunk is here.
Right now, all kernel XSAVE buffers have the same supervisor xfeatures.
This introduces the idea that they can have different xfeature sets.
The _purpose_ of this is to save space when only some FPUs need a given
feature. This saves space in 'struct fpu'. It probably doesn't actually
make XSAVE/XRSTOR any faster because the init optimization is very
likely to be in place for these features.
I'm not sure what point the changelog was trying to make about xstate_bv
and xcomp_bv. xstate_bv[12] would have been 0 if the feature was in its
init state.
next prev parent reply other threads:[~2025-03-04 22:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-26 10:17 [PATCH v2 0/6] Introduce CET supervisor state support Chao Gao
2024-11-26 10:17 ` [PATCH v2 1/6] x86/fpu/xstate: Always preserve non-user xfeatures/flags in __state_perm Chao Gao
2025-03-04 22:20 ` Dave Hansen
2025-03-05 8:25 ` Chao Gao
2024-11-26 10:17 ` [PATCH v2 2/6] x86/fpu/xstate: Add CET supervisor mode state support Chao Gao
2025-03-04 22:26 ` Dave Hansen
2025-03-05 8:32 ` Chao Gao
2024-11-26 10:17 ` [PATCH v2 3/6] x86/fpu/xstate: Introduce XFEATURE_MASK_KERNEL_DYNAMIC xfeature set Chao Gao
2025-03-04 22:37 ` Dave Hansen [this message]
2025-03-05 8:43 ` Chao Gao
2024-11-26 10:17 ` [PATCH v2 4/6] x86/fpu/xstate: Introduce fpu_guest_cfg for guest FPU configuration Chao Gao
2025-03-04 22:50 ` Dave Hansen
2025-03-05 8:57 ` Chao Gao
2024-11-26 10:17 ` [PATCH v2 5/6] x86/fpu/xstate: Create guest fpstate with guest specific config Chao Gao
2025-03-04 23:02 ` Dave Hansen
2025-03-05 9:04 ` Chao Gao
2024-11-26 10:17 ` [PATCH v2 6/6] x86/fpu/xstate: Warn if CET supervisor state is detected in normal fpstate Chao Gao
2024-11-26 10:28 ` [PATCH v2 0/6] Introduce CET supervisor state support Chao Gao
2025-01-11 1:26 ` Sean Christopherson
2025-02-11 2:09 ` Xin Li
2025-03-04 19:40 ` Xin Li
2025-03-04 19:53 ` Sean Christopherson
2025-02-19 1:44 ` Chao Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21824e7a-092e-40f8-a0f0-972c92ae3900@intel.com \
--to=dave.hansen@intel.com \
--cc=chao.gao@intel.com \
--cc=john.allen@amd.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlevitsk@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=rick.p.edgecombe@intel.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=weijiang.yang@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®