From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755473AbbIYX7b (ORCPT ); Fri, 25 Sep 2015 19:59:31 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:53833 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754137AbbIYX73 (ORCPT ); Fri, 25 Sep 2015 19:59:29 -0400 From: "Rafael J. Wysocki" To: Sudeep Holla Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Al Stone , Lorenzo Pieralisi Subject: Re: [PATCH v2 1/2] ACPI / tables: simplify acpi_parse_entries Date: Sat, 26 Sep 2015 02:27:43 +0200 Message-ID: <2184252.JT4i34L2sb@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.1.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1442408287-10410-1-git-send-email-sudeep.holla@arm.com> References: <1442243686-15845-1-git-send-email-sudeep.holla@arm.com> <1442408287-10410-1-git-send-email-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, September 16, 2015 01:58:06 PM Sudeep Holla wrote: > acpi_parse_entries passes the table end pointer to the sub-table entry > handler. acpi_parse_entries itself could validate the end of an entry > against the table end using the length in the sub-table entry. > > This patch adds the validation of the sub-table entry end using the > length field.This will help to eliminate the need to pass the table end > to the handlers. > > It also moves the check for zero length entry early so that execution of > the handler can be avoided. > > Cc: "Rafael J. Wysocki" > Signed-off-by: Sudeep Holla > > --- > drivers/acpi/tables.c | 31 +++++++++++++++---------------- > 1 file changed, 15 insertions(+), 16 deletions(-) > > Hi Rafael, > > As I mentioned earlier, this needs to be applied after Al's MADT changes > are merged. You might get simple conflicts in acpi_parse_entries. This needs to be rebased on top of some patches in my linux-next branch. It probably is better to rebase it on top of my bleeding-edge branch that contains the Al's patches already, though. Thanks, Rafael