From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 300D2C433E0 for ; Thu, 2 Jul 2020 19:04:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 071E020702 for ; Thu, 2 Jul 2020 19:04:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726163AbgGBTEB (ORCPT ); Thu, 2 Jul 2020 15:04:01 -0400 Received: from mga01.intel.com ([192.55.52.88]:13360 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725878AbgGBTEB (ORCPT ); Thu, 2 Jul 2020 15:04:01 -0400 IronPort-SDR: SuwFQLU1K6qmjJsHFYMv0dNN/XyN575q3Cae1O9+NotPzAbIp8QA0JYlHHRl+nV3zZYL0xjnOF uSAKfHmzQumA== X-IronPort-AV: E=McAfee;i="6000,8403,9670"; a="165054876" X-IronPort-AV: E=Sophos;i="5.75,305,1589266800"; d="scan'208";a="165054876" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2020 12:04:00 -0700 IronPort-SDR: gnOBcBliBICPHYLlTAPB2fAVH+V8bYokR4W/N0dEdoSDStXp83ufUbFjAeqPKRu7wvhjleJ1g5 aUDy828pShMw== X-IronPort-AV: E=Sophos;i="5.75,305,1589266800"; d="scan'208";a="295989116" Received: from dhprice-mobl1.amr.corp.intel.com (HELO [10.254.75.219]) ([10.254.75.219]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2020 12:03:59 -0700 Subject: Re: [PATCH 6/6] ASoC: fsl: fsl_esai: fix kernel-doc To: Nicolin Chen Cc: alsa-devel@alsa-project.org, tiwai@suse.de, broonie@kernel.org, Timur Tabi , Xiubo Li , Fabio Estevam , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , "open list:FREESCALE SOC SOUND DRIVERS" , open list References: <20200702172227.164474-1-pierre-louis.bossart@linux.intel.com> <20200702172227.164474-7-pierre-louis.bossart@linux.intel.com> <20200702185556.GG23935@Asurada-Nvidia> From: Pierre-Louis Bossart Message-ID: <2191ccbf-5c94-62e5-33b0-635284e5a8c6@linux.intel.com> Date: Thu, 2 Jul 2020 14:03:58 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200702185556.GG23935@Asurada-Nvidia> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/2/20 1:55 PM, Nicolin Chen wrote: > On Thu, Jul 02, 2020 at 12:22:27PM -0500, Pierre-Louis Bossart wrote: >> Fix W=1 warnings. Fix kernel-doc syntax and add missing parameters. >> >> Signed-off-by: Pierre-Louis Bossart > >> + * fsl_esai_set_dai_sysclk - This function mainly configures the clock frequency of MCLK (HCKT/HCKR) > > Can drop "This function mainly" > >> /** >> - * This function configures the related dividers according to the bclk rate >> + * fsl_esai_set_bclk - This function configures the related dividers according to the bclk rate > > Here too -- dropping "This function" will fix both, thanks for reviewing the edits. > > Otherwise, > Acked-by: Nicolin Chen > > Thanks! >