From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752129AbbCKKCc (ORCPT ); Wed, 11 Mar 2015 06:02:32 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:63078 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751165AbbCKKC3 (ORCPT ); Wed, 11 Mar 2015 06:02:29 -0400 From: Arnd Bergmann To: Mikko Rapeli Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Geoff Levand , Paul Bolle Subject: Re: [PATCH 33/45] include/uapi/asm-generic/signal.h: include stdlib.h in userspace Date: Wed, 11 Mar 2015 11:02:13 +0100 Message-ID: <2194220.H3M4AuVBTf@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20150310225828.GZ12550@lakka.kapsi.fi> References: <1424127948-22484-1-git-send-email-mikko.rapeli@iki.fi> <2372547.aJh8O9JSDy@wuerfel> <20150310225828.GZ12550@lakka.kapsi.fi> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:Xp0qO9KXMXzDCYCwvMil2+kaYMsGpf2b1keS8sYQXgyouzsrsz7 yWCRW58H2qNMR5/IkjWMy90XmHaCHQkGuEiJB7ZBbekUj/5o1cfLUaTsBq3JK1cHQrXDJ80 wK0Aj0Z+GP0XJdHo12L6B4ZGKyyKsuS0ZaYSwnjLbo6Qw+dZmH6JWKVH8IMQ08hwwZdLOID ZWOCFIijJZyv5MF7X/Yjw== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 11 March 2015 00:58:28 Mikko Rapeli wrote: > linux/kexec.h seems suspicious though: > > #ifndef __KERNEL__ > /* > * This structure is used to hold the arguments that are used when > * loading kernel binaries. > */ > struct kexec_segment { > const void *buf; > size_t bufsz; > const void *mem; > size_t memsz; > }; > > #endif /* __KERNEL__ */ > Hmm, maybe that just needs to be removed as well, after we have removed the function declaration that used to follow it as part of this commit: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=9dc5c05f45ca8101025046cd Using __kernel_size_t would work here as well, but I suspect that the entire structure is useless as it is not used by kernel or user space, and kexec_tools has its own copy of the structure. Arnd