From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753421AbeBVKSw (ORCPT ); Thu, 22 Feb 2018 05:18:52 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:33014 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753189AbeBVKSu (ORCPT ); Thu, 22 Feb 2018 05:18:50 -0500 From: Laurent Pinchart To: Geert Uytterhoeven Cc: Laurent Pinchart , DRI Development , Linux-Renesas , Pantelis Antoniou , Rob Herring , Frank Rowand , Matt Porter , Koen Kooi , Guenter Roeck , Marek Vasut , Wolfram Sang , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , Linux I2C Subject: Re: [PATCH v5 6/8] i2c: demux: Use changeset helpers for clarity Date: Thu, 22 Feb 2018 12:19:32 +0200 Message-ID: <2195898.2J8Qfnu3DQ@avalon> Organization: Ideas on Board Oy In-Reply-To: References: <20180222000531.19448-1-laurent.pinchart+renesas@ideasonboard.com> <20180222000531.19448-7-laurent.pinchart+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, On Thursday, 22 February 2018 11:26:44 EET Geert Uytterhoeven wrote: > On Thu, Feb 22, 2018 at 1:05 AM, Laurent Pinchart wrote: > > From: Pantelis Antoniou > > > > The changeset helpers are easier to use, use them instead of > > using the static property. > > > > Signed-off-by: Pantelis Antoniou > > Acked-by: Wolfram Sang > > ["okay" -> "ok"] > > Why? ePAPR says "okay", "disabled", "fail", or "fail-sss". > > Sorry for missing this in the previous round. That was per Wolfram's request, and because the existing code uses "ok". I'm personally fine with any. -- Regards, Laurent Pinchart