Re: [PATCH v6 1/9] keys/trusted_keys: propagate wrapping key generation errors

[Srish Srinivasan <ssrish@linux.ibm.com>]

Hi Jarkko,
Thanks for taking a look.

On 11/5/26 10:41 PM, Jarkko Sakkinen wrote:
> On Thu, Nov 05, 2026 at 08:13:12PM +0530, Srish Srinivasan wrote:
>> plpks_gen_wrapping_key() returns a negative errno when default wrapping key
>> generation fails. However, trusted_pkwm_init() returns -EINVAL for all such
>> failures, discarding the original error.
>>
>> Propagate the error returned by plpks_gen_wrapping_key() unchanged.
>>
>> Fixes: c99fcb0d735b ("keys/trusted_keys: establish PKWM as a trusted source")
>> Cc: stable@vger.kernel.org # 7.0
>> Signed-off-by: Srish Srinivasan <ssrish@linux.ibm.com>
>> Tested-by: R Nageswara Sastry <rnsastry@linux.ibm.com>
> Nit: I'd put the SOB as last.


Sure, I will make this change.


>
>> ---
>>   security/keys/trusted-keys/trusted_pkwm.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/security/keys/trusted-keys/trusted_pkwm.c b/security/keys/trusted-keys/trusted_pkwm.c
>> index bf42c6679245..422f752598e1 100644
>> --- a/security/keys/trusted-keys/trusted_pkwm.c
>> +++ b/security/keys/trusted-keys/trusted_pkwm.c
>> @@ -170,7 +170,7 @@ static int trusted_pkwm_init(void)
>>   	ret = plpks_gen_wrapping_key();
>>   	if (ret) {
>>   		pr_err("Failed to generate default wrapping key\n");
>> -		return -EINVAL;
>> +		return ret;
>>   	}
>>   
>>   	return register_key_type(&key_type_trusted);
>> -- 
>> 2.52.0
>>
> Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>


Thank you for the Rb.


>
> Br, Jarkko


Thanks,
Srish.