From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEABEC4363C for ; Mon, 10 May 2021 13:02:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A4344611BD for ; Mon, 10 May 2021 13:02:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349987AbhEJMzr (ORCPT ); Mon, 10 May 2021 08:55:47 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:43326 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345186AbhEJMWB (ORCPT ); Mon, 10 May 2021 08:22:01 -0400 Received: from mail-qt1-f199.google.com ([209.85.160.199]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lg4u7-0003Jd-LH for linux-kernel@vger.kernel.org; Mon, 10 May 2021 12:20:55 +0000 Received: by mail-qt1-f199.google.com with SMTP id r20-20020ac85c940000b02901bac34fa2eeso10237766qta.11 for ; Mon, 10 May 2021 05:20:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Y+brPHK6z0qfj8MD7JTAIcwTm+x3W3WlQXIOTpGxTZ8=; b=T7nVvoQ+wlvMDE+m1yJbeOZVeulGRRwIEhJOfpVyMT/IMyT/S/B+YmUagssxXoxIxd c6FwvO5XB2/YxsbPxjgKqXPAT12KOn9XuX1DjsnEKPh36tf13ByCXXgxZSSb2Dc5FAGu p3AX3STTQrWBnVAn8SOo9IXdKhy936JIGr+j6qGKu1rQ4EeqwsecV1FeYze4Wc21CtII Yuo1UxJA+hXADVwY1Ti8TIHtO5+pO+wK4xCyu+WWRv++qaGadDzviGUP61TjTzXgSxnX TmyVqLkteKEnIqXtOhADRT+bHipV98Yz/3htOXwn76iRQDJ1vKsJV8TfLF5HVQe19syi qOxw== X-Gm-Message-State: AOAM532vznLP2cjAtg5RVTscLaYjwUYW7JYxF8h6hzXU0lZhjZnZljVx ddLXXe6P9Z9k1wVjaNQh0NJ0Cz2omXhK4tVrXus6Y3iJ+rG2/RutKNQf1B3pr3Wn7/nOZSJGq2S yLSyMlj90KCHrL2/JasCDzfuTwaeiBExzSWmu7PgnFA== X-Received: by 2002:ac8:7dd2:: with SMTP id c18mr22423553qte.301.1620649254826; Mon, 10 May 2021 05:20:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwMunM+w/xF+r8imk3jOy21ySiyKh1GdRxXlfCXnAc7JoAsdSDDjE6CNw9JyHSGV2p/qnWbyw== X-Received: by 2002:ac8:7dd2:: with SMTP id c18mr22423538qte.301.1620649254655; Mon, 10 May 2021 05:20:54 -0700 (PDT) Received: from [192.168.1.4] ([45.237.49.2]) by smtp.gmail.com with ESMTPSA id v65sm11805007qkc.125.2021.05.10.05.20.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 May 2021 05:20:54 -0700 (PDT) Subject: Re: [PATCH] rtc: max77686: Remove some dead code To: Alexandre Belloni , Edmundo Carmona Antoranz Cc: Christophe JAILLET , cw00.choi@samsung.com, b.zolnierkie@samsung.com, a.zummo@towertech.it, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <9f34ebcd-0c17-cd7f-eb08-52c6c3dc7b03@wanadoo.fr> From: Krzysztof Kozlowski Message-ID: <219efcc7-ca05-a7d1-5943-d34a42f0d49f@canonical.com> Date: Mon, 10 May 2021 08:20:52 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/05/2021 17:06, Alexandre Belloni wrote: > On 08/05/2021 18:06:03-0600, Edmundo Carmona Antoranz wrote: >> On Sat, May 8, 2021 at 10:59 AM Christophe JAILLET >> wrote: >>> >>>> >>>> Following the recent conversations, I think it might make sense to do >>>> dev_err(&pdev->dev, "Failed to register RTC device: %pe\n", info->rtc_dev); >>>> >>>> Is that right? >>>> >>> >>> Yes, it is right, but it should be done in another patch. >>> >>> Would you like to give it a try? >>> >> Sure, I'll have the patch ready to send it when I see yours on next. > > Does it make sense to print anything at all? Who would use the output? > Is anyone actually going to read it? If the RTC core does not print the message, it should be dev_err_probe(). However the first is recently preferred - RTC core should do it for all drivers. I find such error messages useful - helps easily spotting regressions via dmesg -l err. Best regards, Krzysztof