[PATCH 4/5] arcmsr: Support a New RAID Model, ARC-1214

mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed

From: "NickCheng" <nick.cheng@areca.com.tw>
To: <linux-scsi@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <jejb@kernel.org>,
	"???" <ching2048@areca.com.tw>
Subject: [PATCH 4/5]  arcmsr: Support a New RAID Model, ARC-1214
Date: Fri, 8 Feb 2013 14:02:58 +0800	[thread overview]
Message-ID: <21CB1F39001C437A9ED005546E7A603C@arecaaebe11fae> (raw)

[-- Attachment #1: Type: text/plain, Size: 178 bytes --]

From: Nick Cheng <nick.cheng@areca.com.tw>

Add a New RAID Model, ARC-1214, which can support 8 SATA HDs at most, so far.
Signed-off-by: Nick Cheng <nick.cheng@areca.com.tw>
---

[-- Attachment #2: checkpatch4 --]
[-- Type: application/octet-stream, Size: 7508 bytes --]

WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt
+		msleep(10);
WARNING: line over 80 characters
#428: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:496:
+	int retry_count = 6;/* enlarge wait flush adapter cache time: 10 minute */

WARNING: quoted string split across lines
#458: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:531:
+			pr_notice("arcmsr%d: wait 'flush adapter"
+			"cache' timeout, retry count down = %d\n",

WARNING: quoted string split across lines
#531: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:598:
+			pr_notice("arcmsr%d: dma_alloc_coherent"
+			"got error\n", acb->host->host_no);

WARNING: quoted string split across lines
#621: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:671:
+			pr_notice("arcmsr%d: dma_alloc_coherent"
+			"got error\n", acb->host->host_no);

WARNING: Too many leading tabs - consider code refactoring
#707: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:776:
+						if (psdev != NULL) {

WARNING: line over 80 characters
#708: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:777:
+							scsi_remove_device(psdev);

WARNING: Too many leading tabs - consider code refactoring
#810: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:907:
+						if ((temp & 0x01) == 1 &&

WARNING: line over 80 characters
#812: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:909:
+							scsi_add_device(acb->host,

WARNING: Too many leading tabs - consider code refactoring
#814: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:911:
+						} else if ((temp & 0x01) == 0

WARNING: line over 80 characters
#816: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:913:
+							psdev = scsi_device_lookup(acb->host,

WARNING: Too many leading tabs - consider code refactoring
#818: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:915:
+							if (psdev != NULL) {

WARNING: line over 80 characters
#819: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:916:
+								scsi_remove_device(psdev);

WARNING: line over 80 characters
#820: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:917:
+								scsi_device_put(psdev);

WARNING: quoted string split across lines
#978: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:1008:
+			pr_warn("arcmsr%d: MSI-X"
+			"failed to enable\n", acb->host->host_no);

WARNING: quoted string split across lines
#1102: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:1213:
 		pr_notice("arcmsr%d: wait 'abort all outstanding"
+		"command' timeout\n"

WARNING: quoted string split across lines
#1111: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:1229:
 		pr_notice("arcmsr%d: wait 'abort all outstanding"
+		"command' timeout\n"

WARNING: quoted string split across lines
#1120: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:1243:
 		pr_notice("arcmsr%d: wait 'abort all outstanding"
+		"command' timeout\n"

WARNING: quoted string split across lines
#1133: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:1256:
+		pr_notice("arcmsr%d: wait 'abort all outstanding"
+		"command' timeout\n"

WARNING: quoted string split across lines
#1178: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:1424:
 			pr_notice("arcmsr%d: scsi id = %d lun = %d"
+			"isr get command error done, but got unknown"

WARNING: quoted string split across lines
#1216: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:1444:
+		pr_notice("arcmsr%d: isr get an illegal ccb"
+		"command done acb = 0x%p,"

WARNING: line over 80 characters
#1286: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:1570:
+				pmu->done_qbuffer[doneq_index & 0xFF].addressLow;

WARNING: line over 80 characters
#1460: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:1865:
+		pinbound_srb = (struct InBound_SRB *)&pmu->post_qbuffer[postq_index & 0xFF];

WARNING: line over 80 characters
#1469: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:1874:
+			pmu->postq_index = index_stripped ? (index_stripped | 0x4000) : index_stripped;

WARNING: line over 80 characters
#1474: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:1879:
+			pmu->postq_index = index_stripped ? index_stripped : (index_stripped | 0x4000);

WARNING: quoted string split across lines
#1492: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:1894:
+		pr_notice("arcmsr%d: wait 'stop adapter"
+		"background rebulid' timeout\n"

WARNING: quoted string split across lines
#1510: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:1908:
+		pr_notice("arcmsr%d: wait 'stop adapter"
+		"background rebulid' timeout\n"

WARNING: quoted string split across lines
#1526: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:1923:
+		pr_notice("arcmsr%d: wait 'stop adapter"
+		"background rebulid' timeout\n"

WARNING: line over 80 characters
#1606: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2006:
+		writel(ARCMSR_HBCMU_DRV2IOP_DATA_READ_OK, &reg->inbound_doorbell);

WARNING: quoted string split across lines
#2193: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:3039:
 		pr_notice("arcmsr%d: wait 'get adapter firmware"
+		"miscellaneous data' timeout\n",

WARNING: line over 80 characters
#2221: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:3208:
+			writel(ARCMSR_HBCMU_IOP2DRV_MESSAGE_CMD_DONE_DOORBELL_CLEAR,

WARNING: quoted string split across lines
#2229: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:3216:
+		pr_notice("arcmsr%d: wait 'get adapter firmware"
+		"miscellaneous data' timeout\n", pACB->host->host_no);

WARNING: quoted string split across lines
#2247: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:3234:
+	pr_notice("Areca RAID Controller%d: F/W %s &"
+	"Model %s\n",

WARNING: quoted string split across lines
#2364: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:3339:
+		pr_notice("arcmsr%d: wait get adapter firmware"
+		"miscellaneous data timeout\n", acb->host->host_no);

WARNING: labels should not be indented
#2463: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:3620:
+	polling_hbaD_ccb_retry:

WARNING: quoted string split across lines
#2497: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:3654:
+				pr_notice("arcmsr%d: scsi id = %d"
+				"lun = %d ccb = '0x%p' poll command"

WARNING: quoted string split across lines
#2508: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:3665:
+			pr_notice("arcmsr%d: polling an illegal"
+			"ccb command done ccb = '0x%p'"

WARNING: quoted string split across lines
#2642: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:3821:
+			pr_notice("arcmsr%d: 'set command Q"
+			"window' timeout\n", acb->host->host_no);

WARNING: quoted string split across lines
#2744: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:4070:
+		pr_notice("arcmsr%d: wait 'start adapter"
+		"background rebulid' timeout\n", pACB->host->host_no);

WARNING: labels should not be indented
#2831: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:4447:
+			nap:

WARNING: quoted string split across lines
#2835: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:4451:
+				pr_err("arcmsr%d: waiting for"
+				"hw bus reset return, retry=%d\n",

WARNING: quoted string split across lines
#2840: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:4456:
+					pr_err("arcmsr%d:"
+					"waiting for hw bus reset return,"

WARNING: quoted string split across lines
#2863: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:4479:
+			pr_err("arcmsr: scsi bus reset"
+			"eh returns with success\n");

WARNING: quoted string split across lines
#2883: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:4512:
 	pr_notice("arcmsr%d: abort device command of"
+		"scsi id = %d lun = %d\n",

ERROR: Missing Signed-off-by: line(s)

total: 1 errors, 44 warnings, 2798 lines checked

../patch4 has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

next             reply	other threads:[~2013-02-08  6:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-08  6:02 NickCheng [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-02-08  6:04 NickCheng
2013-02-06  8:37 NickCheng
2012-12-04 12:00 NickCheng
2012-11-16 11:56 NickCheng
2012-11-15  7:25 NickCheng
2012-10-12  9:09 NickCheng
2012-10-03 12:39 NickCheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21CB1F39001C437A9ED005546E7A603C@arecaaebe11fae \
    --to=nick.cheng@areca.com.tw \
    --cc=ching2048@areca.com.tw \
    --cc=jejb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®