From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57CB9481649 for ; Mon, 18 May 2026 13:41:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779111662; cv=none; b=jBWHeZtGfKMKc0c60DieZmfXXG1l4nLqQ4DFoOZNqKvki4JJfLq7wDuO6bBXNnuz6hdg3gnTnentvaXMOJFdEuzNrZxEFB7rro5pUm/Z3rApE535GyM12BCLe3vI6ONm+irAJS/qQ6m/6ColzFgHxTugmII/sbsebf8UO1+NXVc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779111662; c=relaxed/simple; bh=57KBMhPoXOLrxYaodFJyU1hyz8hueBgCg9SK1L5VcN4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gd33QiDijflqGI2TCBheLctrQmESGCVEE0hB/bObz8kGHnpE/xO+cDQnPz3JFJv+1YSCvHIexHIiI3fTbHwQZgpG56/fgKWwN3EKz4I5iwj7ZBMiDPiJ5sjdnFMD2ickY5G5copZtzAVd4nfUeS05zU3icyfhtudqtE/k1ipo9s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ipCDmSMZ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FSrDgC1M; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ipCDmSMZ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FSrDgC1M" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64IA8Wc12091041 for ; Mon, 18 May 2026 13:40:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= y/iVpdwss/V65EErDxjTuIpj7D/ub0rITgGHADjbz2s=; b=ipCDmSMZ0QTQsv7p MysuYeWl//kp2UqxZi6cY+Mbe0riuRiadjv66PX3gcmpBG6+L4sSbpCGD58V1gLD 37I/2ZyOh8HNdY8RI+NJI1gVrypvq8NVmpjnMNAlMCL9ntMw8ssKlMRijTfzlaYP kOyrmccQgOKtyX8+XRXLGCWuGmPjsGxrs3ixPB/l+EXt5VmFwlM7wg6qwVq4WL2W n12miacMVR7PtGfh7I6JZC9Tcf3G3RP2hJswpP2hZjeNbW0B4qSN3GUvytXohtvX lncKiEen+oY8ta7DzyF77V8GHS/kZMHlJwXPL/ooVKW24tXF7vTJLU5ZGiqlwhBO qxzNYw== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e80rpgtj9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 18 May 2026 13:40:59 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-50faec938fcso6451571cf.3 for ; Mon, 18 May 2026 06:40:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779111659; x=1779716459; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=y/iVpdwss/V65EErDxjTuIpj7D/ub0rITgGHADjbz2s=; b=FSrDgC1MErVtx5YBlg6wQmdZtNxAMh1ypnUq51AkkKnpXO1heiQOC0NeFcAaACETs7 jSl6HWTbggw4wgGPiJaIFtYIqA0uuA6FKwefHorude738Urwp53KQ1shjlIliW9upKMB xkVC7usK/NVrmS2jp6RgatBw/5f+qSciy8AsZ2tctKsLjnIE81o0wsY2m8jk5sC30dLx YYJpTtbNwtnL5knqoKym3Cf6sZzCwPKQmep8l4Ql6CWfkUOq0rWkKrjTFAaAXpyVXP5C n3un0BQV3+pbC56lYD8or17R/T1bkoT1139ENndgKTTAJsPbXdrpl4XuXhytDVxMEoGY gcKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779111659; x=1779716459; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=y/iVpdwss/V65EErDxjTuIpj7D/ub0rITgGHADjbz2s=; b=g9QFxfrKG3380vnbFdg/HbEWZgwO3OylqexRrqBndAvQcVFSWfWcfOoUp8KqNMK+q4 xxxYwJWnkKQfixlq03LLulxFvw8cZzEjzXvi7+ZAI+fr54GW/VE1dcgTH/d8cM96Rqnt 8hHoAOQPd1h7eN20P5ycu4LdoSSOuA+hms7lbHfv6p8rhANDpWqQuovY19d2Zxjhfmx/ jIuIyLZEHh0bCSyi2qRSm/PTQYql5zGNAy7PSP9fQCrTgfzvWhQMrNNzbIDtLq3v8XlU Yw8neIbGmb7oi4zAF9Kgjv7B5HXzYDbMalHMojoPC0C0tXWuxGRA6k+DYA9r1NnhWjZ3 I3ig== X-Gm-Message-State: AOJu0Ywc31FcwR0xUbz0AGyizx4xZFn8JhHvtk7ui+kT/S7hpavyGoFw 5VApdwsGsqor1jVqnm/bsiVOuzQcmpUJbf+A11TWlAgd1DdQ71/kpej3dn1pMTmUUk7b/FEvlGs 9MnsxoRaekbSgdGBNk2CEUP+9Q9ni/G/7U2AZDkpCjdP4oKFLgdx45JpGTrrTk0lDxiQ= X-Gm-Gg: Acq92OE+tf/UCcYA0Sxh4oee/M082G7vX3G5eL1qV6wpl/vnYt88QcLw9InPV4xSQaZ CwocQjuDQTAFEpQwrpbzTtDlsJMkgVzzEVC/SXAwX0sRETE7vUVX5GriWmCVl1Q7H53zGfDww6k 47aNnskuH4j7MMQZnK9MKT3lBmwmwnkZw33QbVBmDzOAtCDYWUx8OKisqZTyVSGsYuweRzh2hXF M2Gvhm5U/v/2/n2gk2hHr2V91tk0xq3N+2PiZs9NCaLOYKccYyVeNqaMIb5nwaTSoTyqi5wwnar xDNXsO0+R0k8xJBxypppOM+hocF/N1VeTqUudNxWwFTxRykLYosvT2M+d5eJEQXdnth0DR3zabd yO5V/ycuFqcWFh+sh6HOhF8HZWa9oECniScQcrPEZvijXHyPXGFPsMn17mmGHcfGdis00sU46tX 109YI= X-Received: by 2002:a05:622a:111:b0:509:d76:fe73 with SMTP id d75a77b69052e-5165a0dc367mr134986281cf.3.1779111658639; Mon, 18 May 2026 06:40:58 -0700 (PDT) X-Received: by 2002:a05:622a:111:b0:509:d76:fe73 with SMTP id d75a77b69052e-5165a0dc367mr134985831cf.3.1779111658077; Mon, 18 May 2026 06:40:58 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-68311660f49sm5146434a12.15.2026.05.18.06.40.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 May 2026 06:40:57 -0700 (PDT) Message-ID: <21a1b097-be34-445c-b113-e9c9c70d7b87@oss.qualcomm.com> Date: Mon, 18 May 2026 15:40:54 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] serial: qcom-geni: trace: Add tracepoint support for Qualcomm GENI serial To: Praveen Talari , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Greg Kroah-Hartman , Jiri Slaby Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, Mukesh Kumar Savaliya , Aniket Randive , chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com References: <20260512-add-tracepoints-for-qcom-geni-serial-v2-0-a5726421b3af@oss.qualcomm.com> <20260512-add-tracepoints-for-qcom-geni-serial-v2-1-a5726421b3af@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260512-add-tracepoints-for-qcom-geni-serial-v2-1-a5726421b3af@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: aDTM4ms12r4D4HWchpfwL8fy1k2IJxHT X-Proofpoint-ORIG-GUID: aDTM4ms12r4D4HWchpfwL8fy1k2IJxHT X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE4MDEzMyBTYWx0ZWRfXxeTDhqIcx7Ja 6sdwvGOCc5db3nLRkKl57RO0k5TrTght01aL7wY/nnOwarx8QA6H9/mXi5OPAicDm2hbrV4rGEs g90fQdvnStTRrZb5lMcDPjPTSSn7DP4E5yIIzOvl8tOcv8rfpeMtgfeSWyt1YKiZEevP/cXz2yA tWV7yZnshP+VJ1Em8mVxkmJlf/U2OiAF0/FhsU1kb7GvvH83ELoWNwJ/OU1b+zbAcjYCUJO4RrE UinYNclfhhWXeyNES2LBhr9By5vjy69VtEy11d3qIoCilB2C0aVrkfKN0BH12rUcUJ+rfkOBtJa xCP98qLvnHL+wcerBSGahb2P00tCA5ro8Ym6/kaHVv2nRWQiQNKaBT1ZR6oFs9v+MIFZj+tgjo+ X99aGGuScJ0MikYps+UPE49fKRCSQnipWZKDGXmCDVhnEbBdbOAHOuiXVcvaq5IcOPUFx8f1KDT zi41odQDhuw1qiJNR6w== X-Authority-Analysis: v=2.4 cv=ecMNubEH c=1 sm=1 tr=0 ts=6a0b16eb cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=FDeQY5eERw5HgavBjtEA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-18_03,2026-05-15_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 adultscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605180133 On 5/12/26 7:14 PM, Praveen Talari wrote: > Add tracepoint support to the Qualcomm GENI serial driver to provide > runtime visibility into driver behavior without requiring invasive debug > patches. > > The trace events cover UART termios configuration, clock setup, modem > control state, interrupt status, and TX/RX data, making it easier to > diagnose communication issues in the field. > > Signed-off-by: Praveen Talari > --- [...] > +DEFINE_EVENT(geni_serial_data, geni_serial_tx_data, > + > + TP_PROTO(struct device *dev, const u8 *buf, unsigned int len), > + > + TP_ARGS(dev, buf, len) > + > +); > + > +DEFINE_EVENT(geni_serial_data, geni_serial_rx_data, > + > + TP_PROTO(struct device *dev, const u8 *buf, unsigned int len), > + > + TP_ARGS(dev, buf, len) > + > +); stray \ns above otherwise lgtm Reviewed-by: Konrad Dybcio Konrad