From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9FE931A549 for ; Fri, 7 Nov 2025 10:49:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762512600; cv=none; b=RXUjEbmZwGEDWlIEzcpjteeDgzKs44oHgvKVVbmS5wtjLd1rTGQuZC4DQLOaxdHkjlZtbZ5Cb7HXxATUAg27tZ1E8cBlPwGumBvMYuCzkp6ts4mwpbBI7k312cg4BOvRyjhCpV3xfgd9/e1ey6YXIxlJVHcbLPOB3Pb5ZGVdMGM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762512600; c=relaxed/simple; bh=k6CWVoo79rJIhFxcP1Zi6lbWRJyVheMfi9XXd+LkGTU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZvnEGE2XnL9d/inR1bIq528MJSthDNSNWTgTSXlkfUPIt7MDGVR7PnjQCG+1yQW8v82YquIE/2GXqC5j6f6rthrhK3RqauN3R+6n2EXdKrLeAcxKTsmPVEeZZlTYbVpqOjAFE2Etp8Uk6WfuqOKH1AZhJ5BGOmpX5KiBiuWXxjo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=j19zi5vc; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aVpK38KF; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="j19zi5vc"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aVpK38KF" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5A75FrpI568156 for ; Fri, 7 Nov 2025 10:49:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Qy4xZjaDaueCuwPTRvX9IC7D9BFWUmRUOg/PJT9rm94=; b=j19zi5vcZvZc+J3h eil5EXgb7o+MHafKBi9Slf1MAsHwht9ShJKuhVBN4IuNbfkFvOasu8HUs+laic1i ApQFCQDDkr0nR1Z4s/mFsEJRFNaTWW7B62zkTCNyqa8FVCGzmDgnRi4aJaWpx3yo 7YBrhqEKVuWBhNuAaoE60NFeKFuxZH+p+rn0tyDvgwMCTDDPUaOdyqcmIN20Yni7 e+FAQn327eA/EMJkdOZ1oKcI5NWQiBeaIRCP9KmnXRYAWj3UM/IlF2kolv1vNI8Y 9Rr7K9olNJaawFxFkksQTdDzKZOepplYR1QpfkBYS3jwKcxtOTKS7ODirqnsgtuo rorS0A== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4a905qjq05-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 07 Nov 2025 10:49:57 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4ed83a05863so2113221cf.2 for ; Fri, 07 Nov 2025 02:49:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1762512597; x=1763117397; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Qy4xZjaDaueCuwPTRvX9IC7D9BFWUmRUOg/PJT9rm94=; b=aVpK38KFUkFW6kHSwtDvmqmr+IpLTyoG+3Gj2IH6kwa7KJ9sRechIttPb6jEiqRkIT shiAQol5uzyZL7OUgnKhrLYoTq3W8g+FmNJbcRgmFmtueqEFfXqKIkbSdm79N+EIESeI aF+3ys97Ay+qY41i5G/AJleovoe3ssLGjj3GCoyw+2fE9EiRwzWu9P6n2/XX4K/FXjED qsJBWCUkM/9u6u8IC4/xzcXdaxlS43MobCRNrBQD58R2Sf8BOZLdDCMqwfNQF/EeLQJB 5EZ9ecmojBYR+VkpotxpmrkAps9jZPwIdB5DOTLaN0M9TgkFTXgSrepDr+q0gJ9yWJMy KY5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762512597; x=1763117397; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Qy4xZjaDaueCuwPTRvX9IC7D9BFWUmRUOg/PJT9rm94=; b=uVPfp3W7ZlGb03JsCkNN1P5+FFWuTNhd1Ap2MneY9Cykj9eX2mOUt+i9fcckAJCU3H MPm7TtPQelOvmhLrxjPxZ9do8DulzkzePHgOVgDm92gS7Z18130TnNqWelhc3sluBpv3 i9FJCaiyX/+TtVsdINgKM1PecF0BC9eNnXFcITl0oqzvPujr55FSN/tXM1TgqdHyhuP9 ybCq7aJ7QKEXxp4I/C5iVsiV94ri5Su1Q6YDYRK3D/dpn+nHngLjQqC7oodrUvuYpN2o wVEjmfPIBz2SX3Vyz428dm4rFzu0snuSAlBXcYlVLIfOy7UDv48cqk91jS9QjqUlVUPx 8kzg== X-Forwarded-Encrypted: i=1; AJvYcCUmWdBO72RdjCvQZNn0BDWX8XukellVkI9j1GMl8sQotqDzrL/lWpah2SWIUK/KoS7LLXWmkVzXvsbA/d8=@vger.kernel.org X-Gm-Message-State: AOJu0YzHO3R2kgagIYAY9SuICvnXbNOG8NG7L4bdBZo/yokO0LZEC1e+ mz8Dm2XqaSGWsK7kMDfpqCktrS8yyWYM9m4YRpV0vsAUWaqLJszUIYGnBUdMGvrl+75rxaEfMQr p85ThyAEzuUV+piKS06YmD1nPXVASJciaVJ4PPUmlYGKwPg/TMdWccZzcMDJ+RLZUId8= X-Gm-Gg: ASbGncvUaMNX6YkiB/WX/3xgCL7cnCdmOmCHQzEQIjrOlUt5jxDcYHBDYJ2YdpVOiyp 8DzDjcFg0dfXR6IK0sh4I55/aH+fJcyrEeCH2yOXITnb0hx06KzNy7Ifv7WVrWv18/1Shn91Sis gBTgmiRXstVcxJitY38rBe25FW6O8Rzp4UF4EfhSCma7+xYLS65l6aEbI/ELwhk0hiub7pNkuAG GQHzvswe1BQLO8D1+RlZa2eMzOooFMhFrmZ1hX519iGXgG2kDUfZc3MhRC9Hx6RdEl0BEo4PLnL DVqEXxRhY0BFm31nytIS0BXNtbGco+UEVKm8kgNXOa/g/ZECNYPkkS+0VP9INpwADRNbK7IMU0o yoLRR+TPLPivVqssv9m82vVuPv63kWy92wrgHsvMuPL+FHf+PQ8zwEJ9b X-Received: by 2002:ac8:5a51:0:b0:4e8:966b:459b with SMTP id d75a77b69052e-4ed949bb0f9mr18063541cf.5.1762512596839; Fri, 07 Nov 2025 02:49:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IFb3Xbou/G0Zzd63eLA+eutWoqm0V75Q2RL/wdtW4sHDSzQGKhPaQSn2W6oLQojU83FQkCi9A== X-Received: by 2002:ac8:5a51:0:b0:4e8:966b:459b with SMTP id d75a77b69052e-4ed949bb0f9mr18062921cf.5.1762512596362; Fri, 07 Nov 2025 02:49:56 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b72bf9bc2fcsm204678566b.50.2025.11.07.02.49.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Nov 2025 02:49:55 -0800 (PST) Message-ID: <21a3d269-76e6-4da9-aa25-bfd1fb6dfb07@oss.qualcomm.com> Date: Fri, 7 Nov 2025 11:49:48 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/8] net: stmmac: qcom-ethqos: use generic device properties To: Bartosz Golaszewski , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Vinod Koul , Giuseppe Cavallaro , Jose Abreu , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Matthew Gerlach , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Keguang Zhang , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jan Petrous , s32@nxp.com, Romain Gantois , Lad Prabhakar , Heiko Stuebner , Chen Wang , Inochi Amaoto , Emil Renner Berthing , Minda Chen , Drew Fustini , Guo Ren , Fu Wei , Nobuhiro Iwamatsu , Geert Uytterhoeven , Magnus Damm , Maxime Ripard , Shuang Liang , Zhi Li , Shangjuan Wei , "G. Jaya Kumaran" , Clark Wang , Linux Team , Frank Li , David Wu , Samin Guo , Christophe Roullier , Swathi K S Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Drew Fustini , linux-sunxi@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, sophgo@lists.linux.dev, linux-riscv@lists.infradead.org, Bartosz Golaszewski References: <20251107-qcom-sa8255p-emac-v5-0-01d3e3aaf388@linaro.org> <20251107-qcom-sa8255p-emac-v5-2-01d3e3aaf388@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251107-qcom-sa8255p-emac-v5-2-01d3e3aaf388@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: F8QDtiug3yC2tbKg9nBwd2PxV4ypgogJ X-Proofpoint-GUID: F8QDtiug3yC2tbKg9nBwd2PxV4ypgogJ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTA3MDA4NyBTYWx0ZWRfX82OkfIViFfMM oHlX/1oj6vkP9G34PC5959LYzxbGnG9QtaqbamVbwaUz2gyOcQau4rwSOAWQ4U1XT/5iFxnl7TF Ou2E/2YCnqLzs4KdfXI64pdVDNqn2f980RzKG88MxVn6Smk4P7C898cMkCXFqDtGdKRWVlE4B0h lYD4qBbgLKHl8V0MX/Y5+XP5hEHNvKcZBPVQA071dkv74PHvIQYHNfXTBjKsYMl93GnossBm1IC YRFKtsLADmDHWbuJRY5g4D+sJZFsu9wSUVLoYQoSDPOtSxLfozODiuQBaTz50HQ/KrnNyCjAWhN dnPUtkUYwpu86+E8wEDxLzUOC97g15p/Zrmw2i+ZELIGOGyJzIYXZpIqYW8i1fIjnYspgEnt0JW A7DIEnfWW7dEYTNOZ/TKmA3mMRYTDQ== X-Authority-Analysis: v=2.4 cv=D6lK6/Rj c=1 sm=1 tr=0 ts=690dced5 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=xTS94RJRWet4TjKJq7QA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-07_02,2025-11-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 suspectscore=0 spamscore=0 bulkscore=0 phishscore=0 lowpriorityscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511070087 On 11/7/25 11:29 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > In order to drop the dependency on CONFIG_OF, convert all device property > getters from OF-specific to generic device properties and stop pulling > in any linux/of.h symbols. > > Signed-off-by: Bartosz Golaszewski > --- [...] > - if (of_property_read_bool(np, "snps,tso")) > + if (device_property_present(dev, "snps,tso")) This is a change in behavior - "snps,tso = <0>" would have previously returned false, it now returns true although it seems like it's the plat driver clunkily working around not including the common compatible and inlining parts of the common probe functions.. Konrad