From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E52F5C4332F for ; Mon, 6 Nov 2023 16:13:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232513AbjKFQNU (ORCPT ); Mon, 6 Nov 2023 11:13:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232694AbjKFQNR (ORCPT ); Mon, 6 Nov 2023 11:13:17 -0500 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F423D57; Mon, 6 Nov 2023 08:13:14 -0800 (PST) Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-6b77ab73c6fso3660024b3a.1; Mon, 06 Nov 2023 08:13:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699287193; x=1699891993; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:cc:references:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=HwloH4lIsaKOBcUH+ktpM/tPuqiiEi1+sP4h2yghMLE=; b=OVy9MOCkf1m0/wt1Gigzkd/h/81LP0BMl7RIm0spTSwMqVngmfJCZyAoiSzTlUrf3J MOxjz7GVMkdH41Te0Bg8gbCI3EBg7OsU7s0V+8xx148dDdXLQ8MHkRAJN5r8bdkxePd3 oARfp2h3OtVTUXuG37dyYNh4AeM/m/bY3Vk10JmH0UUHLLOvuWqz+YL7PVPVom9xiOfF ycVdaLqcm24w6EBKG1/S6lZxVgcB4vp0sLdogfp3Trkf8fKX6qXrGxBGxyLghgjgeykq C5bXNTmYbGqNdHjJP/sEmAiVP1VjKaVV62846mp34KlUE3Cky9TWPtKBj60xPslj1JeP QcOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699287193; x=1699891993; h=content-transfer-encoding:in-reply-to:from:cc:references:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=HwloH4lIsaKOBcUH+ktpM/tPuqiiEi1+sP4h2yghMLE=; b=lFeJ4q5yk8JUK0QgQbMwWYsyDbrhpCPu0AO3wfu+XSWKPMuJjmMf6PHGFo6pzIxIZS 7rSUCV+8jRWTqd3SeLs2Yb9sT26VX/G3aEuGUdcLCID/wp+uBHMPbkw6ZlGsmbtC21Lx p+FHKyY6FcHZU1EiZ+nkMp0R+ysjnRl+fzPbbk4EvTPW1tcyU8DzEtQeTcGxCHsfLRZB pb//shjtC+6p1jKnbVpD8fkVb/gNod7h/UYNUD5O2Iqs9MiYDZetRCXzcMVVXwTicyUk JJ+3YJ+nZn9moDB+Oo6eHNdztz/MJds6mqLqOstiOmpD7QK5L0smiymwcagu1MW1URVZ dlpw== X-Gm-Message-State: AOJu0Yy318ahXP/KVtc8FYrAw3Mb5siVS9oE1UsmKog2BCcj0wMe+zxX qPNlPnaLe33/6yVfSXasN7I= X-Google-Smtp-Source: AGHT+IEKAggblLoWq1aCM5CRiM0ajmV9IssT41pHY1U7hoDv/Yag3Hu7evt62z9utMKTaqCR1DKNrw== X-Received: by 2002:a05:6a20:244f:b0:15e:4084:6480 with SMTP id t15-20020a056a20244f00b0015e40846480mr14969189pzc.27.1699287193441; Mon, 06 Nov 2023 08:13:13 -0800 (PST) Received: from [192.168.0.100] ([183.247.1.75]) by smtp.gmail.com with ESMTPSA id a10-20020a634d0a000000b005b8ea15c338sm5611879pgb.62.2023.11.06.08.13.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Nov 2023 08:13:13 -0800 (PST) Message-ID: <21a93447-6830-4884-b488-cbac38df1b96@gmail.com> Date: Tue, 7 Nov 2023 00:13:06 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] bpf: Use E2BIG instead of ENOENT To: Alexei Starovoitov References: <20231104024444.385484-1-chen.dylane@gmail.com> Cc: Song Liu , Jiri Olsa , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Yonghong Song , Martin KaFai Lau , John Fastabend , Hao Luo , bpf , LKML From: Tao Chen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Alexei, the delete element api of stackmap return E2BIG when the key size beyond the buckets size, so i try to keep the same approach. Maybe it's not necessary, anyway, thanks for your reply. 在 2023/11/6 下午11:59, Tao Chen 写道: > > > ---------- Forwarded message --------- > 发件人: *Alexei Starovoitov* > > Date: 2023年11月5日周日 04:54 > Subject: Re: [PATCH] bpf: Use E2BIG instead of ENOENT > To: Tao Chen > > Cc: Song Liu >, Jiri Olsa > >, Alexei Starovoitov > >, Daniel Borkmann > >, Andrii Nakryiko > >, Yonghong Song > >, Martin KaFai > Lau >, John Fastabend > >, Hao Luo > >, bpf >, LKML > > > > On Fri, Nov 3, 2023 at 7:44 PM Tao Chen > wrote: > > > > Use E2BIG instead of ENOENT when the key size beyond the buckets size, > > it seems more meaningful. > > seems more meaningful? > Sorry. That's hardly a reason to break someone's code.