From: Yu Kuai <yukuai3@huawei.com>
To: "Michal Koutný" <mkoutny@suse.com>
Cc: <tj@kernel.org>, <axboe@kernel.dk>, <ming.lei@redhat.com>,
<cgroups@vger.kernel.org>, <linux-block@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <yi.zhang@huawei.com>
Subject: Re: [PATCH -next v5 3/8] blk-throttle: factor out code to calculate ios/bytes_allowed
Date: Thu, 23 Jun 2022 20:03:52 +0800 [thread overview]
Message-ID: <21aabcb3-9801-f159-103c-9e1c35983237@huawei.com> (raw)
In-Reply-To: <20220622172706.GA28777@blackbody.suse.cz>
Hi,
在 2022/06/23 1:27, Michal Koutný 写道:
> On Sat, May 28, 2022 at 02:43:25PM +0800, Yu Kuai <yukuai3@huawei.com> wrote:
>> +static u64 calculate_bytes_allowed(u64 bps_limit,
>> + unsigned long jiffy_elapsed_rnd)
>
> Just noticed with all series applied this argument needn't be called
> _rnd. (It's a nit.)
>
Yes, you're right. I'll change that in next version.
Thanks,
Kuai
next prev parent reply other threads:[~2022-06-23 12:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-28 6:43 [PATCH -next v5 0/8] bugfix and cleanup for blk-throttle Yu Kuai
2022-05-28 6:43 ` [PATCH -next v5 1/8] blk-throttle: fix that io throttle can only work for single bio Yu Kuai
2022-05-28 6:43 ` [PATCH -next v5 2/8] blk-throttle: prevent overflow while calculating wait time Yu Kuai
2022-05-28 6:43 ` [PATCH -next v5 3/8] blk-throttle: factor out code to calculate ios/bytes_allowed Yu Kuai
2022-06-22 17:27 ` Michal Koutný
2022-06-23 12:03 ` Yu Kuai [this message]
2022-05-28 6:43 ` [PATCH -next v5 4/8] blk-throttle: fix io hung due to config updates Yu Kuai
2022-06-22 17:26 ` Michal Koutný
2022-06-23 12:27 ` Yu Kuai
2022-06-23 16:26 ` Michal Koutný
2022-06-25 8:36 ` Yu Kuai
2022-06-25 16:41 ` Jens Axboe
2022-06-26 2:39 ` Yu Kuai
2022-07-05 11:42 ` Yu Kuai
2022-05-28 6:43 ` [PATCH -next v5 5/8] blk-throttle: use 'READ/WRITE' instead of '0/1' Yu Kuai
2022-05-28 6:43 ` [PATCH -next v5 6/8] blk-throttle: calling throtl_dequeue/enqueue_tg in pairs Yu Kuai
2022-05-28 6:43 ` [PATCH -next v5 7/8] blk-throttle: cleanup tg_update_disptime() Yu Kuai
2022-05-28 6:43 ` [PATCH -next v5 8/8] blk-throttle: clean up flag 'THROTL_TG_PENDING' Yu Kuai
2022-06-02 11:14 ` [PATCH -next v5 0/8] bugfix and cleanup for blk-throttle Yu Kuai
2022-06-09 0:59 ` Yu Kuai
2022-06-17 1:15 ` Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21aabcb3-9801-f159-103c-9e1c35983237@huawei.com \
--to=yukuai3@huawei.com \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=mkoutny@suse.com \
--cc=tj@kernel.org \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®