From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Li Hua <hucool.lihua@huawei.com>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>
Cc: "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"weiyongjun1@huawei.com" <weiyongjun1@huawei.com>,
"yusongping@huawei.com" <yusongping@huawei.com>
Subject: Re: [PATCH] coredump: Fix build error for ‘dump_emit_page’ defined but not used
Date: Tue, 15 Nov 2022 19:35:03 +0000 [thread overview]
Message-ID: <21af6b11-d6e8-6f37-7d3d-b548dc7f5330@nvidia.com> (raw)
In-Reply-To: <20221115040400.53712-1-hucool.lihua@huawei.com>
On 11/14/22 20:04, Li Hua wrote:
> If CONFIG_ELF_CORE is not set:
> fs/coredump.c:834:12: error: ‘dump_emit_page’ defined but not used [-Werror=unused-function]
> static int dump_emit_page(struct coredump_params *cprm, struct page *page)
> ^~~~~~~~~~~~~~
>
> Fix this by adding the missing CONFIG_ELF_CORE for dump_emit_page.
>
> Fixes: 06bbaa6dc53c ("[coredump] don't use __kernel_write() on kmap_local_page()")
> Signed-off-by: Li Hua <hucool.lihua@huawei.com>
> ---
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
prev parent reply other threads:[~2022-11-15 19:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 4:04 Li Hua
2022-11-15 19:35 ` Chaitanya Kulkarni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21af6b11-d6e8-6f37-7d3d-b548dc7f5330@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=hucool.lihua@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=weiyongjun1@huawei.com \
--cc=yusongping@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®