From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755269AbaCKPvQ (ORCPT ); Tue, 11 Mar 2014 11:51:16 -0400 Received: from am1ehsobe005.messaging.microsoft.com ([213.199.154.208]:13904 "EHLO am1outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753614AbaCKPvL convert rfc822-to-8bit (ORCPT ); Tue, 11 Mar 2014 11:51:11 -0400 X-Forefront-Antispam-Report: CIP:149.199.60.83;KIP:(null);UIP:(null);IPV:NLI;H:xsj-gw1;RD:unknown-60-83.xilinx.com;EFVD:NLI X-SpamScore: -4 X-BigFish: VPS-4(z579ehzbb2dI98dI9371Ic89bh936eI1432Izz1f42h2148h208ch1ee6h1de0h1fdah2149h2073h2146h1202h1e76h2189h1d1ah1d2ah21bch1fc6hzz1de098h8275bh1de097hz2fh95h839h93fhc61hd24hf0ah119dh1288h12a5h12a9h12bdh137ah13b6h1441h14ddh1504h1537h153bh162dh1631h1758h18e1h1946h19b5h1b0ah224fh1d0ch1d2eh1d3fh1dfeh1dffh1e1dh1fe8h1ff5h209eh2216h2336h2438h2461h2487h24ach24d7h2516h2545h255eh25f6h2605h906i1155h) Date: Tue, 11 Mar 2014 08:50:57 -0700 From: =?utf-8?B?U8O2cmVu?= Brinkmann To: Michal Simek CC: Mark Rutland , Punnaiah Choudary Kalluri , "dougthompson@xmission.com" , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-edac@vger.kernel.org" , "michal.simek@xilinx.com" , "robh+dt@kernel.org" , Pawel Moll , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" , "rob@landley.net" , "kpc528@gmail.com" , "kalluripunnaiahchoudary@gmail.com" , "punnaia@xilinx.com" Subject: Re: [RFC PATCH] edac: zynq: Added EDAC support for zynq ddr ecc controller References: <4adb2b4b-2ad6-42b9-929e-cc062f817245@TX2EHSMHS021.ehs.local> <20140310105655.GH14999@e106331-lin.cambridge.arm.com> <531DA900.5060202@monstr.eu> <531ECA33.8050803@monstr.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <531ECA33.8050803@monstr.eu> User-Agent: Mutt/1.5.21 (2010-09-15) X-RCIS-Action: ALLOW Message-ID: <21bfd874-8084-4d23-b973-42a0e50157bc@AM1EHSMHS009.ehs.local> Content-Transfer-Encoding: 8BIT X-OriginatorOrg: xilinx.com X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn% Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2014-03-11 at 09:32AM +0100, Michal Simek wrote: > On 03/10/2014 11:32 PM, Sören Brinkmann wrote: > > On Mon, 2014-03-10 at 12:58PM +0100, Michal Simek wrote: > >> On 03/10/2014 11:56 AM, Mark Rutland wrote: > >>> On Sun, Mar 09, 2014 at 02:57:16AM +0000, Punnaiah Choudary Kalluri wrote: > >>>> Added EDAC support for reporting the ecc errors of zynq ddr controller. > >>>> The ddr ecc controller corrects single bit errors and detects double bit > >>>> errors > >>>> > >>>> Signed-off-by: Punnaiah Choudary Kalluri > >>>> --- > >>>> .../devicetree/bindings/edac/zynq_edac.txt | 18 + > >>>> drivers/edac/Kconfig | 7 + > >>>> drivers/edac/Makefile | 1 + > >>>> drivers/edac/zynq_edac.c | 613 ++++++++++++++++++++ > >>>> 4 files changed, 639 insertions(+), 0 deletions(-) > >>>> create mode 100644 Documentation/devicetree/bindings/edac/zynq_edac.txt > >>>> create mode 100644 drivers/edac/zynq_edac.c > >>>> > >>>> diff --git a/Documentation/devicetree/bindings/edac/zynq_edac.txt b/Documentation/devicetree/bindings/edac/zynq_edac.txt > >>>> new file mode 100644 > >>>> index 0000000..c21ff83 > >>>> --- /dev/null > >>>> +++ b/Documentation/devicetree/bindings/edac/zynq_edac.txt > >>>> @@ -0,0 +1,18 @@ > >>>> +Zynq EDAC driver, it does reports the DDR ECC single bit errors that are > >>>> +corrected and double bit ecc errors that are detected by the DDR ECC controller. > >>>> +ECC support for DDR is available in half-bus width(16 bit) configuration only. > >>>> + > >>>> +Required properties: > >>>> +- compatible: Should be "xlnx,ps7-ddrc" or "xlnx,ps7-ddrc-1.00.a" > >>> > >>> Is this an or or a xor? > >> > >> Compatible string should be just xlnx,zynq-ddrc-1.00.a. > >> Nothing with ps7. > > > > Isn't this vendor IP? IMHO, this should be something completely > > different. Or if you want some Zynq-specific compat string it should > > refer to an actual version string associated with Zynq. 1.00.a is not, > > AFAIK. > > I have checked with Punnaiah that this is Synopsys DDR memory controller. > Zynq is based on 1.4 version with some customization. > It means I think reasonable solution is > call it drivers/edac/synopsys_edac.c > rename zynq_ in driver to synopsys_ and > use xlnx,zynq-ddrc-1.00.a compatible string because zynq is not using > clean synopsys version. > > I am not getting point why you don't like 1.00.a suffix here. > Because of historical point of view compatible strings should be different > for early silicon, silicon v1, silicon v2, silicon v3, etc > but we haven't used it at all that's why we can use xilinx scheme > which we are using for our soft IPs. Well, but you refer to Zynq which has silicon revisions you can use to refer to a specific Zynq version. That matches data sheets. Zynq-1.00.a is just completely made up and wouldn't be found in any data sheet. Sören