mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gabriele Monaco <gmonaco@redhat.com>
To: Nam Cao <namcao@linutronix.de>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	linux-trace-kernel@vger.kernel.org,
		linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rv: Allow epoll in rtapp-sleep monitor
Date: Wed, 01 Apr 2026 13:47:43 +0200	[thread overview]
Message-ID: <21c06a117b044e77e6191d6ad7e8691ec8b7b53f.camel@redhat.com> (raw)
In-Reply-To: <87v7ec6n1n.fsf@yellow.woof>

On Tue, 2026-03-31 at 17:23 +0200, Nam Cao wrote:
> Gabriele Monaco <gmonaco@redhat.com> writes:
> > On Tue, 2026-03-31 at 12:49 +0200, Nam Cao wrote:
> > > diff --git a/kernel/trace/rv/monitors/sleep/sleep.c
> > > b/kernel/trace/rv/monitors/sleep/sleep.c
> > > index c1347da69e9d..59091863c17c 100644
> > > --- a/kernel/trace/rv/monitors/sleep/sleep.c
> > > +++ b/kernel/trace/rv/monitors/sleep/sleep.c
> > > @@ -162,6 +164,11 @@ static void handle_sys_enter(void *data, struct
> > > pt_regs
> > > *regs, long id)
> > >  			break;
> > >  		}
> > >  		break;
> > > +#ifdef __NR_epoll_wait
> > > +	case __NR_epoll_wait:
> > > +		ltl_atom_set(mon, LTL_EPOLL_WAIT, true);
> > > +		break;
> > > +#endif
> > 
> > Sashiko (the AI bot) wonders why this isn't ltl_atom_update() like other
> > things
> > around here. Is that intentional?
> 
> No that's not intentional. It does not affect verification result, but
> still should be fixed. I will send v2.
> 
> Funnily a colleague just told me earlier today about how good AIs are at
> reviewing..

Well, they're probably already better than (most of) us in those kind of
consistency assessments..

Anyway, I tried your changes and it seems to work as I'd expect. Feel free to
send a V2 and I can include it in the pull request.

Thanks,
Gabriele


      reply	other threads:[~2026-04-01 11:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-31 10:49 Nam Cao
2026-03-31 12:50 ` Gabriele Monaco
2026-03-31 13:41   ` Nam Cao
2026-03-31 13:47     ` Gabriele Monaco
2026-03-31 15:15 ` Gabriele Monaco
2026-03-31 15:23   ` Nam Cao
2026-04-01 11:47     ` Gabriele Monaco [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21c06a117b044e77e6191d6ad7e8691ec8b7b53f.camel@redhat.com \
    --to=gmonaco@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=namcao@linutronix.de \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®