From: Lu Baolu <baolu.lu@linux.intel.com>
To: James Dong <xmdong@google.com>
Cc: baolu.lu@linux.intel.com, David Woodhouse <dwmw2@infradead.org>,
Joerg Roedel <joro@8bytes.org>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
Jis Ben <jisben@google.com>
Subject: Re: [PATCH] iommu/vt-d: Handle hotplug devices' default identity mapping setting
Date: Fri, 22 Feb 2019 15:42:02 +0800 [thread overview]
Message-ID: <21c17b44-af9b-2f18-f109-ba4bb0635e61@linux.intel.com> (raw)
In-Reply-To: <CADcZez2q7aUL=ahHSGnfO2QDjKL052AePd=TsxkCK-O7EcW77Q@mail.gmail.com>
Hi James,
On 2/22/19 2:38 PM, James Dong wrote:
>
> Tried this patch, and the same DMAR fault message came out.
>
> Guess it is because of the iommu code path for hotplug devices. If a hotplug
> device is rescanned after removal, iommu_bus_notifier will be called as part
> of the notifier chains to handle BUS_NOTIFY_ADD_DEVICE event. Along the code
> path, intel_iommu_ops->add_device() created an iommu group for this hotplug
> device, but failed to create an iommu domain because of the default domain
> type IOMMU_DOMAIN_IDENTITY imposed by current IOMMU command line option got
> declined by intel_iommu_ops->domain_alloc().
>
> In your patch, function find_or_alloc_domain() is not even in the code path
> of BUS_NOTIFY_ADD_DEVICE event notifier chain.
>
> Please let us know if your have more concerns and suggestions.
Can I reproduce this with a local machine? If so, how should I do?
>
> Best Regards,
> James
Best regards,
Lu Baolu
next prev parent reply other threads:[~2019-02-22 7:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 2:44 James Dong
2019-02-22 5:06 ` Lu Baolu
2019-02-22 5:30 ` Lu Baolu
2019-02-22 7:36 ` James Dong
2019-02-24 8:51 ` Lu Baolu
2019-02-24 16:10 ` James Dong
[not found] ` <CADcZez2q7aUL=ahHSGnfO2QDjKL052AePd=TsxkCK-O7EcW77Q@mail.gmail.com>
2019-02-22 7:42 ` Lu Baolu [this message]
2019-02-22 8:28 ` James Dong
2019-02-22 18:10 ` Jis Ben
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21c17b44-af9b-2f18-f109-ba4bb0635e61@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jisben@google.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xmdong@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome