From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D7293ED3D1 for ; Fri, 29 May 2026 15:01:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780066870; cv=none; b=cW+TpvYQoLeZGxF0F2DUDrT1oio8VKLDRLPIRnAS7/ccJaTr1Og6vYqHlDSWgWNH6VbDSXKOD91CR6g032VAiHRn4LfnwVLKEICMwuABD2Oc57EC8JjXAVHwl6Bt4MBNtXBZvAqxVIqkiTICT0dNsLc1EsP6Zpj6NdbsBFaKDdo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780066870; c=relaxed/simple; bh=ekH8jL5GTEUDGVAvOS2ZIaVQwCZnxE8ZwtzE7+yiA7s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Z4Z044POV3XDfxGDeKOcN7XpxhhyhGpoiFaLDYnihSc3OBprdFZ2m8QndzuNYZTKuIW8P99M2OdxsuycKKrRImD7cnkHPo2vMwr1kwImM3cyQQ+mte0Cnt36x3QDLohSeTAuUkkYk2lLj3XhXPjCCiBBpf65BQt/XdcN4/LXs8Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Xvtg33A3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iMXSLN4m; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Xvtg33A3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iMXSLN4m" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64TDKn5O1202006 for ; Fri, 29 May 2026 15:01:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0DBIjTIgaaXjiGvnFuMwPeT2jOYan/1jCVFnVrf0W20=; b=Xvtg33A3ig+6aYFG oL8rJMr/IQKZvLMoyLnn0zZXciu8R5PCNt+FJ4h8h7q+e19LGgNKQfYe289MgRmy DFggJITACwYZqw/KacpmhoJ1jy15LK/X3G/BXim6nF8FddZA/9eJP/N/oINCoVyM oeWxrLL9qpCKke5Od+xGjJDKap2oeqZ4vFCteFxZA8XayB5vCSA9LMVGUL1G+seo 4g3+3faCQM44ek8O7ZxNGGKSEgdz7TQRflOJpbfZD2zSGBd8c63tbps7IlwGQwNk w6V5S4timf1fGU7BMDTIyA5BVwsbIX/Kuv0vREq2sT4fas/QvGdopxIBX/CnBYVF FN1dIA== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ef3te2gp0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 29 May 2026 15:01:08 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-83ef22f8e8bso9490421b3a.0 for ; Fri, 29 May 2026 08:01:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780066868; x=1780671668; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0DBIjTIgaaXjiGvnFuMwPeT2jOYan/1jCVFnVrf0W20=; b=iMXSLN4mzYaO3olUhJ9wk/KQWwPzt4xhlENn3BzCfbcyknZwu+V+tfFBrGMUq8ihqD lEUpoe0zByVojMURq3yTEMpHpuloZenCyycF7HZKJaHraL0v8hw/jHUj0lbSVVw2iYSK 7QKw421j/hT8eg1snaMHmZDL3rmeJzDNH4Ld6e5r9oZcfhmV+/mq2VsFZZT+yZtmBEJw Oh9wJWyzeX5Iu/x0c5OxKPOHhp8s3Xl6+CxKb/5nxZpSK9ohHOUw3yOwH5ujEJ38Du/R YTf3ohbtYh0s73hcg9ufpYYx4WYzPoDd3dHbXRAmv4N0dJaqKPKFVcRTxAlWCAYNNDCk M7kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780066868; x=1780671668; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0DBIjTIgaaXjiGvnFuMwPeT2jOYan/1jCVFnVrf0W20=; b=Gjy2Aof4Ji0vFkHfZfC7r3NWon/1Y7U5gbxINuuXoiS9iBryfdJrxL0zexJnJa2/z5 LbkOqCE9jcoPPnjDQYvKVrxlhTFB6MbaYha11qjvuZFy6/fbWTdj30pW45zCJReUe7Qy /w7gdCOynL7RUeqthK1VKWPu/Qc1UImy6mFGCjfhjfOFGOFHI6j4W7hHeYrMbYLS1Z5o xLmKySDadH3A3rZRxdrJw5gqT7ixI0WmM2B9BVJvEMlhUtPEPwoqGXsPlioyMYTAZK5t UuDo2sxz+stT1XjOR4f71m+OTm45wqyOUnkPsVCidb/EzhNJhTWfjahZjyHY5UGhXVnU UeHQ== X-Forwarded-Encrypted: i=1; AFNElJ/i0s6zFpzfFoSvVmuf+gPL039tnnKqNDp2UC9DuqgdRZnxeMjP3RuRIkxddzlbSIp/u1lLLIJ6MBxZSlw=@vger.kernel.org X-Gm-Message-State: AOJu0YwtQfbuz6XtdnD3CuerbbZ5GMiJ57joDlK2nC8zubkezt2DGqvd Ci78l/j1M8LyQeUtJkoHMPNIQARsY7cJOXPNX/lom7IN1jFImIn/DygIOZdNppQgX2wUEfsbCG5 LXNCALwRvIE6KUJtf5eSCnx0/PM4c65ERXxew6j7CR+eDji86dZ+2lPPUiy8eNZGs5Ec= X-Gm-Gg: Acq92OH64iUeZFP8ZuPDXyL5sXGBsyYiIGcy8TQf7YidtcmoUVzN0RkemNtyWdCpDQC ReOUnMWm6m4aBhz6RAJMVDGu24Ic/FRV2fzLUmCUXS2u3b5eC4Jd9GuO2rt+gSi4GyPfrKrZsN7 YFEv+1nmyIsnkWmO2uNIFP9Zn7el3oYFYm24BzPSlBzl0U8H32ZSvNhNiccLd/kVU6jfs44q2O2 OdOz+zRopK/AE7N6WvbQqXg6KwkSgb/vEEtAKtKTke0j9Y/4ugSa4vAEEO9N6YDPuO6sTecruEe LecgNiUzQ2RHRtp7Hxy0l7de3CT77sVOCnajnPF2faON62BxnmCrezue75/Njrb0harkEHQ0Ub2 +TzwopfOc/ZFXozfkczYvAr/Lt+PnX/H8BgdfkXUp5wxz2Y59WFg9IxtLCFC0KMI= X-Received: by 2002:a05:6a00:440e:b0:82c:daa4:ce29 with SMTP id d2e1a72fcca58-84212c2fd94mr3681667b3a.47.1780066867452; Fri, 29 May 2026 08:01:07 -0700 (PDT) X-Received: by 2002:a05:6a00:440e:b0:82c:daa4:ce29 with SMTP id d2e1a72fcca58-84212c2fd94mr3681595b3a.47.1780066866769; Fri, 29 May 2026 08:01:06 -0700 (PDT) Received: from [10.204.67.150] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84214b6797esm2739983b3a.26.2026.05.29.08.00.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 May 2026 08:01:06 -0700 (PDT) Message-ID: <21c17cac-2a1e-4b19-ab6d-ddca9132d725@oss.qualcomm.com> Date: Fri, 29 May 2026 20:30:57 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/8] media: qcom: camss: add support for QCM2390 camss To: Loic Poulain , Nihal Kumar Gupta Cc: Bryan O'Donoghue , Vladimir Zapolskiy , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robert Foss , Andi Shyti , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Suresh Vankadara , Prashant Shrotriya References: <20260526-shikra-camss-review-v1-0-645d2c8c75a7@qti.qualcomm.com> <20260526-shikra-camss-review-v1-3-645d2c8c75a7@qti.qualcomm.com> Content-Language: en-US From: Vikram Sharma In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: 2OeY1z-f18t9r29WRk030KPfOBdl1uh3 X-Proofpoint-GUID: 2OeY1z-f18t9r29WRk030KPfOBdl1uh3 X-Authority-Analysis: v=2.4 cv=daSwG3Xe c=1 sm=1 tr=0 ts=6a19aa34 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=iLf03rxdIeEfhWbO6WcA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI5MDE0OSBTYWx0ZWRfX+jAq5KLjXc5O qu8/wl9gQHnpqZ26YbOB4pcdETzzwi5CmiPziP0q7cOXY8iq8SFP1kDI7Q+N1AFbIjsODBRR55W u3nK66psZovZM9B9rPmflPgil6cqcx/I5A6Vf5m9YpRswYGK0L7KgqKQ/yUiMUjukATW++0FYDa lFJa0hVzrXNpEW53XdNRTc7EnyqDPdcHarSQaVS5NzSnCOHcKPETRipP3uTgJqZS6A41s7oOsow TIP2t9OqXeQNqYgNFewzyRLebgGlMr8WMrCcYnqlRXG4Jz7XyfBcx+lm77AqW0X7wWIcqqPiCEO SmICvMYr2Jusu/qHDniLci7J6wCQzTgff59QTtgTK3xM8RZOM3zs9riPY+J99ZV51bglvwXIcOT DKT2hWyr9catBXb1q6GYB//0upMOVaxngJU8gqVMCNn5pb7pHHCn4FcDrRNL+TaYoDkib2NrN5r UwSfYrH9rvRB0wvIHsg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-29_04,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 priorityscore=1501 impostorscore=0 suspectscore=0 clxscore=1015 spamscore=0 phishscore=0 lowpriorityscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2605290149 On 5/28/2026 5:55 PM, Loic Poulain wrote: > On Tue, May 26, 2026 at 7:13 PM Nihal Kumar Gupta > wrote: >> From: Prashant Shrotriya >> >> Add CAMSS driver support for Shikra SoC. Add high level >> resource definitions for 2 CSIPHY, 2 CSID and 2 VFE instances along >> with the interconnect bandwidth votes for AHB, HF and SF MNOC paths. >> >> Signed-off-by: Prashant Shrotriya >> Signed-off-by: Nihal Kumar Gupta >> --- >> drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c | 2 ++ >> drivers/media/platform/qcom/camss/camss-vfe.c | 1 + >> drivers/media/platform/qcom/camss/camss.c | 13 +++++++++++++ >> drivers/media/platform/qcom/camss/camss.h | 1 + >> 4 files changed, 17 insertions(+) >> >> diff --git a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c >> index dac8d2ecf79957dc05c5524dc439791ce097c785..62208f5c4f17bd6c9a8fe5613649920e6ee1a1f2 100644 >> --- a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c >> +++ b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c >> @@ -1130,6 +1130,7 @@ static bool csiphy_is_gen2(u32 version) >> >> switch (version) { >> case CAMSS_2290: >> + case CAMSS_2390: >> case CAMSS_6150: >> case CAMSS_6350: >> case CAMSS_7280: >> @@ -1222,6 +1223,7 @@ static int csiphy_init(struct csiphy_device *csiphy) >> regs->lane_array_size = ARRAY_SIZE(lane_regs_sdm845); >> break; >> case CAMSS_2290: >> + case CAMSS_2390: >> case CAMSS_6150: >> regs->lane_regs = &lane_regs_qcm2290[0]; >> regs->lane_array_size = ARRAY_SIZE(lane_regs_qcm2290); >> diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c >> index 319d191589884777bced456867e5a2a4211a2770..b152f8d48e003d8eeb0cf19ad57419b25cdec087 100644 >> --- a/drivers/media/platform/qcom/camss/camss-vfe.c >> +++ b/drivers/media/platform/qcom/camss/camss-vfe.c >> @@ -342,6 +342,7 @@ static u32 vfe_src_pad_code(struct vfe_line *line, u32 sink_code, >> break; >> case CAMSS_660: >> case CAMSS_2290: >> + case CAMSS_2390: >> case CAMSS_6150: >> case CAMSS_6350: >> case CAMSS_7280: >> diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c >> index 2123f6388e3d7eafe669efd6b033e22d8eb5cf79..f67ecff53f15bd213dc7736d4e5fe880007d1ee7 100644 >> --- a/drivers/media/platform/qcom/camss/camss.c >> +++ b/drivers/media/platform/qcom/camss/camss.c >> @@ -5565,6 +5565,18 @@ static const struct camss_resources qcm2290_resources = { >> .vfe_num = ARRAY_SIZE(vfe_res_2290), >> }; >> >> +static const struct camss_resources qcm2390_resources = { >> + .version = CAMSS_2390, >> + .csiphy_res = csiphy_res_2290, >> + .csid_res = csid_res_2290, >> + .vfe_res = vfe_res_2290, >> + .icc_res = icc_res_2290, >> + .icc_path_num = ARRAY_SIZE(icc_res_2290), >> + .csiphy_num = ARRAY_SIZE(csiphy_res_2290), >> + .csid_num = ARRAY_SIZE(csid_res_2290), >> + .vfe_num = ARRAY_SIZE(vfe_res_2290), > So isn't it exactly the same as 2290? wouldn't it be easier to have > the shikra simply fallback to qcm220 (via compatible string)? ACK, We will simply add fallback to 2290 in dts. >> +}; >> + >> static const struct camss_resources qcs8300_resources = { >> .version = CAMSS_8300, >> .pd_name = "top", >> @@ -5752,6 +5764,7 @@ static const struct of_device_id camss_dt_match[] = { >> { .compatible = "qcom,sdm660-camss", .data = &sdm660_resources }, >> { .compatible = "qcom,sdm670-camss", .data = &sdm670_resources }, >> { .compatible = "qcom,sdm845-camss", .data = &sdm845_resources }, >> + { .compatible = "qcom,shikra-camss", .data = &qcm2390_resources }, >> { .compatible = "qcom,sm6150-camss", .data = &sm6150_resources }, >> { .compatible = "qcom,sm6350-camss", .data = &sm6350_resources }, >> { .compatible = "qcom,sm8250-camss", .data = &sm8250_resources }, >> diff --git a/drivers/media/platform/qcom/camss/camss.h b/drivers/media/platform/qcom/camss/camss.h >> index 93d691c8ac63b2a47dbb234856b627d8911a1851..8ba8a38113dfc15849fa333d05b2c3853f3a7714 100644 >> --- a/drivers/media/platform/qcom/camss/camss.h >> +++ b/drivers/media/platform/qcom/camss/camss.h >> @@ -82,6 +82,7 @@ enum pm_domain { >> enum camss_version { >> CAMSS_660, >> CAMSS_2290, >> + CAMSS_2390, >> CAMSS_6150, >> CAMSS_6350, >> CAMSS_7280, >> >> -- >> 2.34.1 >>