From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sipsolutions.net (s3.sipsolutions.net [168.119.38.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C929D325485 for ; Thu, 28 May 2026 08:17:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=168.119.38.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779956281; cv=none; b=iFEP8XOBdQlFpAkZMUwr2kcwzQQPIHDc7zirrrfTn1rn86/3vutEG5Z10p95HvoRTpRgvD6OfrBTBRIuE7y728Py8hOlUwqn2w5Fao2YQRYRCCS44qebudkQeyLicA5ETWF/9APlINZ9wsqUamNARJCW5bxH9zIpJgedBYsyaKc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779956281; c=relaxed/simple; bh=lMis8oI9nzQmxhD2cadrgYjkurIFfQSjVlT5txsPDq0=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=dX2wMtroRtLA5C4lcpbXGnOfpg2+5AF7FtMEEvdSLrpPKBfyOznUref6tuneIbw53V8+tw/ukDmEPyDPrk/8xqBS7PbKM9n5AVBRKZO40QovFuP/RvAfzay/lP1wXR5Ynx1bkQ+WvzK/6LMplMF1oBgM0nYe75EIEdDRPe+BP4E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=permerror header.from=sipsolutions.net; spf=none smtp.mailfrom=sipsolutions.net; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b=niPNi2sW; arc=none smtp.client-ip=168.119.38.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=permerror header.from=sipsolutions.net Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=sipsolutions.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b="niPNi2sW" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=lMis8oI9nzQmxhD2cadrgYjkurIFfQSjVlT5txsPDq0=; t=1779956279; x=1781165879; b=niPNi2sWPIZMpSh3z2usdsAtZEyhrgaoEE04ZjxvbbsWn8W jwHsVykZUGBRpwy0nYhIMwGjbVVaTs9BbKuGxUirczTGPWFEDxHgoqx59MMJZc6nYeEtL1W9GCE9N 8jio+VplS/M4WNHwRnxGOa9qjY0/nl81Ris6iu1O6eIv+vw63ouW+Lsj2kbz8zYNv8KewI2jshz/C xCFBgZyVFwr9nLW5SUMj27OI7K+QtkrP3m2s8Y5EiBghkUUrwayFrbdZeAhYTQUhGBabQUl93+P8R NBNheLxPMfIEEAvJPrH229nc/h4ZfcHH8njjemkfp216m8ewYUHuZRNCPIjM0gyg==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.98.2) (envelope-from ) id 1wSVw7-00000007CQm-3FrP; Thu, 28 May 2026 10:17:52 +0200 Message-ID: <21c2c12a804d662d74c3518267d90e045223583e.camel@sipsolutions.net> Subject: Re: [PATCH] um: vector: avoid NULL queue dereference in legacy RX mode From: Johannes Berg To: Anton Ivanov , Henry Barreto , Richard Weinberger Cc: Tiwei Bie , linux-um@lists.infradead.org, linux-kernel@vger.kernel.org, Henry Barreto Date: Thu, 28 May 2026 10:17:50 +0200 In-Reply-To: References: <20260527213524.45903-1-contato@henrybarreto.dev> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-malware-bazaar: not-scanned On Thu, 2026-05-28 at 09:00 +0100, Anton Ivanov wrote: > >=20 > > So ... you're effectively saying that the tap transport has been broken > > since 6.12, released ~1.5 years ago. >=20 > The one I use is raw :) It is the most useful. Right. > Tap badly needs someone to expose the socket which the kernel uses to imp= lement it. I started writing a kernel helper at some point, but never finis= hed it. It should be able to produce "stupid speeds" with it. >=20 > And, yes indeed, this was broken by 612a8c8e0b43ba7e3d0e51f6f76a5fec4912d= 439 / 2024-07-05 which by the look of it I did not test for tap. >=20 Yeah, I guess I'm just thinking that clearly nobody uses it, the infrastructure isn't there (as you say), and it was broken for a rather long time now and nobody complained (that we know of.) So ... is it worth even keeping it? I'm fine either way, just wondering. johannes