From: Robert Love <rlove@google.com>
To: lkml <linux-kernel@vger.kernel.org>, Al Viro <viro@zeniv.linux.org.uk>
Subject: [patch] small sendfile fixes
Date: Mon, 22 Jun 2009 14:15:36 -0400 [thread overview]
Message-ID: <21c5ff280906221115v302d8b95t4a4ae2df86289056@mail.gmail.com> (raw)
Three fixes for sendfile, mostly related to sending large files from pseudo
filesystems:
- Fix sendfile for offsets > 300G. This can happen with pseudo filesystems.
This happens because the overflow check is using inode->i_sb->s_maxbytes
and not the superblock of the backing device's s_maxbytes. For a regular file
these are interchangible but for a special file these are different and you
want the latter.
- Don't compare against the max of the out_inode's superblock. Doesn't make
sense.
- For pseudo and other filesystems with s_maxbytes set to ~0ULL, max ends up
holding a negative number as it is signed. Check for and correct that.
Git patch is against 2.6.30. I'd like Al to take a look and make sure
my logic is right before applying.
Robert
From: Mandeep Singh Baines <msb@google.com>
Signed-off-by: Robert Love <rlove@google.com>
next reply other threads:[~2009-06-22 18:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-22 18:15 Robert Love [this message]
2009-06-22 19:04 ` Robert Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21c5ff280906221115v302d8b95t4a4ae2df86289056@mail.gmail.com \
--to=rlove@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®