From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Pankaj Patil <pankaj.patil@oss.qualcomm.com>,
andersson@kernel.org, linus.walleij@linaro.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
quic_rjendra@quicinc.com
Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] pinctrl: qcom: Add glymur pinctrl driver
Date: Mon, 21 Jul 2025 16:51:34 +0200 [thread overview]
Message-ID: <21c75060-eb8b-45f8-bddb-816fce787240@oss.qualcomm.com> (raw)
In-Reply-To: <20250721143037.20983-3-pankaj.patil@oss.qualcomm.com>
On 7/21/25 4:30 PM, Pankaj Patil wrote:
> Add TLMM pinctrl driver to support pin configuration with pinctrl
> framework for Glymur SoC.
> ---
> Changes in v2:
> UFS_RESET macro updated
> Removed obsolete comment for msm_pingroup glymur_groups
> Update gpio count in glymur_tlmm struct via .ngpio
>
> Signed-off-by: Pankaj Patil <pankaj.patil@oss.qualcomm.com>
> ---
As Krzysztof pointed out, your s-o-b is not part of the commit message
(include blurbs under the --- line, which Git will ignore)
[...]
> +static const struct of_device_id glymur_tlmm_of_match[] = {
> + { .compatible = "qcom,glymur-tlmm", .data = &glymur_tlmm },
> + {},
Nit: "{ }"
(no comma, as this is the sentinel and we most definitely don't want
the list to grow beyond it)
Konrad
next prev parent reply other threads:[~2025-07-21 14:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-21 14:30 [PATCH v2 0/2] pinctrl: qcom: Introduce Pinctrl for Glymur Pankaj Patil
2025-07-21 14:30 ` [PATCH v2 1/2] dt-bindings: pinctrl: qcom: Add Glymur pinctrl bindings Pankaj Patil
2025-07-21 14:36 ` Krzysztof Kozlowski
2025-07-21 14:30 ` [PATCH v2 2/2] pinctrl: qcom: Add glymur pinctrl driver Pankaj Patil
2025-07-21 14:51 ` Konrad Dybcio [this message]
2025-07-21 15:57 ` Pankaj Patil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21c75060-eb8b-45f8-bddb-816fce787240@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pankaj.patil@oss.qualcomm.com \
--cc=quic_rjendra@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®