From: Joe Perches <joe@perches.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>,
Linus Walleij <linus.walleij@linaro.org>,
Jonathan Corbet <corbet@lwn.net>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Kent Gibson <warthog618@gmail.com>
Cc: linux-gpio@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH 5/9] gpio: mockup: use pr_fmt()
Date: Thu, 24 Sep 2020 09:04:58 -0700 [thread overview]
Message-ID: <21cc553cc3a07e0952eb52a50149c323daff6041.camel@perches.com> (raw)
In-Reply-To: <20200924113842.11670-6-brgl@bgdev.pl>
On Thu, 2020-09-24 at 13:38 +0200, Bartosz Golaszewski wrote:
> We don't need a custom logging helper. Let's use the standard pr_fmt()
> macro which allows us to use all pr_*() routines with custom format.
[]
> diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c
[]
> @@ -577,7 +577,7 @@ static int __init gpio_mockup_init(void)
>
> pdev = platform_device_register_full(&pdevinfo);
> if (IS_ERR(pdev)) {
> - gpio_mockup_err("error registering device");
> + pr_err("error registering device");
You could add the missing newline at the same time.
next prev parent reply other threads:[~2020-09-24 16:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 11:38 [PATCH 0/9] gpio: mockup: refactoring + documentation Bartosz Golaszewski
2020-09-24 11:38 ` [PATCH 1/9] lib: string_helpers: provide kfree_strarray() Bartosz Golaszewski
2020-09-25 8:48 ` Andy Shevchenko
2020-09-25 11:32 ` Bartosz Golaszewski
2020-09-25 12:28 ` Andy Shevchenko
2020-09-24 11:38 ` [PATCH 2/9] Documentation: gpio: add documentation for gpio-mockup Bartosz Golaszewski
2020-09-24 11:38 ` [PATCH 3/9] gpio: mockup: drop unneeded includes Bartosz Golaszewski
2020-09-24 11:38 ` [PATCH 4/9] gpio: mockup: use KBUILD_MODNAME Bartosz Golaszewski
2020-09-24 11:38 ` [PATCH 5/9] gpio: mockup: use pr_fmt() Bartosz Golaszewski
2020-09-24 16:04 ` Joe Perches [this message]
2020-09-24 11:38 ` [PATCH 6/9] gpio: mockup: remove unneeded return statement Bartosz Golaszewski
2020-09-24 11:38 ` [PATCH 7/9] gpio: mockup: pass the chip label as device property Bartosz Golaszewski
2020-09-25 9:00 ` Andy Shevchenko
2020-09-24 11:38 ` [PATCH 8/9] gpio: mockup: use the generic 'gpio-line-names' property Bartosz Golaszewski
2020-09-25 9:03 ` Andy Shevchenko
2020-09-25 11:40 ` Bartosz Golaszewski
2020-09-25 12:30 ` Andy Shevchenko
2020-09-28 8:44 ` Bartosz Golaszewski
2020-09-28 9:11 ` Andy Shevchenko
2020-09-28 9:58 ` Bartosz Golaszewski
2020-09-24 11:38 ` [PATCH 9/9] gpio: mockup: refactor the module init function Bartosz Golaszewski
2020-09-25 9:04 ` [PATCH 0/9] gpio: mockup: refactoring + documentation Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21cc553cc3a07e0952eb52a50149c323daff6041.camel@perches.com \
--to=joe@perches.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=corbet@lwn.net \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®