From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933692AbcI0SyK (ORCPT ); Tue, 27 Sep 2016 14:54:10 -0400 Received: from mout.gmx.net ([212.227.15.15]:50920 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933233AbcI0SyJ (ORCPT ); Tue, 27 Sep 2016 14:54:09 -0400 Subject: Re: [PATCH v2 8/8] ARM: bcm2835: Disable i2c2 in the Device Tree To: Stefan Wahren , eric@anholt.net, wsa@the-dreams.de, swarren@wwwdotorg.org, =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= References: <1474977426-3272-1-git-send-email-noralf@tronnes.org> <1474977426-3272-9-git-send-email-noralf@tronnes.org> <256118042.194076.147d5d83-f402-4ba4-b7de-4ab57a0e29ad.open-xchange@email.1und1.de> Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org From: Jan Kandziora Message-ID: <21d33b61-d1a6-feb9-c9e7-ad3f565b6e41@gmx.de> Date: Tue, 27 Sep 2016 20:53:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <256118042.194076.147d5d83-f402-4ba4-b7de-4ab57a0e29ad.open-xchange@email.1und1.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:IaZhurzOdqQ9dldyTxWLae3GFvSWnhnALq/DDuh17DQfEvUJ5NP BCSQZM++j9lbfBARcM8mfzLDep7n/OQnllmfw8WizNAmI5xu6UyqpDF3WQBu5u/JllrP8QL JkudS34VkMj6/ENhScnyQFJFHPZ2x7a34swlfBjBZqx+xUQRCQLCGPH12sD7PNwSnjjysxr 5uSGgbByup/Wsu1Mc+EVg== X-UI-Out-Filterresults: notjunk:1;V01:K0:PIFHjT0glQQ=:QuEmbufu3rcMb23Htbu2AF YrGC+MbYnIEsLWebK2ormcbLHLisp8lNiQ854bwWkCN0Tc9cjJriRA3oWKtfIDQOVmi7Q6+XD fnRGiBthYlxIEGWCfP3yRRJMeKEYZnB1FR0jcBZZl9ukQ6+hBg2O6MsW5Eo9ED5pJA8p4thaH TdNRVyrrnx00xHVF/R6vRAGURWAprw+N4hnsWlfbwNI5d5uZKiYDlVPcxMcJeGorslOMnoRqk U+JZF8mgzMg3uLRXizyLxSKea0OolIMG8B/HowO/3OOlvh+pfq7OkFBagmAdpqoaxyg0phADB wwp62c7VkTOpxUA9VPU/YaQJb4g/5zP9J9XCo39Gwx4G7Bxdq45WS8+OQ1GXULN3vFHykMdwT 8yZDaRzGhcHj1bFL0C5g5ifsp1EqkPohVafjvmaHt9avaQwL1weCeENTgvo33FV/N1CVxnpxO sSiU6G+vVMhnxsJE/k3v5/QHqdrpWySVskaQJuC4JCtVUAJeiboIN5hAMCUU7BOs3NWXLGpIb 7c3b1Zm82NNaOLRENcj3hMVmZ8NU3Nmyg3sSciCtunH5cGFffIokDIUlJsDIuDiBu8gbNuwW5 XHrNCiNrouxb0DmjChhUsG/9AH7YjzlGD7D7nbn4gQynRHrKiAiZGj3nDELuH36pM1JHSirvh 9KeCcjgYg9bBuRMOY/KG+GaunM4o1QemUrUuYKVpOENfE/DNRvqiZ+0e20XJ9CcakTRhoHi9i r4LiAyqj8c8XRyx2kvVx2DqmnxJ2WF9bjvgerjFGNUWQbV2cEUAsQFcFd6YCe+EVX5F9HwatU L4BhoZd Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 27.09.2016 um 19:25 schrieb Stefan Wahren: > >> Noralf Trønnes hat am 27. September 2016 um 13:57 >> geschrieben: >> >> >> i2c2 is connected to the HDMI connector and is controlled by the >> firmware. Disable it to stay out of harms way. > > Until this point the commit message is okay, the rest is more confusing. > > Btw this should avoid a warning about missing clock frequency. > >> >> From the downstream commit: >> i2c-bcm2708/BCM270X_DT: Add support for I2C2 >> >> The third I2C bus (I2C2) is normally reserved for HDMI use. Careless >> use of this bus can break an attached display - use with caution. >> >> It is recommended to disable accesses by VideoCore by setting >> hdmi_ignore_edid=1 or hdmi_edid_file=1 in config.txt. >> >> Signed-off-by: Noralf Trønnes >> --- >> arch/arm/boot/dts/bcm2835-rpi.dtsi | 4 ---- >> 1 file changed, 4 deletions(-) >> >> diff --git a/arch/arm/boot/dts/bcm2835-rpi.dtsi >> b/arch/arm/boot/dts/bcm2835-rpi.dtsi >> index e9b47b2..8bffbee 100644 >> --- a/arch/arm/boot/dts/bcm2835-rpi.dtsi >> +++ b/arch/arm/boot/dts/bcm2835-rpi.dtsi >> @@ -59,10 +59,6 @@ >> clock-frequency = <100000>; >> }; >> >> -&i2c2 { >> - status = "okay"; >> -}; >> - > > I'm not sure if this the right fix. According to bcm283x.dtsi the 3 i2c busses > have the same compatible string "brcm,bcm2835-i2c", but the changelog suggests > that this bus is "special". > > Shouldn't we use a different compatible string? Our intention isn't to disable > i2c2 but avoid any claims of the usual i2c driver. > i2c2 should not be generally disabled. There's dtparam=i2c2_iknowwhatimdoing which enables CPU access to this bus. It's useful for reading out the monitor EDID by the CPU, and for accessing controls (backlight, volume) on certain monitors. And I have a I2C touchscreen controller on HDMI DDC. >> &sdhci { >> status = "okay"; >> bus-width = <4>; >> -- >> 2.8.2 >> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- > To unsubscribe from this list: send the line "unsubscribe linux-i2c" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >