From: Dave Airlie <airlied@gmail.com>
To: James Morris <jmorris@namei.org>,
LKML <linux-kernel@vger.kernel.org>,
eparis@parisplace.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [GIT] Security subsystem changes for 2.6.33
Date: Mon, 15 Feb 2010 14:50:17 +1000 [thread overview]
Message-ID: <21d7e9971002142050w7d6205cex5c8af7310a0dfeb4@mail.gmail.com> (raw)
In-Reply-To: <21d7e9971002142046p2a3af2bak1a01bb7117db7841@mail.gmail.com>
>
>> SELinux: add .gitignore files for dynamic classes
>
> This isn't such a good idea I've discovered after wasting half my day
> wondering why 2.6.33-rc8 oops in selinux
> code when vbetool runs.
>
> The problem (not sure what we or git can do, hence Linus cc'ed) is:
>
> a) git tree contains 2.6.32 + with old non-generated versions of
> flash.h and av_permissions.h
> b) git pull 2.6.33-rc8, nothing removes these old files, git status
> doesn't show them as they are now in .gitignore
> c) build 2.6.33, it picks up the include files from the old location
> not from the generated ones in the new tree.
> d) bad juju.
>
> I'm also doing out of tree builds btw.
Also I realise git clean -dxf would have done this, but there is
nothing to say you need to clean -x except an oops when you build
the kernel, the fact that git status is clean means its quite annoying to find.
Dave.
next prev parent reply other threads:[~2010-02-15 4:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-03 13:32 James Morris
2010-02-15 4:46 ` Dave Airlie
2010-02-15 4:50 ` Dave Airlie [this message]
2010-02-15 21:29 ` Eric Paris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21d7e9971002142050w7d6205cex5c8af7310a0dfeb4@mail.gmail.com \
--to=airlied@gmail.com \
--cc=eparis@parisplace.org \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®