From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751370Ab0CAGBw (ORCPT ); Mon, 1 Mar 2010 01:01:52 -0500 Received: from mail-iw0-f182.google.com ([209.85.223.182]:59344 "EHLO mail-iw0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750733Ab0CAGBv convert rfc822-to-8bit (ORCPT ); Mon, 1 Mar 2010 01:01:51 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=EA7zaZ/H0aQCr3dPHGOhbw4L42fEEUemVXzb0tRyOUfggVWd82cOVXBzMaWCYTHMVm qqQqoXfs7yc5jGrz2cFOjHkjtQE/QVC7RDRs1SDwhgbdd0LjNcb7gVOU3zTaigVAxWMY 2mXJdu211L1tlN9XwtEzk/T5ZjoxpnDN3FbQY= MIME-Version: 1.0 In-Reply-To: <20100224142759.ad4f53ce.randy.dunlap@oracle.com> References: <20100224142759.ad4f53ce.randy.dunlap@oracle.com> Date: Mon, 1 Mar 2010 16:01:50 +1000 Message-ID: <21d7e9971002282201p3f932729nc00a60bc5eadd492@mail.gmail.com> Subject: Re: [PATCH] drm: fix char constant (sparse warning) From: Dave Airlie To: Randy Dunlap Cc: lkml , David Airlie , Alex Deucher Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 25, 2010 at 8:27 AM, Randy Dunlap wrote: > From: Randy Dunlap > > Fix radeon/atombios.h sparse warning (24 times): > > drivers/gpu/drm/radeon/atombios.h:4091:63: error: Bad character constant We get this file from AMD pretty much as-is and I hate deviating it as it causes merge issues. Alex any change you can get this fixed upstream? Dave. > > Signed-off-by: Randy Dunlap > Cc:     David Airlie > --- >  drivers/gpu/drm/radeon/atombios.h |    2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-2.6.33-rc8.orig/drivers/gpu/drm/radeon/atombios.h > +++ linux-2.6.33-rc8/drivers/gpu/drm/radeon/atombios.h > @@ -4088,7 +4088,7 @@ typedef struct _SW_I2C_IO_DATA_PARAMETER >  #define SW_I2C_CNTL_WRITE1BIT 6 > >  /* ==============================VESA definition Portion=============================== */ > -#define VESA_OEM_PRODUCT_REV                               '01.00' > +#define VESA_OEM_PRODUCT_REV                               "01.00" >  #define VESA_MODE_ATTRIBUTE_MODE_SUPPORT            0xBB       /* refer to VBE spec p.32, no TTY support */ >  #define VESA_MODE_WIN_ATTRIBUTE                                                     7 >  #define VESA_WIN_SIZE                                                                                       64 > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at  http://vger.kernel.org/majordomo-info.html > Please read the FAQ at  http://www.tux.org/lkml/ >