From: Dave Airlie <airlied@gmail.com>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: ben@decadent.org.uk, airlied@linux.ie,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH 1/2] sis-agp: Remove SIS 760, handled by amd64-agp
Date: Fri, 26 Mar 2010 11:45:50 +1000 [thread overview]
Message-ID: <21d7e9971003251845i24af9712qb64aa3ca5f8f042c@mail.gmail.com> (raw)
In-Reply-To: <20100326104042T.fujita.tomonori@lab.ntt.co.jp>
On Fri, Mar 26, 2010 at 11:41 AM, FUJITA Tomonori
<fujita.tomonori@lab.ntt.co.jp> wrote:
> On Wed, 24 Mar 2010 03:33:48 +0000
> Ben Hutchings <ben@decadent.org.uk> wrote:
>
>> SIS 760 is listed in the device tables for both amd64-agp and sis-agp.
>> amd64-agp is apparently preferable since it has workarounds for some
>> BIOS misconfigurations that sis-agp doesn't handle.
>>
Will this not cause problems in 32-bit kernels?
Dave.
>> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
>> ---
>> drivers/char/agp/sis-agp.c | 8 --------
>> 1 files changed, 0 insertions(+), 8 deletions(-)
>
> Looks fine to me. Hopefully, amd64-agp can handle all SIS 760 systems.
>
> Can we confirm that this can fix bugs reported in Debian's bug
> tracking system (which you mentioned earlier)?
>
>
>> diff --git a/drivers/char/agp/sis-agp.c b/drivers/char/agp/sis-agp.c
>> index 6c3837a..95fdd4d 100644
>> --- a/drivers/char/agp/sis-agp.c
>> +++ b/drivers/char/agp/sis-agp.c
>> @@ -415,14 +415,6 @@ static struct pci_device_id agp_sis_pci_table[] = {
>> .subvendor = PCI_ANY_ID,
>> .subdevice = PCI_ANY_ID,
>> },
>> - {
>> - .class = (PCI_CLASS_BRIDGE_HOST << 8),
>> - .class_mask = ~0,
>> - .vendor = PCI_VENDOR_ID_SI,
>> - .device = PCI_DEVICE_ID_SI_760,
>> - .subvendor = PCI_ANY_ID,
>> - .subdevice = PCI_ANY_ID,
>> - },
>> { }
>> };
>>
>> --
>> 1.7.0
>>
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
next prev parent reply other threads:[~2010-03-26 1:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-24 3:33 Ben Hutchings
2010-03-26 1:41 ` FUJITA Tomonori
2010-03-26 1:45 ` Dave Airlie [this message]
2010-03-26 2:10 ` FUJITA Tomonori
2010-03-26 2:31 ` Dave Airlie
2010-03-26 3:07 ` Ben Hutchings
2010-05-16 1:08 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21d7e9971003251845i24af9712qb64aa3ca5f8f042c@mail.gmail.com \
--to=airlied@gmail.com \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=ben@decadent.org.uk \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®