From: Dave Hansen <dave.hansen@linux.intel.com>
To: riel@redhat.com, linux-kernel@vger.kernel.org
Cc: mingo@kernel.org, luto@kernel.org, yu-cheng.yu@intel.com, bp@suse.de
Subject: Re: [PATCH 2/2] x86/fpu: copy MXCSR & MXCSR_FLAGS with SSE/YMM state
Date: Thu, 26 Jan 2017 07:03:22 -0800 [thread overview]
Message-ID: <21e288ef-8e89-ca61-f5e1-b546b0761538@linux.intel.com> (raw)
In-Reply-To: <20170126015759.25871-3-riel@redhat.com>
On 01/25/2017 05:57 PM, riel@redhat.com wrote:
> /*
> + * Restoring SSE/YMM state requires that MXCSR & MXCSR_MASK are saved.
> + * Those fields are part of the legacy FP state, and only get saved
> + * above if XFEATURES_MASK_FP is set.
> + *
> + * Copy out those fields if we have SSE/YMM but no FP register data.
> + */
Patch looks functionally good to me. One nit on the comment, though:
Usually XSAVE "state" refers to the state in the CPU while the "area"
refers to the buffer in memory. Probably best to talk about the "legacy
FP area", not state.
Maybe something like this for the first paragraph:
MXCSR and MXCSR_MASK are part of the SSE and YMM states and are
saved/restored along with those states. However, they are
located in the legacy FP *area* of the XSAVE buffer.
next prev parent reply other threads:[~2017-01-26 15:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 1:57 [PATCH 0/2] x86/fpu: copyout_from_xsaves & copyin_to_xsaves fixes riel
2017-01-26 1:57 ` [PATCH 1/2] x86/fpu: move copyout_from_xsaves bounds check before the copy riel
2017-01-26 9:40 ` Ingo Molnar
2017-01-26 9:47 ` Ingo Molnar
2017-01-26 1:57 ` [PATCH 2/2] x86/fpu: copy MXCSR & MXCSR_FLAGS with SSE/YMM state riel
2017-01-26 8:14 ` Ingo Molnar
2017-01-26 8:21 ` [PATCH] x86/fpu: Rename copyin_to_xsaves()/copyout_from_xsaves() to copy_user_to_xstate()/copy_xstate_to_user() Ingo Molnar
2017-01-26 10:26 ` Ingo Molnar
2017-01-26 15:03 ` Dave Hansen [this message]
2017-01-30 17:34 ` [PATCH 2/2] x86/fpu: copy MXCSR & MXCSR_FLAGS with SSE/YMM state Yu-cheng Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21e288ef-8e89-ca61-f5e1-b546b0761538@linux.intel.com \
--to=dave.hansen@linux.intel.com \
--cc=bp@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=riel@redhat.com \
--cc=yu-cheng.yu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®