mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gabriele Monaco <gmonaco@redhat.com>
To: Tomas Glozar <tglozar@redhat.com>, Steven Rostedt <rostedt@goodmis.org>
Cc: linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org,
	John Kacur <jkacur@redhat.com>,
	Luis Goncalves <lgoncalv@redhat.com>
Subject: Re: [PATCH v2] trace/osnoise: Add trace events for samples
Date: Wed, 05 Feb 2025 13:01:58 +0100	[thread overview]
Message-ID: <21e53ffc5e2805e369fadc5e0cc582379a605ab4.camel@redhat.com> (raw)
In-Reply-To: <CAP4=nvRNvdULubjN1XPF8jNxY3tRdfy+9Vqv97EsKjzNGKyYig@mail.gmail.com>

On Tue, 2025-02-04 at 14:35 +0100, Tomas Glozar wrote:
> po 3. 2. 2025 v 10:04 odesílatel Tomas Glozar <tglozar@redhat.com>
> napsal:
> > A proof-of-concept bpftrace script using this feature:
> > https://gitlab.com/-/snippets/4801190
> > 
> 
> I added another PoC using event histograms to the snippet. That one
> captures data from all CPUs, and thus can be used for testing on
> machines with a high number of CPUs where rtla cannot keep up with
> timerlat samples (in our measurements, >100).
> 
> There seems to be an issue with division where most values are
> rounded up, e.g.:
> max:        135  timer_latency:     134657
> 
> This also affects the main histogram and seems to be specific to the
> event histogram PoC. The bpftrace one shows exactly the same results
> as rtla when run concurrently with it. Another difference compared to
> the bpftrace PoC is that you have to calculate averages manually from
> the latency sum and the sample count.
> 
> Tomas
> 

The patch and scripts using the new tracepoints produce reasonable
results on a large arm64 machine (128 cores).

Tested-by: Gabriele Monaco <gmonaco@redhat.com>

Thanks,
Gabriele


      reply	other threads:[~2025-02-05 12:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-03  9:04 Tomas Glozar
2025-02-04 13:35 ` Tomas Glozar
2025-02-05 12:01   ` Gabriele Monaco [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21e53ffc5e2805e369fadc5e0cc582379a605ab4.camel@redhat.com \
    --to=gmonaco@redhat.com \
    --cc=jkacur@redhat.com \
    --cc=lgoncalv@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tglozar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®