From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29BD0C0044C for ; Mon, 5 Nov 2018 09:13:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CA95A20862 for ; Mon, 5 Nov 2018 09:13:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="e/qp1co6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CA95A20862 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727601AbeKEScd (ORCPT ); Mon, 5 Nov 2018 13:32:33 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:43770 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726125AbeKEScd (ORCPT ); Mon, 5 Nov 2018 13:32:33 -0500 Received: by mail-wr1-f68.google.com with SMTP id y3-v6so8278305wrh.10 for ; Mon, 05 Nov 2018 01:13:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=wA7TyDJb/otO8QhHIlksbXuo8LT1Oi0HmcIwXXvvRmQ=; b=e/qp1co6W/KuTAqloqSSr5Ugq/YYo6wC5XXlVKi9YpBNKj5YsD86IKyKjjpEBpqFfL MNZzyCgRXpIkknQ2xvvydk6HX9iNjDZWG1jj0ozJtc9jkWvbVz9v1uQsDVF9pd/5QwIv eIo7d0BVUhtMj1z8lTUcnIECtqnjoyAn2XUpQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=wA7TyDJb/otO8QhHIlksbXuo8LT1Oi0HmcIwXXvvRmQ=; b=Me+4C/2K22E7cl319JV6Cdm+Wg492pYuNFzpIR7nP6uZiRSGCyn7VPSQSTwhzDZbV/ VnzKtZpsZ2IZOODrIVKrPhSrNfBzWDBTnohhfrq9/sDNv0XWhSoMToFi0yLB8YxnX9ln Pc/yHnFxMXsK8jnzdkfGgRepcBcfmMkYCE63xB4xgzIfXcA9JW/AZqIzfQfdqd20VHyH 2i4xkBG4Fpc2M30iql7q+morrpWIxd4WAsXa0cVIaFFguO5LeJtisVSLyEZQfnSq0Vx8 eWLXMlxsvZAHCAdfTl7FJglFIOstEhAWrAc2QGPhtwG76ohkovulmQJVmGkuifIF3GY9 f4cg== X-Gm-Message-State: AGRZ1gKW+kHgZHon62hxDK1EsrxNf0kXCdHy1BzlUJ4z7wd5N07AYInq AWwJlc2lXoWxEPTE5L5ZccmjkA== X-Google-Smtp-Source: AJdET5drZNWJdxfR0XoW8eU1R/PmptP/mqhIYAeBmn2NSFx5W4Ig3LkJGc/fPX4awJbv226t+QeKnA== X-Received: by 2002:adf:cc81:: with SMTP id p1-v6mr809562wrj.139.1541409228885; Mon, 05 Nov 2018 01:13:48 -0800 (PST) Received: from [10.176.68.125] ([192.19.248.250]) by smtp.gmail.com with ESMTPSA id i7-v6sm8600443wrs.55.2018.11.05.01.13.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Nov 2018 01:13:48 -0800 (PST) Subject: Re: [PATCH 2/5] brcmfmac: Use common CORDIC_FLOAT macro from lib To: Kalle Valo , Priit Laes References: <4bd6e7758bc0d88b33cdb09448633bb5b97aba7c.1541238842.git-series.plaes@plaes.org> <877ehrhp21.fsf@codeaurora.org> Cc: linux-kernel@vger.kernel.org, Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , "David S. Miller" , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, netdev@vger.kernel.org From: Arend van Spriel Message-ID: <21e6a75b-7728-761d-d899-395864226fb5@broadcom.com> Date: Mon, 5 Nov 2018 10:13:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <877ehrhp21.fsf@codeaurora.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/5/2018 10:05 AM, Kalle Valo wrote: > Priit Laes writes: > >> Now that cordic library has the CORDIC_FLOAT macro, use that >> >> Signed-off-by: Priit Laes >> --- >> drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c | 4 ++-- >> drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c | 4 ++-- > > The driver is "brcmsmac" (note the 's', not 'f'), you should fix the > title accordingly. > >> --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c >> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c >> @@ -3447,8 +3447,8 @@ wlc_lcnphy_start_tx_tone(struct brcms_phy *pi, s32 f_kHz, u16 max_val, >> >> theta += rot; >> >> - i_samp = (u16) (FLOAT(tone_samp.i * max_val) & 0x3ff); >> - q_samp = (u16) (FLOAT(tone_samp.q * max_val) & 0x3ff); >> + i_samp = (u16)(CORDIC_FLOAT(tone_samp.i * max_val) & 0x3ff); >> + q_samp = (u16)(CORDIC_FLOAT(tone_samp.q * max_val) & 0x3ff); > > I haven't seen the patch 1 yet, but just from seeing this patch I don't > get what's the benefit. The FLOAT macro was defined in brcmsmac (see patch 3). It is now moved to the cordic library simply because it is more closely related to that. Regards, Arend