From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751801AbdIULg1 (ORCPT ); Thu, 21 Sep 2017 07:36:27 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:36235 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751450AbdIULg0 (ORCPT ); Thu, 21 Sep 2017 07:36:26 -0400 X-Google-Smtp-Source: AOwi7QCJqf0QFsvTUYl4s5lhh9dp2SYEahkg1gDUo7VY8xYMtYljjWdh84jRtzINC9+MJ2RjdVIUKg== From: Arvind Yadav To: rmfrfs@gmail.com, johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org Cc: greybus-dev@lists.linaro.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: staging: greybus: Release memory obtained by kasprintf Date: Thu, 21 Sep 2017 17:05:27 +0530 Message-Id: <21ea1d2e0ef0c3d4d59b2e5d2e189533c8b1668a.1505991013.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Free memory region, if gb_lights_channel_config is not successful. Signed-off-by: Arvind Yadav --- drivers/staging/greybus/light.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c index 3f4148c..b00d47c 100644 --- a/drivers/staging/greybus/light.c +++ b/drivers/staging/greybus/light.c @@ -984,7 +984,7 @@ static int gb_lights_channel_config(struct gb_light *light, ret = channel_attr_groups_set(channel, cdev); if (ret < 0) - return ret; + goto err; gb_lights_led_operations_set(channel, cdev); @@ -994,15 +994,18 @@ static int gb_lights_channel_config(struct gb_light *light, * configurations. */ if (!is_channel_flash(channel)) - return ret; + goto err; light->has_flash = true; ret = gb_lights_channel_flash_config(channel); if (ret < 0) - return ret; + goto err; return ret; +err: + kfree(cdev->name); + return ret; } static int gb_lights_light_config(struct gb_lights *glights, u8 id) -- 1.9.1