From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0700835F185 for ; Mon, 25 May 2026 23:40:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779752413; cv=pass; b=NSCPr+frVQuWWw5nNiUsFeamtuTa9irUmqC2Zis8ug/uEJS8LyQhiAzVf7jGnHtLs2dL7ckmrE1MnANwpcxEQJHXRBqdeQSL3s72PUyoowZqRDqYiv10fjX0w88tV17+jtPH0boOEWGPUp8Kouqu1v+PU4q/i7tU7B4LvN5FhBw= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779752413; c=relaxed/simple; bh=ZPsbVRd9F8t93i8Vw6dJlgO8WYnfzvnn63wWDmXNjOY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hCVYjnS5ItYQb4lLrYh2u+UzjlPbM8yEaY+UIkrb6OZl0J4ihjTq3/7iY6Jf40yyHP9XX7afKGw687QtlWcN31HIXTu67x2cGZVUwKRdh+zwBbpcG1LHucMEQQeYmY9PB72GLGX6d0/TFIdZOm9SDhVhOsQ2A+jb5iS0a6+PF2E= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=leandro.ribeiro@collabora.com header.b=FOCWb8Q3; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=leandro.ribeiro@collabora.com header.b="FOCWb8Q3" ARC-Seal: i=1; a=rsa-sha256; t=1779752400; cv=none; d=zohomail.com; s=zohoarc; b=ca1wM0tMBOu1Cw5uvOyCSkwsgbLX/fsZ0rKlkNVFl7Vq95JfYdX+WUibFBoDPf5q7zEMVxxViwfo8OtHf8blWeGaI78/SnuQD+x73J/NlKYndwDrMhkDRKmWUEks8Vhl4cJCDy5sTCgUp8Qrt+wfXuFfbt2bPCRExmDpF4srvbs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1779752400; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=ZvrW3sUwBueNf3eOV1tZZMywMjDuEwW0BY1Xg9h0JPs=; b=bD/MMXduFJqi1dyzzNpxtOV3zmIKe6q+Gozda2ysA1lg9T0lQ3Za/pnXyAiSGFnjvz9zTk3q2wXXOTy8EUOfCieL3O/LLtEIN15VGYPyv4nZ0PyeIeiaUF3NxVEEqFzF9K8APziniv/sikCEefRYr2aPsrdy25XuzmGtgu83Pdw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=leandro.ribeiro@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1779752400; s=zohomail; d=collabora.com; i=leandro.ribeiro@collabora.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=ZvrW3sUwBueNf3eOV1tZZMywMjDuEwW0BY1Xg9h0JPs=; b=FOCWb8Q3MGLsXssXZMfZ6TkYAczPRmIsuYfzH/7T7kTtpkMeodSB8XX9cyMCJQKI KaYHjCLv9gQzSOAh6DODRJWUIiEljD9JKHl3RwPTVsyahmInkNydotbUdRa9WTfRB5c 3LVMxhEb3U6y6/tKH3Fb8BDPfm+RLcM1o2jH4QmU= Received: by mx.zohomail.com with SMTPS id 1779752397409221.4769894279583; Mon, 25 May 2026 16:39:57 -0700 (PDT) Message-ID: <21f1ee84-8786-406a-a91c-a03acc231877@collabora.com> Date: Mon, 25 May 2026 20:39:52 -0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] drm: ensure blend mode supported if alpha exposed To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: dri-devel@lists.freedesktop.org, airlied@gmail.com, daniels@collabora.com, jani.nikula@linux.intel.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, pekka.paalanen@collabora.com, simona@ffwll.ch, tzimmermann@suse.de, linux-kernel@vger.kernel.org References: <20260518175429.80615-1-leandro.ribeiro@collabora.com> <20260518175429.80615-3-leandro.ribeiro@collabora.com> Content-Language: en-US From: Leandro Ribeiro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External On 5/22/26 3:18 PM, Ville Syrjälä wrote: > On Mon, May 18, 2026 at 02:54:29PM -0300, Leandro Ribeiro wrote: >> Before "drm/drm_blend: allow blend mode property without PREMULTI", >> userspace would have to assume that only PREMULTI was supported by >> drivers that didn't expose the blend mode property. But now userspace >> shouldn't relly on that, as they can't count with drivers always >> supporting PREMULTI. >> >> Error out if a driver expose alpha property or pixel formats with alpha >> and does not expose the blend mode property. This way userspace don't >> have to guess. Drivers that hit such error must be fixed. > > I don't think the error handling is a good idea. It's just another > completely untested error path that is more or less guaranteed to > break eventually. So IMO just WARN and plow ahead like we do for > everything else there. > Sounds good to me, I'll change that in the next revision. >> >> Signed-off-by: Leandro Ribeiro >> --- >> drivers/gpu/drm/drm_crtc_internal.h | 2 +- >> drivers/gpu/drm/drm_drv.c | 7 ++++-- >> drivers/gpu/drm/drm_mode_config.c | 37 +++++++++++++++++++++++++++-- >> 3 files changed, 41 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/gpu/drm/drm_crtc_internal.h b/drivers/gpu/drm/drm_crtc_internal.h >> index c09409229644..2a4862202496 100644 >> --- a/drivers/gpu/drm/drm_crtc_internal.h >> +++ b/drivers/gpu/drm/drm_crtc_internal.h >> @@ -95,7 +95,7 @@ int drm_mode_setcrtc(struct drm_device *dev, >> /* drm_mode_config.c */ >> int drm_modeset_register_all(struct drm_device *dev); >> void drm_modeset_unregister_all(struct drm_device *dev); >> -void drm_mode_config_validate(struct drm_device *dev); >> +int drm_mode_config_validate(struct drm_device *dev); >> >> /* drm_modes.c */ >> const char *drm_get_mode_status_name(enum drm_mode_status status); >> diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c >> index 985c283cf59f..def78046a963 100644 >> --- a/drivers/gpu/drm/drm_drv.c >> +++ b/drivers/gpu/drm/drm_drv.c >> @@ -1059,8 +1059,11 @@ int drm_dev_register(struct drm_device *dev, unsigned long flags) >> const struct drm_driver *driver = dev->driver; >> int ret; >> >> - if (!driver->load) >> - drm_mode_config_validate(dev); >> + if (!driver->load) { >> + ret = drm_mode_config_validate(dev); >> + if (ret) >> + return ret; >> + } >> >> WARN_ON(!dev->managed.final_kfree); >> >> diff --git a/drivers/gpu/drm/drm_mode_config.c b/drivers/gpu/drm/drm_mode_config.c >> index 66f7dc37b597..18c6b5707532 100644 >> --- a/drivers/gpu/drm/drm_mode_config.c >> +++ b/drivers/gpu/drm/drm_mode_config.c >> @@ -674,16 +674,45 @@ static void validate_encoder_possible_crtcs(struct drm_encoder *encoder) >> encoder->possible_crtcs, crtc_mask); >> } >> >> -void drm_mode_config_validate(struct drm_device *dev) >> +static int plane_alpha_require_blend_mode(struct drm_plane *plane) >> +{ >> + struct drm_device *dev = plane->dev; >> + const struct drm_format_info *fmt; >> + u32 i; >> + >> + /* blend mode property supported, no need to check anything */ >> + if (plane->blend_mode_property) >> + return 0; >> + >> + if (plane->alpha_property) { >> + drm_err(dev, "[PLANE:%d:%s] alpha property exposed but blend mode not setup", >> + plane->base.id, plane->name); >> + return -EINVAL; >> + } >> + >> + for (i = 0; i < plane->format_count; i++) { >> + fmt = drm_format_info(plane->format_types[i]); >> + if (fmt->has_alpha) { >> + drm_err(dev, "[PLANE:%d:%s] pixel format with alpha exposed but blend mode not setup", >> + plane->base.id, plane->name); >> + return -EINVAL; >> + } >> + } >> + >> + return 0; >> +} >> + >> +int drm_mode_config_validate(struct drm_device *dev) >> { >> struct drm_encoder *encoder; >> struct drm_crtc *crtc; >> struct drm_plane *plane; >> u32 primary_with_crtc = 0, cursor_with_crtc = 0; >> unsigned int num_primary = 0; >> + int ret = 0; >> >> if (!drm_core_check_feature(dev, DRIVER_MODESET)) >> - return; >> + return ret; >> >> drm_for_each_encoder(encoder, dev) >> fixup_encoder_possible_clones(encoder); >> @@ -732,9 +761,13 @@ void drm_mode_config_validate(struct drm_device *dev) >> drm_for_each_plane(plane, dev) { >> if (plane->type == DRM_PLANE_TYPE_PRIMARY) >> num_primary++; >> + >> + ret |= plane_alpha_require_blend_mode(plane); >> } >> >> WARN(num_primary != dev->mode_config.num_crtc, >> "Must have as many primary planes as there are CRTCs, but have %u primary planes and %u CRTCs", >> num_primary, dev->mode_config.num_crtc); >> + >> + return ret; >> } >> -- >> 2.54.0 > -- Leandro Ribeiro