From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753077AbdCMOyo (ORCPT ); Mon, 13 Mar 2017 10:54:44 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:43509 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751035AbdCMOye (ORCPT ); Mon, 13 Mar 2017 10:54:34 -0400 Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=fb.com; Subject: Re: [PATCH] writeback: fix memory leak in wb_queue_work() To: Tahsin Erdogan , Tejun Heo , "Alexander Viro" , Jan Kara , John Sperbeck , Peter Chang References: <20170310200949.26359-1-tahsin@google.com> CC: , From: Jens Axboe Message-ID: <2200cf0b-d939-6166-402b-61c328f899cf@fb.com> Date: Mon, 13 Mar 2017 08:54:19 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170310200949.26359-1-tahsin@google.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [216.160.245.98] X-ClientProxiedBy: MWHPR1601CA0021.namprd16.prod.outlook.com (10.172.93.31) To DM5PR15MB1194.namprd15.prod.outlook.com (10.173.209.12) X-MS-Office365-Filtering-Correlation-Id: 30805785-7a1e-45de-9d19-08d46a20d733 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:DM5PR15MB1194; X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1194;3:3OqyUd7Gjm3P7oNG7f1InEQvSasVYqPWWsa2EdvFo7MX04UYZepqXWldzeps/6ZYTcF1Le7VaYmrEVpLad7xayPaq4r5iXcC94aKIqzuJVW2d9x/kLi6vVV1MOuIY4akF9NSe86fDtZFd+wduP8EF7wMft1EsnTedDsMkNrf9letfsXdc19F3YY4LXHQDfxoHffgy8zXH2/neNzruYXFBbIXSQxcZAULL4cuCFAliHAvzq1mvLIXS7V4Ga+7sS1N5jW3cFDLrr8b/kJqMnWjjw==;25:llTuTwzNa2FJ8wtxMwY0QvTNdcGHxRywtpvNatWF9KTFl/vtlssgNQXoaNv207/q5+5QrgsycJFflsEMMGBKMwb48gN3KnqWF1ZFMFg3YTgCmljpcanLDi77wR8f3iKqT9wmihVak2hoXUSuCoPPFxD8FPPodKvNyXNDXVlHwoEApCwW0une7+ziYHlurt+diMSKX7v2+bobiwRTwppxMKqkmW1aCMJ+45ZJ51bAnlLzkOioBWDySts+/BWWRv2UceTlFvppWymK7gcoeY2JElIIRtz1GPrgB4obLysXSTIm/q7Og5T+e++Nk7GbQN4xRhkReL0kBrZYvTVGEba1o8H/EXa12ZdM3EOlhXhKrxF6Omc+LX4SfhTC97NG8VuK24pp6cXXRVQqVLORkqL6KXnrz17VDKpUxrizSm8VPXGQ/rYTL1ROfWDEjQWmx2PddEu5UnQTZ8lW0AwD1iRWrQ== X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1194;31:cfskeG2He6+Dl708kfCT8vf1iJyVSa5Uy6BmukFIeZZ4t/pPpFU2oPgU97X/tZaPXBmzs0UTGi5xCMnbauoNlX1iQHsq5A1EJsQl6ia8JtMEKBt5ubxu4AJoHA+YMXrYPg22e2IkIT39wNy8Wlu24VkRkSrCI+Fle97+bEiEbWMvDSVpG1+ysGVzYe1s2v/XFQs4SLD7S8KzwFQGF4AV4En5vyf7b06in81qWc4b73wx1csjoNBkKw1NdrfXeRdiDuEz8D0LiNKJOF2JXFWG3Q==;20:gwgDwUogivCvLzuk2dD6YcroxGchY/XIeeA1q5QfUEVyIIBqBfQssWEu+b+09HExJLqRmFZDu6GgdhiSg/zIGWHeBV5CHmRTsmpUGDaEZ4Rib0WWI/6uiLwnX2F24A6bAAKr32w4A7+s+YEIER4wpxcFFGI9cZ9ELaISqF8AbOtuRfQmhHmFUOGmNRUH3JVOYQHEfq4Gz9Sk2Htb661DrEJzSq+2i9nnRhXjkTtNde9LxAKFuMSMmRJEe6CqKIecasUQL7LLWApQYg9lf589N+AoiBAd3I+RYhETKxr+RbnJJN1VfckLbKSdqyx3EBaP5Chwon2Yxs1QM9fQwWe17tAax9ViWs28i4O8F/9qFpxsxZ4Rb55Nl4JnvuJ3viAukM9/g3x8jxtGXbyRkvQ4cWUww7Gaba8XzRJoYoQdYycCSW9/ZoCXGa6vQWTPgyTTw3snnyAmpnBFbtBwKHeRNFD6KxS5l/ddLOcF4wp6+jWPzN8q0F1FsUsvOIKA2eQp X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6041248)(20161123564025)(20161123558025)(20161123560025)(20161123555025)(20161123562025)(6072148);SRVR:DM5PR15MB1194;BCL:0;PCL:0;RULEID:;SRVR:DM5PR15MB1194; X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1194;4:d0pBlVz+vdegvDnQZVSD1g7AtKZKhrCYTgHfUn5VRgTf6GmRUkB+fD+pW8YELBYKd8GQU+YnJzc97HkT6gt6P+UNsXB0YAoCfC4r0KQFM1HtFNquUH0y7Xhuf8Rv/bPeqLj5wogu2DXwohaWqEcZiGENqg8hOmowvD8Ff7WVEZyBbwTAu6Mz2/1MSIgiJj7p4vdDhtEmxTht/D1CCVab/i70U4B1TcaASR+AtsJGrc3yMYjmT469cHYEjaYdq0cwrnxKZINh7pQcU4QD3opDkbIDFDf+fKhPkXQBR/19EohLXi9J6rpK0rYtovwRxWVMZtDUvyoNJhORggx//aaabUin61b6xxVrexM+7DDfApO3TdQppsL+GcQI3a0c2OhhwUzb4rBwkUOy0+jL1JHc8ifYFtzb/XFAR5XFndoDIUNuF5KxpK4aTWG01D7OqAShtfxnzxahdM0jSHSuOc7Zl22qDMttwRhv/SHUBsCxJbu0iibabPf57CDrrFHa96jLCMrAp7rqlP+rU1SizYvgjjpahqIVA3yr2Sjv54Ee2qdaezXpz1YObYj0/AeSv/MwbyhuY4EmbapbnvyL0UsJIonhMu4IAuCSA20PXT5sMVM= X-Forefront-PRVS: 0245702D7B X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(39450400003)(39830400002)(39410400002)(377454003)(24454002)(50986999)(3846002)(2950100002)(230700001)(81166006)(6116002)(36756003)(54356999)(76176999)(33646002)(6666003)(53546006)(83506001)(65826007)(117156001)(229853002)(77096006)(90366009)(6486002)(2906002)(4326008)(5660300001)(64126003)(54906002)(65956001)(47776003)(66066001)(31696002)(38730400002)(53936002)(189998001)(6246003)(305945005)(42186005)(50466002)(23746002)(7736002)(25786008)(31686004)(8676002)(86362001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR15MB1194;H:[192.168.1.154];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DM5PR15MB1194;23:QIJGWliwesQXM90dLR2cpV+Onm5+ug74lU95U?= =?Windows-1252?Q?kbwgvuc7zqaaozxR0WbqA9Go6AV58fUF7jFEVZ4qlHIpSS52JUjESfSf?= =?Windows-1252?Q?xMJapYWrMxR19F/0vdGZcR+0N2LrESJc/u/Af348zfUXtLL2/DGx1zwz?= =?Windows-1252?Q?cqBfRLeaLK4W3owIcV/uUeOd2c173V4FE5SiMm4OBKJ/rduXJfIWY+cH?= =?Windows-1252?Q?8kIWEgozG+LzJ0ZldH339lnL1jlWU604S6AnG7aRwefUHFM2JJ7tXEp9?= =?Windows-1252?Q?01qkVZ0YWQZfYAcKf2vMjiG3TMziq6jgdp2+e3TdpjQOuc7HRtrMtV5A?= =?Windows-1252?Q?zAXe/MZqRP5lOkRhy8L1aQ1LCtB1kgong/cBth+ScYnrGAaLMOoUSKlT?= =?Windows-1252?Q?KZomGED7WHhvY35R+MZ4IkyPNy02niYQLcQP2CWVDRaf/4bJzusnR2Gv?= =?Windows-1252?Q?3Z+HbBf69+Shf9amO7Zydkwc05Yn0RY+RF1SkuoE4Ud88JxSdMJX0zHE?= =?Windows-1252?Q?7w1JXNgqsH7E7mM7XDSFGDPyEH01h94x4q2ujlyyHEbnNacTc8hv1uNq?= =?Windows-1252?Q?vxo+CMe8d+VdkBazrCn1WocO7UZJMSRDaKJL1U0GWr5UPJFuM2u3kTTi?= =?Windows-1252?Q?u6BbHre+9t9oNetcTzjnBaIgLgUdQdxgic8jD4zqLwgmeYvJNnpxCgkr?= =?Windows-1252?Q?HfOXVjOwZhp9ur2sAOJPzj1yVqoKpidKIF7AFIGJZ4cYMsq1seNuz7Nc?= =?Windows-1252?Q?WjWyfDjlPg9a+lDCNkbmPMa4WpVXfxnSN+UM9zT9hyONhuf6jm3N9uBv?= =?Windows-1252?Q?lD7OalXiQAKRt17pSyU3ce3s3+TfIfqXBl+pbQaqAu+3CmCthnZvgIkU?= =?Windows-1252?Q?gkSlIcdQhx6nSm5c5ylWAQNpHP3p/Ja9vnfd02ToUPcTDjJy+oB/CYue?= =?Windows-1252?Q?Qlv0Jf87hIUTnqt2Hc32FBt01FQqFHtmYU/NViQHH6W96fXOtPNY7Ke9?= =?Windows-1252?Q?IME5htUQVSfjF89mOcFzoHswbBJSMZ9XxNFdJXSSKXhXbTgD+mjIH0DY?= =?Windows-1252?Q?zQeqwFAWvZ4jt0egMW/xj79Zp+KW3uQ+LmA0y6ySRMb3cdnB8Y7U+Cku?= =?Windows-1252?Q?HsfEfwfTnyf3ksww90IAPUOm+H5IeJJRx4gbfhp745O6ub5yxGxNfmTX?= =?Windows-1252?Q?N0FpoiNCr3FiHK+DUBSivneOO0xxeSpZA1On9umpwcXGquAaiRGaai1y?= =?Windows-1252?Q?v3PabnyWu7Z4mGDeeabpSu7bJYK9QPbdnWyeyaXLbjYKtJkNaKPaosce?= =?Windows-1252?Q?tl6?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1194;6:Eug7kapbuoZ81CmlTg+Ra5ecWzWeb4eQk6qURR7KS1fbH46qNkmHdTde0YgkhztGnrbDjiA67G4Ur8KRfABY9tAAwTn5xm0yjfNfmamDAIhFbspNOhXVsReVh/6/H6TKX/MsH7GW/Rmqc59jUhhmoT4wljVYwg1+mPOcHkaI98P6kBitp1UwoXcZRIQbnmiBOOCVBFs+VH0IAuIeNQwlBvpNJkgnicyNxml7vs1lRTuylrKD9PpCXnN4tsaCndd1NtV3j++WsH8TqgkCjqWQiFAuGCMKHdik4xvKMjSdpeyZ72DOdjWQjfr1be7V3Me59iKyRLZhOVbuAuxUnFjnt+S+h/YMCbvtmkDLRaVGlYJKCxBCOXHpd2pZAOWwK5K1eGIsK70877gmxjWVEP+bjA==;5:BXFVjebyZhxIuQZm7bIKFPhxm/hwRbfw5maPYE8MFDaLYH9OppzSHxQ0QJcUtEnl2GLUsmkC6zrxdbEzwjJrP8MkgvEZh1VZ5NDlCgKaKnUJ9QBNzjOV20Jy7Xt9hfSQg/1f7R45zjqAVwS5XLer2A==;24:EcX31XycTAPaQ2ntcfY6AryixFtUSTq26lDZq1o0bRzj7nI57qBBsrkvN8K4Vo1YMk7/X/j/dpDkkKb3DWWuFWrIgWAawlMSt6ym03tHaq4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1194;7:rWdt2t/ZnjFKFxc8D9Ukd62bT8fvENW6CvqBI65UzYXRoNjzb2c8VFg+7H+DwrS31eyV02v6TK2BmlmZWhDu9/uMJ7jzmknEPc7kokHXTIwUP9PyB6buQmfr4SW59/V8+caBP/7co8teFMvJ04Ak4DjLbJ5pHDoonGqTRIPnC9DstNPYOqZANTeGFQf/k2tE9+bR6Tt7H4ClMSiLsgBIK8EG5VvJoWhaDqZrco9QBz0uYMY91Ta/4Jq1i8yLOU+SJ/jManfXTuvKngF1242bmt3T5koEOhZFttqoLefAlvbUfzwuzPRa1uGTmx/p0QNhfG0vw++Y0vbpjDwcPzn/HA==;20:e5smmLyr9ZbW4iIArlEplH7I1NZZ/g5jK0ginsWpAwxjzksxHR+Ur5owQ2gEw6g917SX6p/TYmUaFcc1JH7bn1bOlQp0WcNGlHx1j0K2PLv69IAhLhWIvXD1tGOksiIlZmLeDDJOmY5pCMAIQOZDwaqCN78Mqly9B4Zu8p67oRY= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2017 14:54:24.0277 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR15MB1194 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-13_06:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/10/2017 01:09 PM, Tahsin Erdogan wrote: > When WB_registered flag is not set, wb_queue_work() skips queuing the > work, but does not perform the necessary clean up. In particular, if > work->auto_free is true, it should free the memory. > > The leak condition can be reprouced by following these steps: > > mount /dev/sdb /mnt/sdb > /* In qemu console: device_del sdb */ > umount /dev/sdb > > Above will result in a wb_queue_work() call on an unregistered wb and > thus leak memory. Added for 4.11, thanks Tahsin. -- Jens Axboe