From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934562AbbCPWaI (ORCPT ); Mon, 16 Mar 2015 18:30:08 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:65203 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S932232AbbCPWaG (ORCPT ); Mon, 16 Mar 2015 18:30:06 -0400 From: "Rafael J. Wysocki" To: Valentina-Camelia Bojan Cc: lenb@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] include/linux: fix checkpatch issues Date: Mon, 16 Mar 2015 23:53:57 +0100 Message-ID: <2201843.AvYkyS9n8n@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/3.19.0+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1426294744-31382-1-git-send-email-bojan.valentinacamelia@gmail.com> References: <1426294744-31382-1-git-send-email-bojan.valentinacamelia@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday, March 14, 2015 02:59:04 AM Valentina-Camelia Bojan wrote: > Fix checkpatch issues of the following type: > * ERROR: "foo * bar" should be "foo *bar" > * WARNING: space prohibited between function name and open parenthesis '(' > > Signed-off-by: Valentina-Camelia Bojan checkpatch.pl is for *new* *patches* and not for the existing code. And this is not helpful. Not applied. > --- > include/linux/acpi.h | 34 +++++++++++++++++----------------- > 1 file changed, 17 insertions(+), 17 deletions(-) > > diff --git a/include/linux/acpi.h b/include/linux/acpi.h > index 24c7aa8..2f16a08 100644 > --- a/include/linux/acpi.h > +++ b/include/linux/acpi.h > @@ -115,15 +115,15 @@ static inline void acpi_initrd_override(void *data, size_t size) > (!entry) || (unsigned long)entry + sizeof(*entry) > end || \ > ((struct acpi_subtable_header *)entry)->length < sizeof(*entry)) > > -char * __acpi_map_table (unsigned long phys_addr, unsigned long size); > +char *__acpi_map_table(unsigned long phys_addr, unsigned long size); > void __acpi_unmap_table(char *map, unsigned long size); > int early_acpi_boot_init(void); > -int acpi_boot_init (void); > -void acpi_boot_table_init (void); > -int acpi_mps_check (void); > -int acpi_numa_init (void); > +int acpi_boot_init(void); > +void acpi_boot_table_init(void); > +int acpi_mps_check(void); > +int acpi_numa_init(void); > > -int acpi_table_init (void); > +int acpi_table_init(void); > int acpi_table_parse(char *id, acpi_tbl_table_handler handler); > int __init acpi_parse_entries(char *id, unsigned long table_size, > acpi_tbl_entry_handler handler, > @@ -136,14 +136,14 @@ int __init acpi_table_parse_entries(char *id, unsigned long table_size, > int acpi_table_parse_madt(enum acpi_madt_type id, > acpi_tbl_entry_handler handler, > unsigned int max_entries); > -int acpi_parse_mcfg (struct acpi_table_header *header); > -void acpi_table_print_madt_entry (struct acpi_subtable_header *madt); > +int acpi_parse_mcfg(struct acpi_table_header *header); > +void acpi_table_print_madt_entry(struct acpi_subtable_header *madt); > > /* the following four functions are architecture-dependent */ > -void acpi_numa_slit_init (struct acpi_table_slit *slit); > -void acpi_numa_processor_affinity_init (struct acpi_srat_cpu_affinity *pa); > +void acpi_numa_slit_init(struct acpi_table_slit *slit); > +void acpi_numa_processor_affinity_init(struct acpi_srat_cpu_affinity *pa); > void acpi_numa_x2apic_affinity_init(struct acpi_srat_x2apic_cpu_affinity *pa); > -int acpi_numa_memory_affinity_init (struct acpi_srat_mem_affinity *ma); > +int acpi_numa_memory_affinity_init(struct acpi_srat_mem_affinity *ma); > void acpi_numa_arch_fixup(void); > > #ifdef CONFIG_ACPI_HOTPLUG_CPU > @@ -166,9 +166,9 @@ extern u32 acpi_irq_not_handled; > extern int sbf_port; > extern unsigned long acpi_realmode_flags; > > -int acpi_register_gsi (struct device *dev, u32 gsi, int triggering, int polarity); > -int acpi_gsi_to_irq (u32 gsi, unsigned int *irq); > -int acpi_isa_irq_to_gsi (unsigned isa_irq, u32 *gsi); > +int acpi_register_gsi(struct device *dev, u32 gsi, int triggering, int polarity); > +int acpi_gsi_to_irq(u32 gsi, unsigned int *irq); > +int acpi_isa_irq_to_gsi(unsigned isa_irq, u32 *gsi); > > #ifdef CONFIG_X86_IO_APIC > extern int acpi_get_override_irq(u32 gsi, int *trigger, int *polarity); > @@ -180,14 +180,14 @@ extern int acpi_get_override_irq(u32 gsi, int *trigger, int *polarity); > * If this matches the last registration, any IRQ resources for gsi > * are freed. > */ > -void acpi_unregister_gsi (u32 gsi); > +void acpi_unregister_gsi(u32 gsi); > > struct pci_dev; > > -int acpi_pci_irq_enable (struct pci_dev *dev); > +int acpi_pci_irq_enable(struct pci_dev *dev); > void acpi_penalize_isa_irq(int irq, int active); > > -void acpi_pci_irq_disable (struct pci_dev *dev); > +void acpi_pci_irq_disable(struct pci_dev *dev); > > extern int ec_read(u8 addr, u8 *val); > extern int ec_write(u8 addr, u8 val); > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.