From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AC0E2EC0BC for ; Tue, 2 Sep 2025 09:42:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756806162; cv=none; b=iZvqaP0vxjY9z1z4pe0/uy/rgKaFx8fm1pGGEjD2DXyavPHrCjcMmlAag2+rhxxzCwY6XC4zICMJQzMvU9SuwGQZKpSj5ysaOYWIkxHKYXD3BU5KMvLR0a0iSA2kKblbTWgNqMEVNb1UYTWFitFR4Pen7IZbX/Z+BodD2nRf+Ro= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756806162; c=relaxed/simple; bh=i4FWrMpTncOFRXoqXlabsDTohw1HlWD08a2XpGq8Mr4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RfdXP+Jwkn4HqJG5+pI26Bjqa2FXznh26b17oPRBTeQVei9OE+fsNk/AcOuWoAK3Us/CIljoJSC1loHv7gHQXcee8D8CywpVurqZBJX2phu9Zv/O8o6SfUzTwlyNoa3+854l6zzdR3CXgbN5VqZUJ3XFMKcTlgdMxsN/kUie04k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=b4zIyj2i; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="b4zIyj2i" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756806158; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=asWSuLH6iU8nN8yxFqi4dFvgrrSedS75Z/J4pSraBcc=; b=b4zIyj2ibXFJFmUasJvB7lqsCsetoCx++vY7QaL9cpdCeJJB3ATfnEj/OtaWlJk/yYaEby yaUUXWCkHZM5ff9nnA6vSVNjpQY3JVgg+rtKhwURZc4p+JLZjdVeRLLCSd5ciwALhnUxii nup3aPAFJiprBKQu9rUvlWxBZFAWZ3g= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-204-4c9Ee6cRMk-lMQzMI7VcGw-1; Tue, 02 Sep 2025 05:42:36 -0400 X-MC-Unique: 4c9Ee6cRMk-lMQzMI7VcGw-1 X-Mimecast-MFC-AGG-ID: 4c9Ee6cRMk-lMQzMI7VcGw_1756806155 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-45b7d84d8a0so13615435e9.1 for ; Tue, 02 Sep 2025 02:42:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756806155; x=1757410955; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=asWSuLH6iU8nN8yxFqi4dFvgrrSedS75Z/J4pSraBcc=; b=mkAdb91wjPyd/ucrom/hP3tZSbSO8/yXHzKH38LXujShNU2ndOYbPZe6PUX7Kfw2ab rsB+f7yCHG4/KnCz9xkJ43B7SgeKEUzWDpSZ7Q4CgevfxUteO9sh7sZtbJPM4pMDvplT YsenkbROo5f931n6bwieIIODvtMP3ewAiAEGCZabaoOowIjhoI1JU7jKGjRoePOOShm1 7dF592P92GXs7wkP4vbPIkkevCEty+OcdMltShsCysBsxYcjNzQzIIyUga0Y5uvcDFIM u8fjhP4axe2C5MI9qX3Tg5SnXlIg0gwu//oDDVAtgt8rNqO4wJMbwABIUzOaVnwX9zvT iQBg== X-Forwarded-Encrypted: i=1; AJvYcCVweTUeJSKPNrlvmNvZW77ftX3zLv9tmqrgQcz/64U1StAOpY4jBxGS59SKMyEvaUHkQrGvdX7iuDpFIl0=@vger.kernel.org X-Gm-Message-State: AOJu0YwTwiJC1Vea09iMtuph2co/9I3SpRWy033HsvGW39BfD+Tjw3hF r4rGyGmeywhRyVgk0RXo/8dWwx2/SbGfKX4JD8yOA8hbiu8fJsTFl9uJYddG3aGap8X77Ew11ch wyYPlsCvh1yRA3RkK66uI+gGcK8tYw7/+cLocXRmA42V6klBmDaJ0gn5xrAuMzw2+wA== X-Gm-Gg: ASbGncsd13oazHmQUZGiOrB+LrjuBNS7wWTDk9WRb3ZagfsDncCHQxo6xCXA6NdrWIb kve9h7OUCr59PyO/hVmgv2h5lrL6wHmi6vlTXvF16HDzdWf0oVgtstbTiBmDy+wKLky+9bdBGCt 5NNQdaIWNq5K2/9DCtAYhKZZLjRcZl0bcZzVsJK92f5ztEu6zTx0k4ufPGKq3Kcftg2srlHNy1U Yn3h49w7zexjdN3+X98y8yGRWQkJAOXeJ0tBQnCzjwSituuOku6Ko+IcRwlHWntmJwiSEUtyfc5 gBZPuxkZXT+nJtoiCr1Rlw70eKkPf/LV1sPlKqG8ahNYqPnLCpnh81DRtpxqN0x+v5B5ryuO/On 88dh/bIgaYzCwslvxaMjLfdrVh4RgfhUEWusTwVbxvr/df0yMzDZqSxBcEmighv9tBxk= X-Received: by 2002:a05:600c:1ca4:b0:43c:ec4c:25b4 with SMTP id 5b1f17b1804b1-45b8554e2ffmr100852765e9.10.1756806154851; Tue, 02 Sep 2025 02:42:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEDiNU8UZPL8aTl3qS6g7/9CMF4yIxtcwFaCcDzAuhGVy5bNnLkv/vvSAEHWB2EXNvzk4IR6w== X-Received: by 2002:a05:600c:1ca4:b0:43c:ec4c:25b4 with SMTP id 5b1f17b1804b1-45b8554e2ffmr100852105e9.10.1756806154215; Tue, 02 Sep 2025 02:42:34 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1f:3f00:731a:f5e5:774e:d40c? (p200300d82f1f3f00731af5e5774ed40c.dip0.t-ipconnect.de. [2003:d8:2f1f:3f00:731a:f5e5:774e:d40c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45b8acbe982sm57017205e9.6.2025.09.02.02.42.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Sep 2025 02:42:33 -0700 (PDT) Message-ID: <22019944-2ef2-4463-9b3f-23c9e7c70b2f@redhat.com> Date: Tue, 2 Sep 2025 11:42:30 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 26/37] drm/i915/gem: drop nth_page() usage within SG entry To: Tvrtko Ursulin , linux-kernel@vger.kernel.org Cc: Lorenzo Stoakes , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , Simona Vetter , Alexander Potapenko , Andrew Morton , Brendan Jackman , Christoph Lameter , Dennis Zhou , Dmitry Vyukov , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, iommu@lists.linux.dev, io-uring@vger.kernel.org, Jason Gunthorpe , Jens Axboe , Johannes Weiner , John Hubbard , kasan-dev@googlegroups.com, kvm@vger.kernel.org, "Liam R. Howlett" , Linus Torvalds , linux-arm-kernel@axis.com, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-ide@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mips@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, Marco Elver , Marek Szyprowski , Michal Hocko , Mike Rapoport , Muchun Song , netdev@vger.kernel.org, Oscar Salvador , Peter Xu , Robin Murphy , Suren Baghdasaryan , Tejun Heo , virtualization@lists.linux.dev, Vlastimil Babka , wireguard@lists.zx2c4.com, x86@kernel.org, Zi Yan References: <20250901150359.867252-1-david@redhat.com> <20250901150359.867252-27-david@redhat.com> <4bbf5590-7591-4dfc-a23e-0bda6cb31a80@ursulin.net> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <4bbf5590-7591-4dfc-a23e-0bda6cb31a80@ursulin.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 02.09.25 11:22, Tvrtko Ursulin wrote: > > On 01/09/2025 16:03, David Hildenbrand wrote: >> It's no longer required to use nth_page() when iterating pages within a >> single SG entry, so let's drop the nth_page() usage. >> >> Reviewed-by: Lorenzo Stoakes >> Cc: Jani Nikula >> Cc: Joonas Lahtinen >> Cc: Rodrigo Vivi >> Cc: Tvrtko Ursulin >> Cc: David Airlie >> Cc: Simona Vetter >> Signed-off-by: David Hildenbrand >> --- >> drivers/gpu/drm/i915/gem/i915_gem_pages.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_pages.c b/drivers/gpu/drm/i915/gem/i915_gem_pages.c >> index c16a57160b262..031d7acc16142 100644 >> --- a/drivers/gpu/drm/i915/gem/i915_gem_pages.c >> +++ b/drivers/gpu/drm/i915/gem/i915_gem_pages.c >> @@ -779,7 +779,7 @@ __i915_gem_object_get_page(struct drm_i915_gem_object *obj, pgoff_t n) >> GEM_BUG_ON(!i915_gem_object_has_struct_page(obj)); >> >> sg = i915_gem_object_get_sg(obj, n, &offset); >> - return nth_page(sg_page(sg), offset); >> + return sg_page(sg) + offset; >> } >> >> /* Like i915_gem_object_get_page(), but mark the returned page dirty */ > > LGTM. If you want an ack to merge via a tree other than i915 you have > it. I suspect it might be easier to coordinate like that. Yeah, it would be best to route all of that through the MM tree. Thanks! -- Cheers David / dhildenb