From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936284AbcKQO2a (ORCPT ); Thu, 17 Nov 2016 09:28:30 -0500 Received: from mout.kundenserver.de ([217.72.192.73]:61381 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933111AbcKQO21 (ORCPT ); Thu, 17 Nov 2016 09:28:27 -0500 From: Arnd Bergmann To: linuxppc-dev@lists.ozlabs.org Cc: Sudeep Holla , linux-arm-kernel@lists.infradead.org, linux-mips@linux-mips.org, devicetree@vger.kernel.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Rob Herring Subject: Re: [RFC PATCH] of: base: add support to get machine model name Date: Thu, 17 Nov 2016 15:13:53 +0100 Message-ID: <2202339.ajrKjCY7Ro@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <622ddcbc-69b9-98f2-51f3-e256764ecb93@arm.com> References: <1479383450-19183-1-git-send-email-sudeep.holla@arm.com> <3670336.mMHByOpDl4@wuerfel> <622ddcbc-69b9-98f2-51f3-e256764ecb93@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:uRXQoiLkT7EZ5pCzdMETDRlykeqWTqoYcHKePpkM/FVbXlwqhAr sGEe12EOK8ep7B+9oSQvLb8IDNuNvbYkOL6ChpMl1v0FZm4Fr4X+0Syl/JqeVRZHmlvz2NJ 7ky9t7KaT/0qFXOPZH2kzvJoG1pXTZbCqKNupB/AjAwKNYxbInLt7H3cxvf7OktXP5kNm8Y 0axhKVsN+wpDQkO5kMb8Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:8qWte4eICm8=:sXhvYwpLQkPV9E2Flz9KKT LeT7NVU+FqanCm0dadiWpMIteo5HEAAsK2bQBm9B7aopYPMJw1GFy6TxSRMr+S/9b5Zp9kmhF ptUNbO+jrq75DbkZeqUJ0UwcR1+YRrfsZU4WVdExNKuas2d3kIL1KwPjdj/tQ2ceB/AIjS1ow 54Q/b1/BONbKamR8jB0C6SNtmnnwLOexK1Qi47a0su2CgJv4pllbn4rdYYNZ+XqU/C8NF7jP2 UJwdecozDhkUlfwLxbHA2YWwtfoL7g9D+mc+7JYfa9rGWIrIeK6p8XI9YHtVhEEZfqgp7BgtO 4n4fd5PhXDjRI66CmVEJtDHPztANwejWU0blfaS9ZPw7eyMwZI7H4Nsd0trdZ+EVQAZ4XTbLt LLVVXtAiZGzeOIFfazgWCs7PF0GAGohLfqvYOcLFGMnX0zclWrNZNov5nArxvRtfqSaK6O0Pc xoaw59ffDjyy517O2WHxNpmbtRoHdpguxYv+3Mme2MTdTveZU+eAv/Zj9mfBaCtpbLQhnr/ZO hIKEErYLlkdyp+BIvxWBTSUULTn2EY+bwgImxGOl5fYTJ3jUZrogCR3mMVCuhyiuBGP5mZK5/ 5ibhN1w5NOsd3W/FZLLG/ZEgHGAedDm80TBNjzmU8W/qZrvgqqDheRB6zlAe21WZDf38i4CWO szz8VDmr3pEmHRLrgBQtaBX40zbugkYnI4n0XQc+gn3yPKzwMfwEZR9mqU6ve1aMRx/eym83X 7JY7NR6OK+JBaZ+2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, November 17, 2016 2:08:30 PM CET Sudeep Holla wrote: > On 17/11/16 13:50, Arnd Bergmann wrote: > > On Thursday, November 17, 2016 11:50:50 AM CET Sudeep Holla wrote: > >> Currently platforms/drivers needing to get the machine model name are > >> replicating the same snippet of code. In some case, the OF reference > >> counting is either missing or incorrect. > >> > >> This patch adds support to read the machine model name either using > >> the "model" or the "compatible" property in the device tree root node. > >> > >> Signed-off-by: Sudeep Holla > > > > I like the idea. One small comment: > > > > Thanks. I prefer it as single patch but it can't be applied to any tree. > Any suggestions on handling this patch to fix the warning in -next ? > The patch that causes the warning is currently in the mmc tree, and I don't think it would be good to have your entire patch in there too. It's probably best to just fix the warning there now by adding another open-coded copy of that function, and then apply your patch on top for v4.11. Arnd