From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69C4D3B42ED for ; Tue, 13 Oct 2026 08:14:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791879248; cv=none; b=AK5R1R6Nga9WSjiIiSPAj6qUdYqHrZ0zLJRyyI84ga0btQfidyb56ZBElnmpEimcHrWMKKySot1+mFvcFFby3Sz4VqIdqie9i/m8RpTHsosUqVwAOMWNhIVb+HRAMVU8bUelyDi6o6APdH5beRYMfqFJPeshBXbHl/0mz2wT/2w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791879248; c=relaxed/simple; bh=WwRtsX+o3Yc1BZpZy6ImBzyNEsrrxZVX7aPBj0iBNNw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=u+k5U913lyeg8wXJVfh2xXP8KnsgQeCmMR2dl57x5mna8BoqJrTOfjgrPpX7gJKStsSKPKwYWX+hff9YgfrfdKVgkrxKC2mXjD/+zXRVoRaZB8iCcZQR+MCyi0qT401CNCvshRJYZWKmCqNVkJ2JJ+dHHEf8ZdRZ2u3UZfaOz2c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=ImBbR5sT; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="ImBbR5sT" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4a16aaf2067so31901645e9.0 for ; Tue, 13 Oct 2026 01:14:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1791879245; x=1792484045; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=qE8viVfc7wSzykdGhKjE2C5YJHAozDefAUnUohB6XA4=; b=ImBbR5sTwRM4cizz08l5eBbwMoNWIKi8p3hYox+xpo2rKz4P7vWuh8n5yyCaJIOHP8 pe5lPuhmVc7uSK759NRRnpRAiijkIjed8Au8i6P/kl1OnPsPfoXYQUfb8Fsn15f1q/na mvM48HMTWxn/WQnZMuYn3TTrpdQQy771sq0B+DNLZkrk/7mzs8c3rkWC46rikUigJOdl Vco9M+pNyRurGfmYqmztAZbxokRThCXdUnV3CS1f2pdVsLBSbwz7/xcXaAWihiGbEDyu 3hAVJOGpgRtfnz3Is/3wuJG27d+/64Bgu/vSvIZX/PH+J29jgAsxKq+OUqrFSO1O9298 7Wuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791879245; x=1792484045; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qE8viVfc7wSzykdGhKjE2C5YJHAozDefAUnUohB6XA4=; b=EAthuZ9NBW5duyequMZcAerjKLGu9afUdwN5paldtkInURJDRMuN4iV/SemzL5HENV WdHLt2B12vj48ZeaXCJevEIA6AXfch06BlMi5NxC92Da+UoXkjfprQWzbV8Q0BmiYnDx yLiQdssk8FWfAyozZh6Wco964pjywtHODFSF9ixqNFm7lo7iaGWvHzifqowWkPrYmCsU XUBmkd1rfHlhcGQoAfg3Y/kbTGrVyhskZMWQDRqslfZCdyl4dawMW+QyYSzfw4NcWOeE 8WKwif+mE2nmc5/m/DDKkYDcA8nH03UuSthzq+NnA/fsZmuQ9XYi/Ppqiygts1B/B9kC hoLg== X-Forwarded-Encrypted: i=1; AKwUvBwZ3eY16guPWeB+KhePQpZGMK0UGrkW/G39szcnp8Asl/ntbziM4hdE/Om+h/wJ+FB/hePWUfHuYx1wl3A=@vger.kernel.org X-Gm-Message-State: AFq9FYINQV8jcqsmrU3UVfn94oNtQrCQSD6Z9Ol9v5uBdW+3RQyUod8m iB/l2CCrC/2idzF0FhN7PgGRU51YtSbJqhqaxrmGqM0WPwAOH+7TwLRtpmOeeJvcIl4= X-Gm-Gg: AYBFou3Tk+AAHKofR/7eZTJ3ZESyT60X76coi+MZzgN7bba2At8zKveD43AEekUy4KL 2wxzeWJiuWsUQlw16EXosbBRcINbj7RlrZAASH96RoS90YBEhwDN7AoBNOW6SJH3CgayXLRPfYV 5Qpdbpt+mUxPD69rS7DX9HeJ5lN03KoSKaDO9XZyABk4rH98UC3EHRwIk0k13PRD8H1JIHzLMY0 DZpJER35X89O42dmU0h0PIBxf3343mO0nIVzzd7m7Nzq7yI8vKzXoQEDcNemL8alQa4QF9hndNh pUJyAYZTkRTmG2qWyh93fCMI8KVtUWez2HWuNCDfz0mus7baG1QFr+IXN8Vg5Q1QmjoomcFsAMJ HAFWx2WGP806I4wjiNg/oLv9VO6EymwU8BOyhsA/GYxnUfNbZ0AOfzb/u4zyk3sY1eFDbwT3IRR 56c9B8bYXvXTqBkzNrpsXdOqTOO2L9e85LuXzh/ia+2ZRKpqa0tcX03Zou41ex9MKgjNdznN/3c ZPhedUiRAx00/Piw16jUs6avnlxC+kWTIrAxDvl X-Received: by 2002:a05:600c:8106:b0:4a0:c02:938c with SMTP id 5b1f17b1804b1-4a18e4d683dmr203452395e9.25.1791879244612; Tue, 13 Oct 2026 01:14:04 -0700 (PDT) Received: from ?IPV6:2001:a61:13f5:2701:b3a3:b9f5:f3dd:ee85? ([2001:a61:13f5:2701:b3a3:b9f5:f3dd:ee85]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a1972eaed8sm233812305e9.1.2026.10.13.01.14.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Oct 2026 01:14:03 -0700 (PDT) Message-ID: <2207cca2-89e7-4694-b903-aca15cec1edd@suse.com> Date: Tue, 13 Oct 2026 10:14:02 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [usb-storage] [PATCH v5 1/2] scsi: sd: mark disk dead on surprise host removal to avoid I/O hang To: =?UTF-8?B?6IOh6L+e5Yuk?= , "James E.J. Bottomley" , "Martin K. Petersen" , Bart Van Assche , Greg Kroah-Hartman , Alan Stern Cc: Christoph Hellwig , Jens Axboe , Hannes Reinecke , Mike Christie , Damien Le Moal , John Garry , Shin'ichiro Kawasaki , "linux-scsi@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-block@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "usb-storage@lists.one-eyed-alien.net" , "stable@vger.kernel.org" References: Content-Language: en-US From: Oliver Neukum In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 09.10.26 13:29, '胡连勤' via USB Mass Storage on Linux wrote: > index a1b21ea14e54..98f861fb7e80 100644 > --- a/drivers/scsi/sd.c > +++ b/drivers/scsi/sd.c > @@ -4272,6 +4272,10 @@ static void sd_remove(struct scsi_device *sdp) > > scsi_autopm_get_device(sdkp->device); Here you resume the device > + /* Device is gone; avoid sync_filesystem() hang in del_gendisk(). */ > + if (sdkp->device->host->surprise_removal) > + blk_mark_disk_dead(sdkp->disk); Here you check whether it exists. That seems a bit inverted. What is the point of resuming a device that has gone away? Regards Oliver