From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15492CA9EBD for ; Fri, 25 Oct 2019 19:05:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E6BC321D7F for ; Fri, 25 Oct 2019 19:05:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726319AbfJYTFt (ORCPT ); Fri, 25 Oct 2019 15:05:49 -0400 Received: from smtprelay0017.hostedemail.com ([216.40.44.17]:50696 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725847AbfJYTFt (ORCPT ); Fri, 25 Oct 2019 15:05:49 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay03.hostedemail.com (Postfix) with ESMTP id AE4838384364; Fri, 25 Oct 2019 19:05:47 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: food96_326534c4f0a3f X-Filterd-Recvd-Size: 2493 Received: from XPS-9350.home (unknown [47.151.135.224]) (Authenticated sender: joe@perches.com) by omf16.hostedemail.com (Postfix) with ESMTPA; Fri, 25 Oct 2019 19:05:46 +0000 (UTC) Message-ID: <220d8f2c1b299d2e71fdcf50b98286aae5b0c6f2.camel@perches.com> Subject: Re: [PATCH 3.16 47/47] KVM: x86/vPMU: refine kvm_pmu err msg when event creation failed From: Joe Perches To: Ben Hutchings , linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: akpm@linux-foundation.org, Denis Kirjanov , Like Xu , Paolo Bonzini Date: Fri, 25 Oct 2019 12:05:43 -0700 In-Reply-To: References: Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2019-10-25 at 19:03 +0100, Ben Hutchings wrote: > 3.16.76-rc1 review patch. If anyone has any objections, please let me know. This seems more like an enhancement than a bug fix. Is this really the type of patch that is appropriate for stable? > ------------------ > > From: Like Xu > > commit 6fc3977ccc5d3c22e851f2dce2d3ce2a0a843842 upstream. > > If a perf_event creation fails due to any reason of the host perf > subsystem, it has no chance to log the corresponding event for guest > which may cause abnormal sampling data in guest result. In debug mode, > this message helps to understand the state of vPMC and we may not > limit the number of occurrences but not in a spamming style. > > Suggested-by: Joe Perches > Signed-off-by: Like Xu > Signed-off-by: Paolo Bonzini > [bwh: Backported to 3.16: adjust context] > Signed-off-by: Ben Hutchings > --- > arch/x86/kvm/pmu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- a/arch/x86/kvm/pmu.c > +++ b/arch/x86/kvm/pmu.c > @@ -187,8 +187,8 @@ static void reprogram_counter(struct kvm > intr ? kvm_perf_overflow_intr : > kvm_perf_overflow, pmc); > if (IS_ERR(event)) { > - printk_once("kvm: pmu event creation failed %ld\n", > - PTR_ERR(event)); > + pr_debug_ratelimited("kvm_pmu: event creation failed %ld for pmc->idx = %d\n", > + PTR_ERR(event), pmc->idx); > return; > } > >