From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90A6A378838 for ; Mon, 30 Mar 2026 04:40:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774845628; cv=none; b=XQ3/yb0Ivv4JeeAQtjgWhVzwpyiTxC4FNS+jJzqf8NDxAWwdwqB0f7xdwrqqcowOjbOmXqTF5HSYRSlEeu+KdtYRhjY5Wz/xSmd738n3E5sdW1x5QiaoM7fq3YmbXMIaKo3f10ugyqlW+Ad/TFqXZ1qNyEeVZRAhnRGxUMmvFBc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774845628; c=relaxed/simple; bh=R159vo/2gogafejfPEcTUgl2FWXZNcSUzLIw/hjie44=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GpkRkwjrLZRabp7FUI8dsbikVjK2Wg0/Hs6eBti768aBw0ooLqyWuTjFoBAytBHcXCVaz8f6q+FhI498x3BFKceyHNPMLSFguEd8mZmKkySKdGm9goW0ss02p87/d69IXapFQMcLag9zIZ7Os/WhSD8E2v7PxxuBateoRj7/Pl0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pNplJOve; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NTtgv2tC; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pNplJOve"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NTtgv2tC" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62U3nNL73931907 for ; Mon, 30 Mar 2026 04:40:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jxIrz6lqgl8INlv2CG6vKfWIRSC2AzWItLIRoJEu4xc=; b=pNplJOveWazggGEJ 03skUawdUr3uoJLHDAwXeBMGCB+TMSFFVg5Cb65AtwXFEg30aTKljlLSnJN4b/mZ 7/z38cU0NCt/VmQ34HD7RmMudgg641UqDkGrpkKsY6UyxCL+A3DBKqyc8JHolze+ MWFcIGqvSJwpUyEg/1UhlQZJIA+Q4eUsxQFNIeOEV+MdotFMw+23fzrffi5a8Cc/ D9rC0NdqrxGEthHKUhpZvCaCURZF2HikjUFvcDrWKVyn8+PNS1JDkARTbJxT2szB ocY3Pv4IdoS3m9I8p1eJUHENCqhqP6UxgN+jfbgqXMuynGt6LG04JTDwHxeGjgT8 otY1Bw== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d64pdcr5f-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 30 Mar 2026 04:40:26 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-82c7a84a43eso9250257b3a.0 for ; Sun, 29 Mar 2026 21:40:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774845626; x=1775450426; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jxIrz6lqgl8INlv2CG6vKfWIRSC2AzWItLIRoJEu4xc=; b=NTtgv2tC70f99ZO5yxHrZCKxjxiZm8mvVeelTQ7NRLGBc6GPST5bJqcCv7S2Jesjyb PQYIbgTgk3QyU8zn3remSZz5V9Zq2Y9DM0TvqgZFSYGeSq029XL2LNQEmfxntPAhMggQ 23hZJdrz8YiLmtJfKJ2bpaOSRRI2kM58zq+O6SCQt4jtwMgy4WJ90nZwkqwcpjDfFLeQ k4evPfTz50ZqkhxZevM/LNtcptQLfzX2cF8WXduclSF3ez+DJcNcTqFQ2knCbLKHc3za mQ3QxGnX8rFlxtpPPixSO1g9ZLhQqRAQBpu1hsbYDKXD0u1QmEEuLFTbuhH+wR9kvxy6 aAYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774845626; x=1775450426; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jxIrz6lqgl8INlv2CG6vKfWIRSC2AzWItLIRoJEu4xc=; b=oYP5dMlVnKfynIYY97t9qvSRB7/RdrfLlTMWahs3teVC3td1zShj62Ra6ZjaV2JhwE 2OlzC9f9vLrMM+0G/Cs3LubZo5otT1o2Vb8Sga0iBA8WeGXA5IVYydMaJe/AqZV3yYyU 5vCacotm5xfQzytp7ZW2TpNbv+qzgdeO8CKMagmUXaSAHf0aPDZVP/E7TTINNyKpqUm2 3DK6/5MKkRTCEu881hSpycuGz7kqny31U/QZtZFbR69mMVgHPxFtPZELuXA5nMDziqH8 8Jr+UJawTvR/gb5BL6La2B9bZ6ZafvZp0hrGVwiCkgcrGA5N7w1jnxmb5ykikhlj72m/ 8Ceg== X-Forwarded-Encrypted: i=1; AJvYcCXWVdjC/fQS0yvgGuFzl40sHeQ/LBpClByGd2TX381i/uanXo4DPv98gwA7FYJZXBQiboc+WXB+pamraPA=@vger.kernel.org X-Gm-Message-State: AOJu0Yzd5RDpfvr/ZUqwNu7rI0IBTfW2IKS6m5zqKP3NPkpf+77CSsoS yMe/QAf3OrL3AvpXcT/HpsiLIrv/FiEH5vPO3mCP/U3g/Y1bXGBTFoD0AYAslB+tCTF6GnZXv+Q xDAmtBED7gNmB9Gsy91Y4t7DH4ySayAyWQj3gRpzLe3qUqoKnEJnT4Yct4J/S+oJWAXuNS/usjr M= X-Gm-Gg: ATEYQzxv9CU5Lr8fc/nNwPevX+xY+YfHbQaYcrqunqnt/n7LqTan/pm+xu75VdWHFKC tmhBXfqUVwkyBFtPiYu9+nBdHtMulQksiMKE6hBSGCN7O+hlucuSlZbA7xnT+h/BVNEizj3hOBm 7x10EEyn0QIPQwAoO+VHCxeaGhjEM8XJKXKeeSgH7mhtw05ZDsiBbp57w8o34R07EtuJO4oid74 b1yUQ3wM0onitYMvPhdQbAjhnr/EjJz1VbSzfoeJtm8Hn2NLDAy2UKpq03tAm+P9mDhfGvVtALC +1ANvwwjsHRaBXV+1Vllg7E8n9+3zBYl/zvS6yKC7vwd1s13TxNjf9DT027VzODnV8b2V4NFknw T+PYvQh+eX/nFvxHTZSzehxo1qSys00oqfbQKnjldewY4at5OZVkUqQ== X-Received: by 2002:a05:6a00:4c0e:b0:827:370b:2695 with SMTP id d2e1a72fcca58-82c95eb8cc1mr10649766b3a.29.1774845626197; Sun, 29 Mar 2026 21:40:26 -0700 (PDT) X-Received: by 2002:a05:6a00:4c0e:b0:827:370b:2695 with SMTP id d2e1a72fcca58-82c95eb8cc1mr10649745b3a.29.1774845625706; Sun, 29 Mar 2026 21:40:25 -0700 (PDT) Received: from [10.218.4.221] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca843b20csm6926179b3a.8.2026.03.29.21.40.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 29 Mar 2026 21:40:25 -0700 (PDT) Message-ID: <2212d12a-8ce6-40ab-8bc3-ab8e3b9111b2@oss.qualcomm.com> Date: Mon, 30 Mar 2026 10:10:20 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 3/6] arm64: dts: qcom: talos: Add QSPI support To: Krzysztof Kozlowski Cc: Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260324-spi-nor-v1-0-3efe59c1c119@oss.qualcomm.com> <20260324-spi-nor-v1-3-3efe59c1c119@oss.qualcomm.com> <20260325-dancing-macho-coyote-deaa55@quoll> Content-Language: en-US From: Viken Dadhaniya In-Reply-To: <20260325-dancing-macho-coyote-deaa55@quoll> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: PBzeVpETPgWBSBFeVDX1vycG_ZKF_b6B X-Authority-Analysis: v=2.4 cv=UZpciaSN c=1 sm=1 tr=0 ts=69c9feba cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=dPh6dh2MmqIcn93rYEAA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-GUID: PBzeVpETPgWBSBFeVDX1vycG_ZKF_b6B X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMwMDAzMyBTYWx0ZWRfX/AC3jGm+J/jA svPbM16OOZnWrz+PxHDNLsWyWH8ZuIGcvU+y3XqK1lCNjxFHZePOpHnGP6X11s0k778EDDnuZkV PCkqnwfN3fkvNrC6XXD6mwGCQlnpOAqgcip91D/teICbxzkNBLD3kmP2xFvcMKM0qXlPrK3Dulf 9s35aSQzfDC8hPV47a0ipuOldF0C4LHqQaUSPTxIrHcSqiYgc7QCHdRbgI803eivWZB3JVetQ0k Fkg8WqXyEP2yaVMxdeGZGzwy0zEzUQM04M9bX+5Hks5V7FVtTMw/VBu59jZm8pawKRBaiE4ojsR DmnkbsKzlX6QsOMuDLZoz79c/K/Qjs1SBgMBdl4eHLCWMUUXZHvYXWYwhXM9moo9RU1P6CMOpey Apm0ahOz8pZakNoLtCI43e/Gz4BthLGBOU9ohUNHpTPqxmr9xKcz9MKiGfmGvHw2tTiruDNOtsL TXB+1beUJJAPyrQt1Yg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-29_05,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 adultscore=0 spamscore=0 malwarescore=0 impostorscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603300033 On 3/25/2026 4:43 PM, Krzysztof Kozlowski wrote: > On Tue, Mar 24, 2026 at 06:43:20PM +0530, Viken Dadhaniya wrote: >> The Talos (QCS615) platform includes a QSPI controller used for accessing >> external flash storage. Add the QSPI OPP table, TLMM pinmux entries, and >> the QSPI controller node to enable support for this hardware. >> >> Signed-off-by: Viken Dadhaniya >> --- >> arch/arm64/boot/dts/qcom/talos.dtsi | 80 +++++++++++++++++++++++++++++++++++++ >> 1 file changed, 80 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/talos.dtsi b/arch/arm64/boot/dts/qcom/talos.dtsi >> index 75716b4a58d6..fd727924b8ca 100644 >> --- a/arch/arm64/boot/dts/qcom/talos.dtsi >> +++ b/arch/arm64/boot/dts/qcom/talos.dtsi >> @@ -530,6 +530,25 @@ cdsp_smp2p_in: slave-kernel { >> >> }; >> >> + qspi_opp_table: opp-table-qspi { > > Does device have only one QSPI? Then table goes to device node and > binding needs "opp-table". Yes, it has only one QSPI node. I will add the OPP table inside the node and include it in the binding as well. > > Best regards, > Krzysztof >