From: Vikash Garodia <quic_vgarodia@quicinc.com>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
<stanimir.k.varbanov@gmail.com>, <agross@kernel.org>,
<andersson@kernel.org>, <konrad.dybcio@linaro.org>,
<mchehab@kernel.org>, <hans.verkuil@cisco.com>,
<tfiga@chromium.org>
Cc: <linux-media@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH v2 4/4] venus: hfi_parser: Add check to keep the number of codecs within range
Date: Fri, 11 Aug 2023 11:34:35 +0530 [thread overview]
Message-ID: <2214c31b-eca2-012e-a100-21252a724e7c@quicinc.com> (raw)
In-Reply-To: <fec4a8c7-206f-7af8-4ea9-c919a677bf7e@linaro.org>
On 8/10/2023 5:03 PM, Bryan O'Donoghue wrote:
> On 10/08/2023 03:25, Vikash Garodia wrote:
>> + if (hweight_long(core->dec_codecs) + hweight_long(core->enc_codecs) >
>> MAX_CODEC_NUM)
>> + return;
>> +
>
> Shouldn't this be >= ?
Not needed. Lets take a hypothetical case when core->dec_codecs has initial 16
(0-15) bits set and core->enc_codecs has next 16 bits (16-31) set. The bit count
would be 32. The codec loop after this check would run on caps array index 0-31.
I do not see a possibility for OOB access in this case.
>
> struct hfi_plat_caps caps[MAX_CODEC_NUM];
>
> ---
> bod
>
next prev parent reply other threads:[~2023-08-11 6:04 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 2:25 [PATCH v2 0/4] Venus driver fixes to avoid possible OOB accesses Vikash Garodia
2023-08-10 2:25 ` [PATCH v2 1/4] venus: hfi: add checks to perform sanity on queue pointers Vikash Garodia
2023-08-10 11:24 ` Bryan O'Donoghue
2023-08-11 5:46 ` Vikash Garodia
2023-08-10 2:25 ` [PATCH v2 2/4] venus: hfi: fix the check to handle session buffer requirement Vikash Garodia
2023-08-10 11:26 ` Bryan O'Donoghue
2023-08-10 2:25 ` [PATCH v2 3/4] venus: hfi: add checks to handle capabilities from firmware Vikash Garodia
2023-08-10 11:31 ` Bryan O'Donoghue
2023-08-11 5:54 ` Vikash Garodia
2023-08-11 8:41 ` Bryan O'Donoghue
2023-08-11 8:51 ` Vikash Garodia
2023-08-11 10:39 ` Bryan O'Donoghue
2023-08-11 16:10 ` Vikash Garodia
2023-08-10 2:25 ` [PATCH v2 4/4] venus: hfi_parser: Add check to keep the number of codecs within range Vikash Garodia
2023-08-10 11:33 ` Bryan O'Donoghue
2023-08-11 6:04 ` Vikash Garodia [this message]
2023-08-11 8:42 ` Bryan O'Donoghue
2023-08-11 8:49 ` Vikash Garodia
2023-08-11 10:41 ` Bryan O'Donoghue
2023-08-11 16:02 ` Vikash Garodia
2023-08-11 18:51 ` Bryan O'Donoghue
2023-08-14 6:34 ` Vikash Garodia
2023-08-14 14:15 ` Bryan O'Donoghue
2023-08-29 8:00 ` Vikash Garodia
2023-08-29 11:59 ` Bryan O'Donoghue
2023-08-29 14:06 ` Vikash Garodia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2214c31b-eca2-012e-a100-21252a724e7c@quicinc.com \
--to=quic_vgarodia@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=hans.verkuil@cisco.com \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=stable@vger.kernel.org \
--cc=stanimir.k.varbanov@gmail.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®