From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751905AbdBOMHG (ORCPT ); Wed, 15 Feb 2017 07:07:06 -0500 Received: from mout.gmx.net ([212.227.15.18]:57973 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751412AbdBOMHF (ORCPT ); Wed, 15 Feb 2017 07:07:05 -0500 From: Marc Dietrich To: Arushi Singhal , linux-tegra@vger.kernel.org Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging:nvec:nvec_ps2.c: Preferingkzalloc(sizeof(*ser_dev)...) over kzalloc(sizeof(struct serio)...) Date: Wed, 15 Feb 2017 13:06:56 +0100 Message-ID: <2216261.0XPs8u6SRF@fb07-iapwap2> In-Reply-To: <20170214170120.GA6501@arushi-HP-Pavilion-Notebook> References: <20170214170120.GA6501@arushi-HP-Pavilion-Notebook> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart59499477.p2dvfuOhKM"; micalg="pgp-sha256"; protocol="application/pgp-signature" X-Provags-ID: V03:K0:RHgfk0t2id/j+lp6HzCV2GqD6/Oq3l2voM4tT4kcBz97FRUTGF6 mXkFXso7/FtWCvgrN0KlaM8JM6iYq4AuiIzVbMNdZ+7mzGqypHlWj4lq6YFhuVwsUwSp+5d lwdyZP3IC3pD1FvXeUeyOuK2jaBJods6idpHJib+YuJzeQYV3olLE+wMXwFhiYvMGV3Ml2v 3u9CLn+rcJeY6LW/F/5AQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:oJ8CTEHM1oE=:rIK8FlsHBupa44qYtpeimO wq+aN+Kg8/riJItDvrbIhKgllH8IP3GQIGkfJZdunzTsI/RtztxI/uoNbPgA5yRJcSy5dGD/x 1kjCO9gxgCSDaqvi6z+ayTlbBp3hbh+LLCbk1Jai4YoUzChIizYZzKs8RnHS3Q15pYmxBCKFr Wq4e4EvvfcBM29uhuSZtxvVfEtrkbVmjCyoYFdpIk2x4lcxrW0lZibvNA9vSElhKwbv0nJBF6 aWl8tPT9aDC3eazgzYZb3ZZY/u7nUmjO9ggprcDM5rR4fXnX6E9WQ1Shpd4Yz7rhDuiTb8KKh o0JmiRP4Eg+k+2gJwpDrJX6oz9bMW4lZ0g338SWSw9wMaRYgLR9TbpM5vjiiu6+IXJtltlSm0 XVWq/Hcof82LAajxtAL+YCphJ+vYvN1bd/nk/aKB6vPxowob5risTUD7x1EN9zfD5Qn5T1QQF oPUVYeo8OQ4fRFqxzGcLCwQ9A6Tmda6JqQlwLP/c19lqBHKyPjzxWa/2FGTtGyWTcfvERIme+ vTSHtk9T0FZ0kuGNg+tDvclbR9iqLv2Lnf3sZE1hTqoWlGbtWRSaOR6NZ0vDHm0ygex8RQK+v 75gQSb5BZVjKeOVwJC0NvMkGIjLq9aOQ1hh22dwPDf7ROXjSooKVR98jimRjdvX1P3+7fOHLm YpeTyo6oERTr1JQIRiZDKmqrp9UN4kpKPc/t7/SrRv1ZcEXUTIDPtO4lYmUpRzr9gUg8V6Aq9 +fmU3YD1eQDiDu3TyU5xHwug3y+e7wMcR60oKdBPpe78/o5BO01oSxlWs1s= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nextPart59499477.p2dvfuOhKM Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Am Dienstag, 14. Februar 2017, 22:31:20 CET schrieb Arushi Singhal: > Prefer kzalloc(sizeof(*ser_dev)...) over kzalloc(sizeof(struct > serio)...) as reported by checkpatch.pl. > > Signed-off-by: Arushi Singhal looks like we are in a (make everyone) happy week. Acked-by: Marc Dietrich > --- > drivers/staging/nvec/nvec_ps2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/nvec/nvec_ps2.c > b/drivers/staging/nvec/nvec_ps2.c index 499952c8ef39..3b7bce3ffd19 100644 > --- a/drivers/staging/nvec/nvec_ps2.c > +++ b/drivers/staging/nvec/nvec_ps2.c > @@ -107,7 +107,7 @@ static int nvec_mouse_probe(struct platform_device > *pdev) struct nvec_chip *nvec = dev_get_drvdata(pdev->dev.parent); > struct serio *ser_dev; > > - ser_dev = kzalloc(sizeof(struct serio), GFP_KERNEL); > + ser_dev = kzalloc(sizeof(*ser_dev), GFP_KERNEL); > if (!ser_dev) > return -ENOMEM; --nextPart59499477.p2dvfuOhKM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEySF+t0C8+8jyqfBvrJ5Hf0cUG2gFAlikRGAACgkQrJ5Hf0cU G2hoCQf/RaQfwTH1BD8qMhrFhBnuc/ChvwqGWSzDEXZ7CaDZ5FMcfAaeP/+Joppb fg5Zf/iJVU4MQQVSZG39hDzH2hhXk2BTkxuTAvNdfTZqMJJZ9s1glOyX8CTNNOAb heIG99w35I8tW1JzmsgYLaY7ROXghdg8tc9Hh9v9b+hnaulXjcrixbpDRAlhc47f eLpsP49/97iHaFgL0Zho+LQ1oVCGxbhYDw4eQffMxIWoCmiSiZQk5B8DGe7aGIJe aADkGF+hBkISexm8O93F/RHQAleS9wp4/TNGo6p76SESBDyKAfxQa1WJwpJB9m/v nMZN1Ffge2P3pp74wpnEC+KJxikGww== =7g4d -----END PGP SIGNATURE----- --nextPart59499477.p2dvfuOhKM--