mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Jiang <dave.jiang@intel.com>
To: Li Ming <ming.li@zohomail.com>,
	dave@stgolabs.net, jonathan.cameron@huawei.com,
	alison.schofield@intel.com, vishal.l.verma@intel.com,
	ira.weiny@intel.com, dan.j.williams@intel.com,
	shiju.jose@huawei.com
Cc: andriy.shevchenko@linux.intel.com, linux-cxl@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 0/3] Fix wrong dpa checking in PPR operation
Date: Fri, 11 Jul 2025 09:57:38 -0700	[thread overview]
Message-ID: <221d5666-a860-40c0-8cab-9c8086c1a597@intel.com> (raw)
In-Reply-To: <20250711032357.127355-1-ming.li@zohomail.com>



On 7/10/25 8:23 PM, Li Ming wrote:
> In cxl_do_ppr(), there is a checking to check if a DPA is valid, the
> implementation of the checking is check if the DPA is 0, if yes,
> consider that DPA is valid. the checking is not right, the correct
> implementation is checking if the DPA is in the CXL device DPA range, if
> yes, it is valid.
> 
> The patchset also includes another part implementing a general helper
> function cxl_resource_contains_addr() in cxl core so that cxl drivers
> can use it for all DPA/HPA/SPA availability checking.

applied to cxl/next
bdf2d9fd3a86 cxl/core: Using cxl_resource_contains_addr() to check address availability
03ff65c02559 cxl/edac: Fix wrong dpa checking for PPR operation
5b6031c832c2 cxl/core: Introduce a new helper cxl_resource_contains_addr()

> 
> v6:
> - Fix reviewed-by tag mistake.
> 
> v5:
> - Reverse checkings order in cxl_do_ppr(). (Alison)
> 
> v4:
> - Add cxl_ prefix to resource_contains_addr().	(Andy & Alison)
> - Add impact statement to the commit log of Patch #2. (Alison)
> - Add review tags.
> 
> v3:
> - Move resource_contains_addr() from include/linux/ioport.h to
> cxl/core/hdm.c. (Andy)
> 
> v2:
> - Implement a general helper resource_contains_addr() for DPA/HPA
> resource. (Alison)
> 
> base-commit: d0b3b7b22dfa1f4b515fd3a295b3fd958f9e81af cxl/fixes
> 
> Li Ming (3):
>   cxl/core: Introduce a new helper cxl_resource_contains_addr()
>   cxl/edac: Fix wrong dpa checking for PPR operation
>   cxl/core: Using cxl_resource_contains_addr() to check address
>     availability
> 
>  drivers/cxl/core/core.h   | 1 +
>  drivers/cxl/core/edac.c   | 9 ++++++---
>  drivers/cxl/core/hdm.c    | 7 +++++++
>  drivers/cxl/core/memdev.c | 2 +-
>  drivers/cxl/core/region.c | 6 +++---
>  5 files changed, 18 insertions(+), 7 deletions(-)
> 


      parent reply	other threads:[~2025-07-11 16:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-11  3:23 Li Ming
2025-07-11  3:23 ` [PATCH v6 1/3] cxl/core: Introduce a new helper cxl_resource_contains_addr() Li Ming
2025-07-11 16:20   ` Alison Schofield
2025-07-11 16:37   ` Jonathan Cameron
2025-07-11  3:23 ` [PATCH v6 2/3] cxl/edac: Fix wrong dpa checking for PPR operation Li Ming
2025-07-11 16:38   ` Jonathan Cameron
2025-07-11  3:23 ` [PATCH v6 3/3] cxl/core: Using cxl_resource_contains_addr() to check address availability Li Ming
2025-07-11 16:39   ` Jonathan Cameron
2025-07-11 16:57 ` Dave Jiang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=221d5666-a860-40c0-8cab-9c8086c1a597@intel.com \
    --to=dave.jiang@intel.com \
    --cc=alison.schofield@intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave@stgolabs.net \
    --cc=ira.weiny@intel.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.li@zohomail.com \
    --cc=shiju.jose@huawei.com \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®