From: Gyorgy Jeney <nog.lkml@gmail.com>
To: rmk+serial@arm.linux.org.uk
Cc: linux-serial@vger.kernel.org,
Bjorn Helgaas <bjorn.helgaas@hp.com>,
linux-kernel@vger.kernel.org
Subject: [patch] serial: compare mapbase and not membase in find_port
Date: Sun, 1 Jan 2006 16:12:31 +0100 [thread overview]
Message-ID: <221e0ff70601010712u6a0d395dq@mail.gmail.com> (raw)
From: Gyorgy Jeney
If the 8250_early driver uses bt_ioremap, find_port() is unable to find the
correct device since the address returned by ioremap is different to that
returned by bt_ioremap for the same address. Since no more than one device
occupies the same physical address, compareing the physical addresses should
be safe.
Signed-off-by: Gyorgy Jeney <nog.lkml@gmail.com>
nog.
--- drivers/serial/8250.c 2005-10-28 02:02:08.000000000 +0200
+++ ../../linux-2.6.14/drivers/serial/8250.c 2006-01-01 10:27:39.000000000 +0100
@@ -2229,7 +2229,7 @@ static int __init find_port(struct uart_
port = &serial8250_ports[line].port;
if (p->iotype == port->iotype &&
p->iobase == port->iobase &&
- p->membase == port->membase)
+ p->mapbase == port->mapbase)
return line;
}
return -ENODEV;
next reply other threads:[~2006-01-01 15:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-01 15:12 Gyorgy Jeney [this message]
2006-01-04 18:12 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=221e0ff70601010712u6a0d395dq@mail.gmail.com \
--to=nog.lkml@gmail.com \
--cc=bjorn.helgaas@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=rmk+serial@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®