From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752270AbdLFSig (ORCPT ); Wed, 6 Dec 2017 13:38:36 -0500 Received: from mout.web.de ([212.227.15.4]:56198 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751208AbdLFSie (ORCPT ); Wed, 6 Dec 2017 13:38:34 -0500 Subject: [PATCH 3/3] uio: Delete two error messages for a failed memory allocation in uio_pdrv_genirq_probe() From: SF Markus Elfring To: kernel-janitors@vger.kernel.org, Greg Kroah-Hartman Cc: LKML References: <2efe226c-065a-b77d-d278-4345ab2586b1@users.sourceforge.net> Message-ID: <222016cb-fe56-0fe6-40b8-0cf77283e97c@users.sourceforge.net> Date: Wed, 6 Dec 2017 19:38:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <2efe226c-065a-b77d-d278-4345ab2586b1@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:WV6vOOt8/3inXpXSE04Ij7H4XjIKLULBGQ8+lIkg1tNg16eOxwm 6G7PLB8x+sHO8y4Mj6BwKmz6PvZkTcUELfWyRsB32QAEVKF/+xLs9ricKgJh8D27dTJ9wwD B7vcobBoi57plvLHWNa1BHiTr+WjanLvkB4cUlHvroj6oqRBn0EjLkunPMxY+M7VCck22hw AGaanjmEkAJwzltYWFe2w== X-UI-Out-Filterresults: notjunk:1;V01:K0:/CPX03gbiTc=:R/dMU6keJc2tmFeEiDKKGj Ue2OvPC7k4oqhcbmxVrBia23OrrSnZAVW63boeCal7TXwW+Qk+/B0x12F5PTZ1z5SSXm/Ex9+ dYFzfaQNsAI+vCQOaNv0eFffXNVIfmOEhJ9mEMqnmobo2guwpEb+2HHFVRlQVivCYqHgtB7ua Ab6BlWZpSPWAvNhL3ocMEdgVOn1uyUqW4cdjKyk68B5ijhVJfpYwvFOdCYCMm77V03nqMoAuP 1RBYmAd/3i4B73tNz/5PavNu2UtdQn9+JJwaS3kUdxX343H80gUBa8NbuCio8nuWqxr4kLUzT IIjWGeR7zidqVDKWxC+nc1yGdqbbDC7qGopTUmqASs3bXS8MXEfjUKmsEpo9kjxLe9o344t5D xpsN32vULQFi80qWA7omwCNwa0OO7dUyamAbfDsNrNOJB2grTtVmUZgHFrnE67DR1g36SBI5T e22pFrKSxxd1IVN0UUnEFI1I3SVlgieyMOonkIcxKpK3Xx8DZBTCzab2lNmjuWWkOmiME3raF p0T0SqX+oK2la129p3Bwj/9Op3p47eWKsxJ5W7RjPXNZjDLUc5GqvGF+T5W3BtPm8nrJI55mJ LNIhk0fpQKxBY9gLfI78W1dSnpkvj8oPtWQdaCNwQ2GX+/m7jQM+1+3bofgeNaTSoqAgrN4Kp GOhvc56Dblodwe3gX+6t/gsaWW3wMKVvYbMp3Xv4gNZpI0315z/QRK6xcTazu4QvPZ5h5trND VjLgyY55yAdK/uVETP/QrXqGIOQ1v5IqnbBaOZOb2LL1HnOUGsBoGosg0MII/m1XBSt4bnQNX nrvJ8CjXY6LqGWUlUMuu9bQnXjRxhKkMbwHDKBhaOTVcj62CQs= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 6 Dec 2017 19:18:12 +0100 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/uio/uio_pdrv_genirq.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/uio/uio_pdrv_genirq.c b/drivers/uio/uio_pdrv_genirq.c index f598ecddc8a7..327fbe766f1c 100644 --- a/drivers/uio/uio_pdrv_genirq.c +++ b/drivers/uio/uio_pdrv_genirq.c @@ -114,10 +114,9 @@ static int uio_pdrv_genirq_probe(struct platform_device *pdev) /* alloc uioinfo for one device */ uioinfo = devm_kzalloc(&pdev->dev, sizeof(*uioinfo), GFP_KERNEL); - if (!uioinfo) { - dev_err(&pdev->dev, "unable to kmalloc\n"); + if (!uioinfo) return -ENOMEM; - } + uioinfo->name = pdev->dev.of_node->name; uioinfo->version = "devicetree"; /* Multiple IRQs are not supported */ @@ -135,10 +134,8 @@ static int uio_pdrv_genirq_probe(struct platform_device *pdev) } priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); - if (!priv) { - dev_err(&pdev->dev, "unable to kmalloc\n"); + if (!priv) return -ENOMEM; - } priv->uioinfo = uioinfo; spin_lock_init(&priv->lock); -- 2.15.1