From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4AA61898E9 for ; Sat, 18 Jan 2025 10:22:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737195764; cv=none; b=KH5CTE0eoBaiClDhre1+36gOvpqRDaYJQ1HlH9ZiBnBWTZk+sRS8TYu/f95iafpjsyOtbKRqW51hM4UkukMSkCeaoCojMiLlbECKiJLVXOb2+m1PGBLKh/sF2Ics99JY7jaqj9CtAGhNoPNq/CM2WFTRETEhWVP8ULqsjFtpcsY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737195764; c=relaxed/simple; bh=4zIPKEsQijcqzQ3nA6LVlbYADaGYU4wuwM3qNa4iVOg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=clDtZaq65Z3tfT+QM3bOAxnBkqQnIiszP2WMH3h/07qNFDpL78fsh59HP4iLUkBLArASgdz9AJ5q1fSqJN8hIoRbXeUb318NZOcm4WTMCgVWfnNA4euiyclCa6Q7vPqDT7CFM+9KJkkCPF1T6HbQxKpPXnfIRn4FBw/6HRsN0IQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mHpPmCkq; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mHpPmCkq" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-ab2aea81cd8so498390666b.2 for ; Sat, 18 Jan 2025 02:22:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737195761; x=1737800561; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eC562IGNdsBslKvrHku3T+cv3/NWv0Sm/Mud6kF3qcU=; b=mHpPmCkqkrY4gJhZpD6Dli3A84ey+K6Zxw5sbeHy7rNMDdAZTHWJjzvBhfh33N2bdx bwywlxx7ZrO9B0XcEk8PIChofSZj4kPJx9GJV2WD9xUl0TTIE4dW9F1u2DUffNu/4fwb 75ghheO+1hS28X2K23eh2RXVoqgpaVUAVjMMptdrDtaj3P/xcKJrbmgZI9iQh+IGYVb8 c2YE9tN78boCbHaPLjtT9R+xA5a9YLsRaV0GA2kBuZ3F5i0P9hXw4VM6fpTNo4XFSSzD jdhQl4PocnVf7h21ZVvHtlnKQ0J8tfJBy6o9hl7x+JKrww8OitXeKamllMlsIC6+gYUB uF5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737195761; x=1737800561; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eC562IGNdsBslKvrHku3T+cv3/NWv0Sm/Mud6kF3qcU=; b=oOQ6GX5J76x2tAMrh2RvFfcMXJkCjaI/hwe9jXUXwmDnWCR84XrCpresILAtEYdYFk Lk+2CIUEq0Z4Ce/SC5e9NChNC82KXefUVxmdYGWfoP6ki/SAvG6MTg4Dq+Q+PpWHwZk1 fwMj86HiicMDv9TSx0SQVf9DmAqkpyF+B2eXajUlibSJa1W1GZSd9uqWkGg9vx9MaYiN zc7H+F4FOIvA/BiPTowFrMuhdQDp2JOEFYA4TMB/cP2LPhS3UK6xmRD4nvbmtOGLGiWR dz0AalUfMOBaoys4MifHAYPVt0EokqycErO/FKioKoaKIjeAw4AEpyDo9hFSoZZ15Weu EbSg== X-Forwarded-Encrypted: i=1; AJvYcCXl4fsQLcsdLBvYXM09rGWzyLdI01f69GihZ9M4Lj0XeSk/QM1MMOLr6lQg1mqaUd9wTcbwvlgmW8WWU+M=@vger.kernel.org X-Gm-Message-State: AOJu0YxKgRXcLuyKUVv7Wd2C94QR1XlxH3/Cha1sJ80cxkogeJkOGcsD KIofJQcpfLd7S73ezyqFIb/XkgwBfIgX79ZnOKbeY44/Pk/NV0/U X-Gm-Gg: ASbGnctoa5eCTNzIivAe+9Hz6qoBi/q0Tzej6jmi0nLxJvzKJ+JWWrMzY2rEKPd8bIT kUy5Cqtd0yAHxBqefzc/fj5S5Py7Ddi2rIg3o+LkAyYJMGFOvAqLGmXHS+gRkSRx6EAK/Fn3k5Q +Q5IQq0BsFRSMOKvm0owSGeRhtIu4fTFwDz6H+Oj1pqsg9bMK/PRMTtjYGLiAXN6oZ9fuAx5dll 1mabQGpajP6/J0gn3sw/rQMZq9vl2Yt2UdCHPgQX/Tg7X/BAPJ5R2iRZgf9w3KmDOoYHPTkvOaW N2f2VZCjn60R8ZY= X-Google-Smtp-Source: AGHT+IE+y1gp+riQD30Inb1lrysJjHeJCu6/sl+o+LPW+5g5AYkhktPoEz8aolwvSzUCLAkf/TSzCQ== X-Received: by 2002:a17:907:d87:b0:aa5:b1b9:5d6a with SMTP id a640c23a62f3a-ab38b3d6d1cmr587932766b.54.1737195760645; Sat, 18 Jan 2025 02:22:40 -0800 (PST) Received: from jernej-laptop.localnet ([188.159.248.16]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab384f86206sm311092166b.134.2025.01.18.02.22.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jan 2025 02:22:40 -0800 (PST) From: Jernej =?UTF-8?B?xaBrcmFiZWM=?= To: Thomas Gleixner , Chen-Yu Tsai , Samuel Holland , "open list:IRQCHIP DRIVERS" , "moderated list:ARM/Allwinner sunXi SoC support" , "open list:ARM/Allwinner sunXi SoC support" , Philippe Simons Cc: Philippe Simons Subject: Re: [PATCH v2] irqchip/sunxi-nmi: add missing flag Date: Sat, 18 Jan 2025 11:22:39 +0100 Message-ID: <2220251.Icojqenx9y@jernej-laptop> In-Reply-To: <20250112123402.388520-1-simons.philippe@gmail.com> References: <20250112123402.388520-1-simons.philippe@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Dne nedelja, 12. januar 2025 ob 13:34:02 Srednjeevropski standardni =C4=8Da= s je Philippe Simons napisal(a): > Some boards with Allwinner SoCs connect the PMIC's IRQ pin to the SoC's > NMI pin instead of a normal GPIO. Since the power key is connected > to the PMIC, and people expect to wake up a suspended system via > this key, the NMI IRQ controller must stay alive when the > system goes into suspend. >=20 > Add the flag to prevent the sunxi NMI controller from going to sleep, > so that the power key can wake up those systems. >=20 > Signed-off-by: Philippe Simons > --- Please provide changelog here. > drivers/irqchip/irq-sunxi-nmi.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/irqchip/irq-sunxi-nmi.c b/drivers/irqchip/irq-sunxi-= nmi.c > index bb92fd85e..8dda0a85e 100644 > --- a/drivers/irqchip/irq-sunxi-nmi.c > +++ b/drivers/irqchip/irq-sunxi-nmi.c > @@ -186,7 +186,9 @@ static int __init sunxi_sc_nmi_irq_init(struct device= _node *node, > gc->chip_types[0].chip.irq_unmask =3D irq_gc_mask_set_bit; > gc->chip_types[0].chip.irq_eoi =3D irq_gc_ack_set_bit; > gc->chip_types[0].chip.irq_set_type =3D sunxi_sc_nmi_set_type; > - gc->chip_types[0].chip.flags =3D IRQCHIP_EOI_THREADED | IRQCHIP_EOI_IF= _HANDLED; > + gc->chip_types[0].chip.flags =3D IRQCHIP_EOI_THREADED | > + IRQCHIP_EOI_IF_HANDLED | > + IRQCHIP_SKIP_SET_WAKE; Alignment seems off. With that fixed: Reviewed-by: Jernej Skrabec gc->chip_types[0].regs.ack =3D reg_offs->pend; > gc->chip_types[0].regs.mask =3D reg_offs->enable; > gc->chip_types[0].regs.type =3D reg_offs->ctrl; >=20