From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Linux PM <linux-pm@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Lukasz Luba <lukasz.luba@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Len Brown <len.brown@intel.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Morten Rasmussen <morten.rasmussen@arm.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Subject: [RFC][PATCH v0.1 4/6] PM: EM: Introduce em_dev_expand_perf_domain()
Date: Fri, 08 Nov 2024 17:40:53 +0100 [thread overview]
Message-ID: <2223963.Mh6RI2rZIc@rjwysocki.net> (raw)
In-Reply-To: <3607404.iIbC2pHGDl@rjwysocki.net>
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Introduce a helper function for adding a CPU to an existing EM perf
domain.
Subsequently, this will be used by the intel_pstate driver to add new
CPUs to existing perf domains when those CPUs go online for the first
time after the initialization of the driver.
No intentional functional impact.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
include/linux/energy_model.h | 5 +++++
kernel/power/energy_model.c | 32 ++++++++++++++++++++++++++++++++
2 files changed, 37 insertions(+)
Index: linux-pm/kernel/power/energy_model.c
===================================================================
--- linux-pm.orig/kernel/power/energy_model.c
+++ linux-pm/kernel/power/energy_model.c
@@ -696,6 +696,38 @@ void em_dev_unregister_perf_domain(struc
}
EXPORT_SYMBOL_GPL(em_dev_unregister_perf_domain);
+/**
+ * em_dev_expand_perf_domain() - Expand CPU perf domain
+ * @dev: CPU device of a CPU in the perf domain.
+ * @new_cpu: CPU to add to the perf domain.
+ */
+int em_dev_expand_perf_domain(struct device *dev, int new_cpu)
+{
+ struct device *new_cpu_dev;
+ struct em_perf_domain *pd;
+
+ if (IS_ERR_OR_NULL(dev) || !_is_cpu_device(dev))
+ return -EINVAL;
+
+ new_cpu_dev = get_cpu_device(new_cpu);
+ if (!new_cpu_dev)
+ return -EINVAL;
+
+ guard(mutex)(&em_pd_mutex);
+
+ if (em_pd_get(new_cpu_dev))
+ return -EEXIST;
+
+ pd = em_pd_get(dev);
+ if (!pd)
+ return -EINVAL;
+
+ cpumask_set_cpu(new_cpu, em_span_cpus(pd));
+ new_cpu_dev->em_pd = pd;
+
+ return 0;
+}
+
static struct em_perf_table __rcu *em_table_dup(struct em_perf_domain *pd)
{
struct em_perf_table __rcu *em_table;
Index: linux-pm/include/linux/energy_model.h
===================================================================
--- linux-pm.orig/include/linux/energy_model.h
+++ linux-pm/include/linux/energy_model.h
@@ -172,6 +172,7 @@ int em_dev_register_perf_domain(struct d
struct em_data_callback *cb, cpumask_t *span,
bool microwatts);
void em_dev_unregister_perf_domain(struct device *dev);
+int em_dev_expand_perf_domain(struct device *dev, int new_cpu);
struct em_perf_table __rcu *em_table_alloc(struct em_perf_domain *pd);
void em_table_free(struct em_perf_table __rcu *table);
int em_dev_compute_costs(struct device *dev, struct em_perf_state *table,
@@ -354,6 +355,10 @@ int em_dev_register_perf_domain(struct d
static inline void em_dev_unregister_perf_domain(struct device *dev)
{
}
+static inline int em_dev_expand_perf_domain(struct device *dev, int new_cpu)
+{
+ return -EINVAL;
+}
static inline struct em_perf_domain *em_cpu_get(int cpu)
{
return NULL;
next prev parent reply other threads:[~2024-11-08 16:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 16:09 [RFC][PATCH v0.1 0/6] cpufreq: intel_pstate: Enable EAS on hybrid platforms without SMT Rafael J. Wysocki
2024-11-08 16:36 ` [RFC][PATCH v0.1 1/6] PM: EM: Move perf rebuilding function from schedutil to EM Rafael J. Wysocki
2024-11-08 16:37 ` [RFC][PATCH v0.1 2/6] PM: EM: Call em_compute_costs() from em_create_perf_table() Rafael J. Wysocki
2024-11-12 8:21 ` Dietmar Eggemann
2024-11-08 16:38 ` [RFC][PATCH v0.1 3/6] PM: EM: Add special case to em_dev_register_perf_domain() Rafael J. Wysocki
2024-11-12 8:21 ` Dietmar Eggemann
2024-11-18 15:24 ` Hongyan Xia
2024-11-19 13:51 ` Rafael J. Wysocki
2024-11-08 16:40 ` Rafael J. Wysocki [this message]
2024-11-08 16:41 ` [RFC][PATCH v0.1 5/6] sched/topology: Allow .setpolicy() cpufreq drivers to enable EAS Rafael J. Wysocki
2024-11-11 11:54 ` Christian Loehle
2024-11-11 13:54 ` Rafael J. Wysocki
2024-11-19 15:13 ` Vincent Guittot
2024-11-19 17:37 ` Peter Zijlstra
2024-11-19 19:28 ` Rafael J. Wysocki
2024-11-08 16:46 ` [RFC][PATCH v0.1 6/6] cpufreq: intel_pstate: Add basic EAS support on hybrid platforms Rafael J. Wysocki
2024-11-12 8:21 ` Dietmar Eggemann
2024-11-19 14:38 ` Rafael J. Wysocki
2024-11-18 16:34 ` Pierre Gondois
2024-11-19 17:20 ` Rafael J. Wysocki
2024-12-16 15:32 ` Pierre Gondois
2024-12-16 17:25 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2223963.Mh6RI2rZIc@rjwysocki.net \
--to=rjw@rjwysocki.net \
--cc=dietmar.eggemann@arm.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=ricardo.neri-calderon@linux.intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®