From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4CC2C4338F for ; Wed, 25 Aug 2021 09:48:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 811AD61153 for ; Wed, 25 Aug 2021 09:48:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237106AbhHYJs6 (ORCPT ); Wed, 25 Aug 2021 05:48:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234177AbhHYJs4 (ORCPT ); Wed, 25 Aug 2021 05:48:56 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA6C0C061757 for ; Wed, 25 Aug 2021 02:48:09 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id e21so34359953ejz.12 for ; Wed, 25 Aug 2021 02:48:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1JEyW4ofYFR7gRvxQ/3QzOt6Hjv6xQimeZo0h4SFCYo=; b=Q6qSO2aNJrvMC4MnKubpHgYs6sVtj61b/0Z13eHl85RB2T7mELC0ljJL4vmVsbCkNB HpLsT7fBPyDvuJlm4aMO0M6X1396xRWmshPhVcbnEUgwBeeWsbMWCOvH1Da9cg5bOuWy 5hN45v2x2JnaPEq/JK6G1LBOfhr4/yJ5HDJNNqNX+LaWBI0Z/0A5ZPA1Mau51fNi5sst Q9V9cN2ZBOO/5jrHgStCVLw+WXuQJLRQxUMugZEMzMs/1E0gZOwilDvTZWfJGX3yVCo7 /cs8+mZ/JdYnyFTiCi18/VnLwwkUeqOKoe2Iy4CnfBF4dybQ4YJR8eb3slWaJVmG/ysK NmSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1JEyW4ofYFR7gRvxQ/3QzOt6Hjv6xQimeZo0h4SFCYo=; b=oIwPyCPND3AESE35FHIdI6IYQJLntIQbVS3m6Jy0ikbwT4JUxCWZ4Qy0T1W97gyH97 oScRnH/glMjeSUGYa8qWpiinQ3B/ghdgX1vf4SCW7xRtsIrCw6byZ7CJvUQVNGizn05s aWUVy8N5Ne056osXxko+d6MjjDh0rJB/zTNbikbuLvz749rh20wMDuqjXunujnm/Tfcw ZeYmwpqqM1tzcG0Ghw7IphgQgxpkVKkK59QaUnXorxGAiMuwS5dCN27PpGCX4kMdcYga eHxWtvZVGxO93f3pLPiB1Rs8rQ1tpAqOMkgKxUpQdXXeV25Xoh42jlnODRXOQFmlfS2L LgAw== X-Gm-Message-State: AOAM531O3ti8tYe3Ng193PCHHbRyvuZWTJecUOVtASQof8sf7o7/h0z8 qE5Muki8u0UI290tL2u8PKY= X-Google-Smtp-Source: ABdhPJxFY5+BnAFtJclQ1CzwvfXeNtjKhPn5zsQ/1GTaHN4W8Uv7IKYdgoY5Phnmjgsa+2qSKwmq/w== X-Received: by 2002:a17:907:5096:: with SMTP id fv22mr8776103ejc.95.1629884888509; Wed, 25 Aug 2021 02:48:08 -0700 (PDT) Received: from localhost.localdomain (host-79-22-100-164.retail.telecomitalia.it. [79.22.100.164]) by smtp.gmail.com with ESMTPSA id x9sm11393068edj.95.2021.08.25.02.48.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Aug 2021 02:48:08 -0700 (PDT) From: "Fabio M. De Francesco" To: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, gregkh@linuxfoundation.org, straube.linux@gmail.com, Pavel Skripkin Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/6] staging: r8188eu: add error handling of rtw_read16 Date: Wed, 25 Aug 2021 11:48:05 +0200 Message-ID: <2227654.mbYB7oqmoa@localhost.localdomain> In-Reply-To: References: <1665728.ljvk3MsED4@localhost.localdomain> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, August 25, 2021 10:22:16 AM CEST Pavel Skripkin wrote: > On 8/25/21 7:35 AM, Fabio M. De Francesco wrote: > > Dear Pavel, > > > > Please note that if and when my patch "Use usb_control_msg_recv / send () in > > usbctrl_vendorreq ()" will be merged, "if (res! = len)" will always evaluate 'true' > > and usb_read16 () will always return -EIO even if usbctrl_vendorreq () succeeds. > > > > Yep, thank you, but it depends on which series will go in first :) > > There is a chance, that you will need to clean up this part, if mine > will be merged before yours > Ha-ha ... I know that beautiful rule: whoever breaks must fix! However there should be another rule which says that the old (me) takes precedence over the young (you) :-) Seriously, thank you so much for your help and the "Reviewed by" tag on my work. Regards, Fabio > With regards, > Pavel Skripkin >